All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
	Mike Frysinger <vapier@gentoo.org>,
	qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
	kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
	Liam Girdwood <lrg@ti.com>,
	joel.clark@intel.com
Subject: Re: [PATCH v2] soc/lapis: add machine driver
Date: Fri, 9 Dec 2011 16:43:38 +0800	[thread overview]
Message-ID: <20111209084337.GJ26952@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQniJR+b1gUwZUUiPoNDKVqU7TCkThLaHL2DFXAF=cARrTA@mail.gmail.com>

On Fri, Dec 09, 2011 at 05:38:57PM +0900, Tomoya MORINAGA wrote:

> Firstly, the above "dai_link structure" means below ? If yes, there is
> no member "dai_fmt", right ?
> 697 struct snd_soc_dai_link {

As previously advised you should work against current development
kernels.  dai_fmt is present in current development kernels (and Linus'
tree for that matter).

> > +     ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
> > +                             SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);

> At the above point, do you mean I shouldn't  set these formats(
> SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS)
> directly ?

Yes.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Daniel Mack <zonque@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
	kok.howg.ewe@intel.com
Subject: Re: [PATCH v2] soc/lapis: add machine driver
Date: Fri, 9 Dec 2011 16:43:38 +0800	[thread overview]
Message-ID: <20111209084337.GJ26952@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQniJR+b1gUwZUUiPoNDKVqU7TCkThLaHL2DFXAF=cARrTA@mail.gmail.com>

On Fri, Dec 09, 2011 at 05:38:57PM +0900, Tomoya MORINAGA wrote:

> Firstly, the above "dai_link structure" means below ? If yes, there is
> no member "dai_fmt", right ?
> 697 struct snd_soc_dai_link {

As previously advised you should work against current development
kernels.  dai_fmt is present in current development kernels (and Linus'
tree for that matter).

> > +     ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S |
> > +                             SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS);

> At the above point, do you mean I shouldn't  set these formats(
> SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS)
> directly ?

Yes.

  reply	other threads:[~2011-12-09  8:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-02  9:45 [PATCH v2] soc/lapis: add machine driver Tomoya MORINAGA
2011-12-02 15:34 ` Mark Brown
2011-12-05  5:28   ` Tomoya MORINAGA
2011-12-05 18:25     ` Mark Brown
2011-12-05  9:33   ` Tomoya MORINAGA
2011-12-05 18:32     ` Mark Brown
2011-12-06  2:02       ` Tomoya MORINAGA
2011-12-06  2:02         ` Tomoya MORINAGA
2011-12-06  2:11         ` [alsa-devel] " Austin, Brian
2011-12-06  2:37           ` Tomoya MORINAGA
2011-12-06  2:37             ` [alsa-devel] " Tomoya MORINAGA
2011-12-06 10:25             ` Mark Brown
2011-12-06 10:25               ` [alsa-devel] " Mark Brown
2011-12-07  4:42         ` Tomoya MORINAGA
2011-12-07 13:23           ` Mark Brown
2011-12-07 13:23             ` Mark Brown
2011-12-09  8:38             ` Tomoya MORINAGA
2011-12-09  8:43               ` Mark Brown [this message]
2011-12-09  8:43                 ` Mark Brown
2011-12-09  9:37                 ` Tomoya MORINAGA
2011-12-09  9:37                   ` Tomoya MORINAGA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111209084337.GJ26952@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=qi.wang@intel.com \
    --cc=tiwai@suse.de \
    --cc=tomoya.rohm@gmail.com \
    --cc=vapier@gentoo.org \
    --cc=yong.y.wang@intel.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.