From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Raghavendra K T <raghukt@linux.vnet.ibm.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Virtualization <virtualization@lists.linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Xen <xen-devel@lists.xensource.com>,
Dave Jiang <dave.jiang@intel.com>, KVM <kvm@vger.kernel.org>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Sasha Levin <levinsasha928@gmail.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Suzuk
Subject: Re: [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks
Date: Wed, 7 Dec 2011 11:39:47 -0200 [thread overview]
Message-ID: <20111207133947.GA1708@amt.cnet> (raw)
In-Reply-To: <4EDF6049.2030204@redhat.com>
On Wed, Dec 07, 2011 at 02:47:05PM +0200, Avi Kivity wrote:
> On 12/07/2011 02:33 PM, Marcelo Tosatti wrote:
> > >
> > > Also Avi pointed that, logically kvm_arch_vcpu_ioctl_set_mpstate should
> > > be called only in vcpu thread, so after further debugging, I noticed
> > > that, setting vcpuN->mp_state = KVM_MP_STATE_RUNNABLE; is not
> > > necessary.
> > > I 'll remove that in the next patch. Thanks for pointing.
> >
> > In fact you don't need kvm_arch_vcpu_ioctl_set_mpstate either, only the
> > new "kicked" flag.
>
> If we have a kicked flag, it becomes necessary to live migrate it.
>
> Maybe we can change KVM_GET_MP_STATE to fold the kicked flag into the mp
> state (converting HALTED into RUNNABLE).
Yep, that works.
> Also I think we can keep the kicked flag in vcpu->requests, no need for
> new storage.
Was going to suggest it but it violates the currently organized
processing of entries at the beginning of vcpu_enter_guest.
That is, this "kicked" flag is different enough from vcpu->requests
processing that a separate variable seems worthwhile (even more
different with convertion to MP_STATE at KVM_GET_MP_STATE).
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Raghavendra K T <raghukt@linux.vnet.ibm.com>,
Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>, KVM <kvm@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Virtualization <virtualization@lists.linux-foundation.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Dave Jiang <dave.jiang@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Gleb Natapov <gleb@redhat.com>, Yinghai Lu <yinghai@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@redhat.com>,
Xen <xen-devel@lists.xensource.com>,
LKML <linux-kernel@vger.kernel.org>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <levinsasha928@gmail.com>,
Suzuki Poulose <suzuki@linux.vnet.ibm.com>,
Dave Hansen <dave@linux.vnet.ibm.com>
Subject: Re: [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks
Date: Wed, 7 Dec 2011 11:39:47 -0200 [thread overview]
Message-ID: <20111207133947.GA1708@amt.cnet> (raw)
In-Reply-To: <4EDF6049.2030204@redhat.com>
On Wed, Dec 07, 2011 at 02:47:05PM +0200, Avi Kivity wrote:
> On 12/07/2011 02:33 PM, Marcelo Tosatti wrote:
> > >
> > > Also Avi pointed that, logically kvm_arch_vcpu_ioctl_set_mpstate should
> > > be called only in vcpu thread, so after further debugging, I noticed
> > > that, setting vcpuN->mp_state = KVM_MP_STATE_RUNNABLE; is not
> > > necessary.
> > > I 'll remove that in the next patch. Thanks for pointing.
> >
> > In fact you don't need kvm_arch_vcpu_ioctl_set_mpstate either, only the
> > new "kicked" flag.
>
> If we have a kicked flag, it becomes necessary to live migrate it.
>
> Maybe we can change KVM_GET_MP_STATE to fold the kicked flag into the mp
> state (converting HALTED into RUNNABLE).
Yep, that works.
> Also I think we can keep the kicked flag in vcpu->requests, no need for
> new storage.
Was going to suggest it but it violates the currently organized
processing of entries at the beginning of vcpu_enter_guest.
That is, this "kicked" flag is different enough from vcpu->requests
processing that a separate variable seems worthwhile (even more
different with convertion to MP_STATE at KVM_GET_MP_STATE).
next prev parent reply other threads:[~2011-12-07 13:39 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 8:59 [PATCH RFC V3 0/4] kvm : Paravirt-spinlock support for KVM guests Raghavendra K T
2011-11-30 8:59 ` [PATCH RFC V3 1/4] debugfs: Add support to print u32 array in debugfs Raghavendra K T
2011-11-30 8:59 ` Raghavendra K T
2011-12-06 0:13 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-12-06 0:13 ` Konrad Rzeszutek Wilk
2011-12-06 0:13 ` Konrad Rzeszutek Wilk
2011-12-06 0:13 ` Konrad Rzeszutek Wilk
2011-11-30 8:59 ` [PATCH RFC V3 2/4] kvm hypervisor : Add a hypercall to KVM hypervisor to support pv-ticketlocks Raghavendra K T
2011-11-30 8:59 ` Raghavendra K T
2011-12-01 11:11 ` Avi Kivity
2011-12-01 11:11 ` Avi Kivity
2011-12-01 19:50 ` Raghavendra K T
2011-12-01 19:50 ` Raghavendra K T
2011-12-01 19:50 ` Raghavendra K T
2011-12-02 12:29 ` Raghavendra K T
2011-12-02 12:29 ` Raghavendra K T
2011-12-02 12:29 ` Raghavendra K T
2011-12-04 18:06 ` Raghavendra K T
2011-12-04 18:06 ` Raghavendra K T
2011-12-04 18:06 ` Raghavendra K T
2011-12-06 16:49 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-12-06 16:49 ` Konrad Rzeszutek Wilk
2011-12-06 16:49 ` Konrad Rzeszutek Wilk
2011-12-07 10:53 ` Avi Kivity
2011-12-07 10:53 ` Avi Kivity
2011-12-08 17:35 ` Raghavendra K T
2011-12-08 17:35 ` Raghavendra K T
2011-12-01 19:50 ` Raghavendra K T
2011-12-07 10:48 ` Marcelo Tosatti
2011-12-07 10:48 ` Marcelo Tosatti
2011-12-07 11:54 ` Raghavendra K T
2011-12-07 11:54 ` Raghavendra K T
2011-12-07 11:54 ` Raghavendra K T
2011-12-07 12:33 ` Marcelo Tosatti
2011-12-07 12:33 ` Marcelo Tosatti
2011-12-07 12:33 ` Marcelo Tosatti
2011-12-07 12:47 ` Avi Kivity
2011-12-07 12:47 ` Avi Kivity
2011-12-07 13:39 ` Marcelo Tosatti [this message]
2011-12-07 13:39 ` Marcelo Tosatti
2011-12-07 14:52 ` Avi Kivity
2011-12-07 14:52 ` Avi Kivity
2011-12-07 16:46 ` Raghavendra K T
2011-12-07 16:46 ` Raghavendra K T
2011-12-07 16:46 ` Raghavendra K T
2011-12-07 16:46 ` Raghavendra K T
2011-12-08 9:40 ` Avi Kivity
2011-12-08 9:40 ` Avi Kivity
2011-12-08 9:40 ` Avi Kivity
2011-12-09 10:59 ` Raghavendra K T
2011-12-09 10:59 ` Raghavendra K T
2011-12-09 10:59 ` Raghavendra K T
2011-12-09 10:59 ` Raghavendra K T
2011-12-07 16:31 ` Raghavendra K T
2011-12-07 16:31 ` Raghavendra K T
2011-12-07 16:31 ` Raghavendra K T
2011-11-30 9:00 ` [PATCH RFC V3 3/4] kvm guest : Added configuration support to enable debug information for KVM Guests Raghavendra K T
2011-11-30 9:00 ` Raghavendra K T
2011-11-30 9:00 ` [PATCH RFC V3 4/4] kvm : pv-ticketlocks support for linux guests running on KVM hypervisor Raghavendra K T
2011-11-30 9:00 ` Raghavendra K T
2011-12-06 3:27 ` Konrad Rzeszutek Wilk
2011-12-06 3:27 ` Konrad Rzeszutek Wilk
2011-12-06 6:54 ` Raghavendra K T
2011-12-06 6:54 ` Raghavendra K T
2011-12-06 6:54 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207133947.GA1708@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=dave.jiang@intel.com \
--cc=dave@linux.vnet.ibm.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=raghukt@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=sedat.dilek@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=vatsa@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.