From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Sylwester Nawrocki <snjw23@gmail.com>,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: S3C64XX: Implement basic power domain support
Date: Wed, 7 Dec 2011 22:44:02 +0100 [thread overview]
Message-ID: <201112072244.02299.rjw@sisk.pl> (raw)
In-Reply-To: <20111202210706.GB15268@opensource.wolfsonmicro.com>
On Friday, December 02, 2011, Mark Brown wrote:
> On Fri, Dec 02, 2011 at 09:10:27PM +0100, Sylwester Nawrocki wrote:
>
> > > + /* Not all domains provide power status readback */
> > > + if (pd->pwr_stat) {
> > > + while (retry--)
> > > + if (__raw_readl(S3C64XX_BLK_PWR_STAT) & pd->pwr_stat)
> > > + break;
>
> > How about adding cpu_relax() in this busy wait loop ?
>
> May as well, yes - I didn't actually measure how long it tends to take
> to do the spin but it's not going to hurt.
Are you going to post an updated patch?
Rafael
WARNING: multiple messages have this Message-ID (diff)
From: rjw@sisk.pl (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: S3C64XX: Implement basic power domain support
Date: Wed, 7 Dec 2011 22:44:02 +0100 [thread overview]
Message-ID: <201112072244.02299.rjw@sisk.pl> (raw)
In-Reply-To: <20111202210706.GB15268@opensource.wolfsonmicro.com>
On Friday, December 02, 2011, Mark Brown wrote:
> On Fri, Dec 02, 2011 at 09:10:27PM +0100, Sylwester Nawrocki wrote:
>
> > > + /* Not all domains provide power status readback */
> > > + if (pd->pwr_stat) {
> > > + while (retry--)
> > > + if (__raw_readl(S3C64XX_BLK_PWR_STAT) & pd->pwr_stat)
> > > + break;
>
> > How about adding cpu_relax() in this busy wait loop ?
>
> May as well, yes - I didn't actually measure how long it tends to take
> to do the spin but it's not going to hurt.
Are you going to post an updated patch?
Rafael
next prev parent reply other threads:[~2011-12-07 21:41 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 18:48 [PATCH 1/3] PM: Provide an always on power domain governor Mark Brown
2011-12-01 18:48 ` Mark Brown
2011-12-01 18:48 ` [PATCH 2/3] ARM: mach-shmobile: Use common " Mark Brown
2011-12-01 18:48 ` Mark Brown
2011-12-01 20:37 ` Rafael J. Wysocki
2011-12-01 20:37 ` Rafael J. Wysocki
2011-12-02 0:33 ` Mark Brown
2011-12-02 0:33 ` Mark Brown
2011-12-02 22:36 ` Rafael J. Wysocki
2011-12-02 22:36 ` Rafael J. Wysocki
2011-12-03 11:03 ` Mark Brown
2011-12-03 11:03 ` Mark Brown
2011-12-03 22:31 ` Rafael J. Wysocki
2011-12-03 22:31 ` Rafael J. Wysocki
2011-12-04 1:22 ` Mark Brown
2011-12-04 1:22 ` Mark Brown
2011-12-04 19:53 ` Rafael J. Wysocki
2011-12-04 19:53 ` Rafael J. Wysocki
2011-12-04 1:24 ` [PATCH v2] " Mark Brown
2011-12-04 1:24 ` Mark Brown
2011-12-01 18:48 ` [PATCH 3/3] ARM: S3C64XX: Implement basic power domain support Mark Brown
2011-12-01 18:48 ` Mark Brown
2011-12-02 0:35 ` Kyungmin Park
2011-12-02 0:35 ` Kyungmin Park
2011-12-02 0:56 ` Mark Brown
2011-12-02 0:56 ` Mark Brown
2011-12-02 18:25 ` Tomasz Figa
2011-12-02 18:25 ` Tomasz Figa
2011-12-02 18:57 ` Mark Brown
2011-12-02 18:57 ` Mark Brown
2011-12-02 19:06 ` Tomasz Figa
2011-12-02 19:06 ` Tomasz Figa
2011-12-02 20:10 ` Sylwester Nawrocki
2011-12-02 20:10 ` Sylwester Nawrocki
2011-12-02 21:07 ` Mark Brown
2011-12-02 21:07 ` Mark Brown
2011-12-07 21:44 ` Rafael J. Wysocki [this message]
2011-12-07 21:44 ` Rafael J. Wysocki
2011-12-08 1:09 ` Mark Brown
2011-12-08 1:09 ` Mark Brown
2011-12-08 22:15 ` Rafael J. Wysocki
2011-12-08 22:15 ` Rafael J. Wysocki
2011-12-08 22:22 ` Rafael J. Wysocki
2011-12-08 22:22 ` Rafael J. Wysocki
2011-12-04 20:56 ` [PATCH 1/3] PM: Provide an always on power domain governor Rafael J. Wysocki
2011-12-04 20:56 ` Rafael J. Wysocki
2011-12-04 23:10 ` Mark Brown
2011-12-04 23:10 ` Mark Brown
2011-12-05 0:15 ` Rafael J. Wysocki
2011-12-05 0:15 ` Rafael J. Wysocki
2011-12-05 0:15 ` Mark Brown
2011-12-05 0:15 ` Mark Brown
2011-12-06 10:20 ` Kukjin Kim
2011-12-06 10:20 ` Kukjin Kim
2011-12-06 12:04 ` Marek Szyprowski
2011-12-06 12:04 ` Marek Szyprowski
2011-12-06 14:33 ` Mark Brown
2011-12-06 14:33 ` Mark Brown
2011-12-06 21:39 ` Rafael J. Wysocki
2011-12-06 21:39 ` Rafael J. Wysocki
2011-12-07 12:35 ` Mark Brown
2011-12-07 12:35 ` Mark Brown
2011-12-07 21:28 ` Rafael J. Wysocki
2011-12-07 21:28 ` Rafael J. Wysocki
2011-12-08 0:40 ` Mark Brown
2011-12-08 0:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112072244.02299.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=snjw23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.