From: Christoph Hellwig <hch@lst.de>
To: Xi Wang <xi.wang@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ben Myers <bpm@sgi.com>,
Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()
Date: Mon, 12 Dec 2011 23:42:27 +0100 [thread overview]
Message-ID: <20111212224227.GA17461@lst.de> (raw)
In-Reply-To: <1323726952-22963-1-git-send-email-xi.wang@gmail.com>
On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote:
> Commit fa8b18ed didn't prevent the integer overflow and possible
> memory corruption. "count" can go negative and bypass the check.
Thanks, this looks good to me.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Xi Wang <xi.wang@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Ben Myers <bpm@sgi.com>,
xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: fix acl count validation in xfs_acl_from_disk()
Date: Mon, 12 Dec 2011 23:42:27 +0100 [thread overview]
Message-ID: <20111212224227.GA17461@lst.de> (raw)
In-Reply-To: <1323726952-22963-1-git-send-email-xi.wang@gmail.com>
On Mon, Dec 12, 2011 at 04:55:52PM -0500, Xi Wang wrote:
> Commit fa8b18ed didn't prevent the integer overflow and possible
> memory corruption. "count" can go negative and bypass the check.
Thanks, this looks good to me.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2011-12-12 22:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 21:55 [PATCH] xfs: fix acl count validation in xfs_acl_from_disk() Xi Wang
2011-12-12 21:55 ` Xi Wang
2011-12-12 22:42 ` Christoph Hellwig [this message]
2011-12-12 22:42 ` Christoph Hellwig
2011-12-16 21:19 ` Ben Myers
2011-12-16 21:19 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212224227.GA17461@lst.de \
--to=hch@lst.de \
--cc=bpm@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.