From: Robin Holt <holt@sgi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sgi-xp: nested calls to spin_lock_irqsave()
Date: Fri, 16 Dec 2011 11:55:00 +0000 [thread overview]
Message-ID: <20111216115500.GD2547@sgi.com> (raw)
In-Reply-To: <20111215064805.GA2776@elgon.mountain>
On Thu, Dec 15, 2011 at 09:48:05AM +0300, Dan Carpenter wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robin Holt <holt@sgi.com>
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] sgi-xp: nested calls to spin_lock_irqsave()
Date: Fri, 16 Dec 2011 05:55:00 -0600 [thread overview]
Message-ID: <20111216115500.GD2547@sgi.com> (raw)
In-Reply-To: <20111215064805.GA2776@elgon.mountain>
On Thu, Dec 15, 2011 at 09:48:05AM +0300, Dan Carpenter wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Robin Holt <holt@sgi.com>
next prev parent reply other threads:[~2011-12-16 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 6:48 [patch] sgi-xp: nested calls to spin_lock_irqsave() Dan Carpenter
2011-12-15 6:48 ` Dan Carpenter
2011-12-16 11:55 ` Robin Holt [this message]
2011-12-16 11:55 ` Robin Holt
2012-06-27 13:51 ` Robin Holt
2012-06-27 13:51 ` Robin Holt
2012-06-28 22:03 ` Andrew Morton
2012-06-28 22:03 ` Andrew Morton
2012-06-29 6:44 ` Dan Carpenter
2012-06-29 6:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216115500.GD2547@sgi.com \
--to=holt@sgi.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.