From: Andrew Morton <akpm@linux-foundation.org>
To: Robin Holt <holt@sgi.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Jack Steiner <steiner@sgi.com>
Subject: Re: [patch] sgi-xp: nested calls to spin_lock_irqsave()
Date: Thu, 28 Jun 2012 22:03:42 +0000 [thread overview]
Message-ID: <20120628150342.aaa4ad2d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120627135155.GA3464@sgi.com>
On Wed, 27 Jun 2012 08:51:55 -0500
Robin Holt <holt@sgi.com> wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
Please find large crayon and write on forehead "when fixing a bug,
be sure to describe the end-user impact of that bug".
Then others will have a chance of deciding whether the fix should be
backported.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Robin Holt <holt@sgi.com>
I'm wondering if there should have been a Reported-by:dan in there.
He's like that.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Robin Holt <holt@sgi.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Jack Steiner <steiner@sgi.com>
Subject: Re: [patch] sgi-xp: nested calls to spin_lock_irqsave()
Date: Thu, 28 Jun 2012 15:03:42 -0700 [thread overview]
Message-ID: <20120628150342.aaa4ad2d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120627135155.GA3464@sgi.com>
On Wed, 27 Jun 2012 08:51:55 -0500
Robin Holt <holt@sgi.com> wrote:
> The code here has a nested spin_lock_irqsave(). It's not needed since
> IRQs are already disabled and it causes a problem because it means that
> IRQs won't be enabled again at the end. The second call to
> spin_lock_irqsave() will overwrite the value of irq_flags and we can't
> restore the proper settings.
Please find large crayon and write on forehead "when fixing a bug,
be sure to describe the end-user impact of that bug".
Then others will have a chance of deciding whether the fix should be
backported.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Robin Holt <holt@sgi.com>
I'm wondering if there should have been a Reported-by:dan in there.
He's like that.
next prev parent reply other threads:[~2012-06-28 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 6:48 [patch] sgi-xp: nested calls to spin_lock_irqsave() Dan Carpenter
2011-12-15 6:48 ` Dan Carpenter
2011-12-16 11:55 ` Robin Holt
2011-12-16 11:55 ` Robin Holt
2012-06-27 13:51 ` Robin Holt
2012-06-27 13:51 ` Robin Holt
2012-06-28 22:03 ` Andrew Morton [this message]
2012-06-28 22:03 ` Andrew Morton
2012-06-29 6:44 ` Dan Carpenter
2012-06-29 6:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120628150342.aaa4ad2d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=holt@sgi.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.