From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
'Ben Dooks' <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Linux USB Mailing List"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Subject: [PATCH v4 0/8] s3c-hsudc: regulator handling and a lot of fixes
Date: Mon, 19 Dec 2011 19:38:21 +0100 [thread overview]
Message-ID: <201112191938.22254.heiko@sntech.de> (raw)
In his response to the first submission Felipe Balbi asked to also move
the driver to the new udc_start and udc_stop functions and to make an
effort to reduce dependencies on archictecture code.
v3 of the series does not try to provide a remove function, due to the
possible lifetime problem of gadget.dev found by Russel King.
v4 also gets rid of the the_controller global and uses container_of instead
and moves the platform-data header to include/linux/platform_data.
The first patch reduces the number of arch dependencies by one by moving
the platform data struct to a header unter include/linux/usb.
The fourth and fifth patches implement the move to udc_start / udc_stop
And the sixt patch finally allows the s3c-hsudc driver to control its
supplying regulators as intended in the first place.
The regulator calls can use the regulators unconditionally and let
necessary "stubbing and mapping" happen through the regulator framework,
according to for example
http://marc.info/?l=linux-netdev&m=131914562120725&w=2
meaning there is no need to gracefully fail if a regulator is not present.
Each patch was compile-tested individually, the series applies cleanly
against linux-next from 2011-12-16.
Real-life testing happened on S3C2416 hardware.
Heiko Stuebner (8):
s3c-hsudc: move platform_data struct to global header
s3c-hsudc: add __devinit to probe function
s3c-hsudc: add missing otg_put_transceiver in probe
s3c-hsudc: move device registration to probe
s3c-hsudc: use udc_start and udc_stop functions
s3c-hsudc: Add regulator handling
s3c-hsudc: use release_mem_region instead of release_resource
s3c-hsudc: remove the_controller global
arch/arm/mach-s3c2416/mach-smdk2416.c | 1 +
arch/arm/plat-samsung/devs.c | 1 +
arch/arm/plat-samsung/include/plat/udc.h | 15 +----
drivers/usb/gadget/s3c-hsudc.c | 120 +++++++++++++++++-------------
include/linux/platform_data/s3c-hsudc.h | 34 +++++++++
5 files changed, 106 insertions(+), 65 deletions(-)
create mode 100644 include/linux/platform_data/s3c-hsudc.h
--
1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/8] s3c-hsudc: regulator handling and a lot of fixes
Date: Mon, 19 Dec 2011 19:38:21 +0100 [thread overview]
Message-ID: <201112191938.22254.heiko@sntech.de> (raw)
In his response to the first submission Felipe Balbi asked to also move
the driver to the new udc_start and udc_stop functions and to make an
effort to reduce dependencies on archictecture code.
v3 of the series does not try to provide a remove function, due to the
possible lifetime problem of gadget.dev found by Russel King.
v4 also gets rid of the the_controller global and uses container_of instead
and moves the platform-data header to include/linux/platform_data.
The first patch reduces the number of arch dependencies by one by moving
the platform data struct to a header unter include/linux/usb.
The fourth and fifth patches implement the move to udc_start / udc_stop
And the sixt patch finally allows the s3c-hsudc driver to control its
supplying regulators as intended in the first place.
The regulator calls can use the regulators unconditionally and let
necessary "stubbing and mapping" happen through the regulator framework,
according to for example
http://marc.info/?l=linux-netdev&m=131914562120725&w=2
meaning there is no need to gracefully fail if a regulator is not present.
Each patch was compile-tested individually, the series applies cleanly
against linux-next from 2011-12-16.
Real-life testing happened on S3C2416 hardware.
Heiko Stuebner (8):
s3c-hsudc: move platform_data struct to global header
s3c-hsudc: add __devinit to probe function
s3c-hsudc: add missing otg_put_transceiver in probe
s3c-hsudc: move device registration to probe
s3c-hsudc: use udc_start and udc_stop functions
s3c-hsudc: Add regulator handling
s3c-hsudc: use release_mem_region instead of release_resource
s3c-hsudc: remove the_controller global
arch/arm/mach-s3c2416/mach-smdk2416.c | 1 +
arch/arm/plat-samsung/devs.c | 1 +
arch/arm/plat-samsung/include/plat/udc.h | 15 +----
drivers/usb/gadget/s3c-hsudc.c | 120 +++++++++++++++++-------------
include/linux/platform_data/s3c-hsudc.h | 34 +++++++++
5 files changed, 106 insertions(+), 65 deletions(-)
create mode 100644 include/linux/platform_data/s3c-hsudc.h
--
1.7.2.3
next reply other threads:[~2011-12-19 18:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 18:38 Heiko Stübner [this message]
2011-12-19 18:38 ` [PATCH v4 0/8] s3c-hsudc: regulator handling and a lot of fixes Heiko Stübner
[not found] ` <201112191938.22254.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-19 18:39 ` [PATCH 1/8] s3c-hsudc: move platform_data struct to global header Heiko Stübner
2011-12-19 18:39 ` Heiko Stübner
[not found] ` <201112191939.16542.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-20 11:25 ` Felipe Balbi
2011-12-20 11:25 ` Felipe Balbi
2011-12-20 11:36 ` Heiko Stübner
2011-12-20 11:36 ` Heiko Stübner
2011-12-21 4:06 ` Kukjin Kim
2011-12-21 4:06 ` Kukjin Kim
2011-12-21 11:25 ` Felipe Balbi
2011-12-21 11:25 ` Felipe Balbi
2011-12-19 18:39 ` [PATCH 2/8] s3c-hsudc: add __devinit to probe function Heiko Stübner
2011-12-19 18:39 ` Heiko Stübner
2011-12-19 18:43 ` [PATCH 8/8] s3c-hsudc: remove the_controller global Heiko Stübner
2011-12-19 18:43 ` Heiko Stübner
2011-12-20 11:27 ` Felipe Balbi
2011-12-20 11:27 ` Felipe Balbi
2011-12-20 11:29 ` Felipe Balbi
2011-12-20 11:29 ` Felipe Balbi
2011-12-19 18:40 ` [PATCH 3/8] s3c-hsudc: add missing otg_put_transceiver in probe Heiko Stübner
2011-12-19 18:40 ` Heiko Stübner
2011-12-19 18:41 ` [PATCH 4/8] s3c-hsudc: move device registration to probe Heiko Stübner
2011-12-19 18:41 ` Heiko Stübner
2011-12-19 18:41 ` [PATCH 5/8] s3c-hsudc: use udc_start and udc_stop functions Heiko Stübner
2011-12-19 18:41 ` Heiko Stübner
2011-12-20 11:23 ` Felipe Balbi
2011-12-20 11:23 ` Felipe Balbi
2011-12-19 18:42 ` [PATCH 6/8] s3c-hsudc: Add regulator handling Heiko Stübner
2011-12-19 18:42 ` Heiko Stübner
2011-12-19 18:42 ` [PATCH 7/8] s3c-hsudc: use release_mem_region instead of release_resource Heiko Stübner
2011-12-19 18:42 ` Heiko Stübner
[not found] ` <201112191942.52629.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-20 20:10 ` Russell King - ARM Linux
2011-12-20 20:10 ` Russell King - ARM Linux
2011-12-20 21:09 ` Felipe Balbi
2011-12-20 21:09 ` Felipe Balbi
2011-12-20 21:19 ` Russell King - ARM Linux
2011-12-20 21:19 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112191938.22254.heiko@sntech.de \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.