From: "Heiko Stübner" <heiko@sntech.de>
To: Felipe Balbi <balbi@ti.com>, Kukjin Kim <kgene.kim@samsung.com>,
'Ben Dooks' <ben-linux@fluff.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: [PATCH 7/8] s3c-hsudc: use release_mem_region instead of release_resource
Date: Mon, 19 Dec 2011 19:42:52 +0100 [thread overview]
Message-ID: <201112191942.52629.heiko@sntech.de> (raw)
In-Reply-To: <201112191938.22254.heiko@sntech.de>
As the memory region is requested through request_mem_region
use the correct paired method to release it in the error path
and don't go "beneath the API" as pointed out by Russel King.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/usb/gadget/s3c-hsudc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index c8ac13a..8e69758 100644
--- a/drivers/usb/gadget/s3c-hsudc.c
+++ b/drivers/usb/gadget/s3c-hsudc.c
@@ -1376,9 +1376,7 @@ err_irq:
iounmap(hsudc->regs);
err_remap:
- release_resource(hsudc->mem_rsrc);
- kfree(hsudc->mem_rsrc);
-
+ release_mem_region(res->start, resource_size(res));
err_res:
if (hsudc->transceiver)
otg_put_transceiver(hsudc->transceiver);
--
1.7.2.3
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] s3c-hsudc: use release_mem_region instead of release_resource
Date: Mon, 19 Dec 2011 19:42:52 +0100 [thread overview]
Message-ID: <201112191942.52629.heiko@sntech.de> (raw)
In-Reply-To: <201112191938.22254.heiko@sntech.de>
As the memory region is requested through request_mem_region
use the correct paired method to release it in the error path
and don't go "beneath the API" as pointed out by Russel King.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/usb/gadget/s3c-hsudc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index c8ac13a..8e69758 100644
--- a/drivers/usb/gadget/s3c-hsudc.c
+++ b/drivers/usb/gadget/s3c-hsudc.c
@@ -1376,9 +1376,7 @@ err_irq:
iounmap(hsudc->regs);
err_remap:
- release_resource(hsudc->mem_rsrc);
- kfree(hsudc->mem_rsrc);
-
+ release_mem_region(res->start, resource_size(res));
err_res:
if (hsudc->transceiver)
otg_put_transceiver(hsudc->transceiver);
--
1.7.2.3
next prev parent reply other threads:[~2011-12-19 18:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 18:38 [PATCH v4 0/8] s3c-hsudc: regulator handling and a lot of fixes Heiko Stübner
2011-12-19 18:38 ` Heiko Stübner
2011-12-19 18:40 ` [PATCH 3/8] s3c-hsudc: add missing otg_put_transceiver in probe Heiko Stübner
2011-12-19 18:40 ` Heiko Stübner
2011-12-19 18:41 ` [PATCH 4/8] s3c-hsudc: move device registration to probe Heiko Stübner
2011-12-19 18:41 ` Heiko Stübner
2011-12-19 18:41 ` [PATCH 5/8] s3c-hsudc: use udc_start and udc_stop functions Heiko Stübner
2011-12-19 18:41 ` Heiko Stübner
2011-12-20 11:23 ` Felipe Balbi
2011-12-20 11:23 ` Felipe Balbi
2011-12-19 18:42 ` [PATCH 6/8] s3c-hsudc: Add regulator handling Heiko Stübner
2011-12-19 18:42 ` Heiko Stübner
2011-12-19 18:42 ` Heiko Stübner [this message]
2011-12-19 18:42 ` [PATCH 7/8] s3c-hsudc: use release_mem_region instead of release_resource Heiko Stübner
[not found] ` <201112191942.52629.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-20 20:10 ` Russell King - ARM Linux
2011-12-20 20:10 ` Russell King - ARM Linux
2011-12-20 21:09 ` Felipe Balbi
2011-12-20 21:09 ` Felipe Balbi
2011-12-20 21:19 ` Russell King - ARM Linux
2011-12-20 21:19 ` Russell King - ARM Linux
[not found] ` <201112191938.22254.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-19 18:39 ` [PATCH 1/8] s3c-hsudc: move platform_data struct to global header Heiko Stübner
2011-12-19 18:39 ` Heiko Stübner
[not found] ` <201112191939.16542.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2011-12-20 11:25 ` Felipe Balbi
2011-12-20 11:25 ` Felipe Balbi
2011-12-20 11:36 ` Heiko Stübner
2011-12-20 11:36 ` Heiko Stübner
2011-12-21 4:06 ` Kukjin Kim
2011-12-21 4:06 ` Kukjin Kim
2011-12-21 11:25 ` Felipe Balbi
2011-12-21 11:25 ` Felipe Balbi
2011-12-19 18:39 ` [PATCH 2/8] s3c-hsudc: add __devinit to probe function Heiko Stübner
2011-12-19 18:39 ` Heiko Stübner
2011-12-19 18:43 ` [PATCH 8/8] s3c-hsudc: remove the_controller global Heiko Stübner
2011-12-19 18:43 ` Heiko Stübner
2011-12-20 11:27 ` Felipe Balbi
2011-12-20 11:27 ` Felipe Balbi
2011-12-20 11:29 ` Felipe Balbi
2011-12-20 11:29 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112191942.52629.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.