From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Mandeep Singh Baines
<msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
Subject: Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration
Date: Tue, 20 Dec 2011 11:14:43 -0800 [thread overview]
Message-ID: <20111220191443.GE10752@google.com> (raw)
In-Reply-To: <1324407673-18975-1-git-send-email-fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello, Frederic.
On Tue, Dec 20, 2011 at 08:01:12PM +0100, Frederic Weisbecker wrote:
> When we fetch the css_set of the tasks on cgroup migration, we don't need
> anymore to synchronize against cgroup_exit() that could swap the old one
> with init_css_set. Now that we are using threadgroup_lock() during
> the migrations, we don't need to worry about it anymore.
>
> Signed-off-by: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Cc: Containers <containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
> Cc: Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Cc: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> Cc: Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
> Cc: Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
I like this but it doesn't apply on top of cgroup/for-3.3. It
collides with Mandeep's patch. Can you please rebase?
Li, can you please ack?
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Containers <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>,
Mandeep Singh Baines <msb@chromium.org>
Subject: Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration
Date: Tue, 20 Dec 2011 11:14:43 -0800 [thread overview]
Message-ID: <20111220191443.GE10752@google.com> (raw)
In-Reply-To: <1324407673-18975-1-git-send-email-fweisbec@gmail.com>
Hello, Frederic.
On Tue, Dec 20, 2011 at 08:01:12PM +0100, Frederic Weisbecker wrote:
> When we fetch the css_set of the tasks on cgroup migration, we don't need
> anymore to synchronize against cgroup_exit() that could swap the old one
> with init_css_set. Now that we are using threadgroup_lock() during
> the migrations, we don't need to worry about it anymore.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Containers <containers@lists.linux-foundation.org>
> Cc: Cgroups <cgroups@vger.kernel.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Paul Menage <paul@paulmenage.org>
> Cc: Mandeep Singh Baines <msb@chromium.org>
I like this but it doesn't apply on top of cgroup/for-3.3. It
collides with Mandeep's patch. Can you please rebase?
Li, can you please ack?
Thanks.
--
tejun
next prev parent reply other threads:[~2011-12-20 19:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 16:38 [PATCH] cgroup: remove redundate get/put of old css_set from migrate Mandeep Singh Baines
2011-12-16 16:38 ` Mandeep Singh Baines
2011-12-16 16:38 ` Mandeep Singh Baines
[not found] ` <1324053511-24591-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-17 16:41 ` Frederic Weisbecker
2011-12-17 16:41 ` Frederic Weisbecker
2011-12-17 16:41 ` Frederic Weisbecker
2011-12-19 2:01 ` Frederic Weisbecker
2011-12-19 2:01 ` Frederic Weisbecker
2011-12-19 2:01 ` Frederic Weisbecker
2011-12-19 17:16 ` Tejun Heo
2011-12-19 17:16 ` Tejun Heo
2011-12-19 17:20 ` Tejun Heo
2011-12-19 17:20 ` Tejun Heo
[not found] ` <20111219172027.GJ24519-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-19 18:44 ` [PATCH v2] " Mandeep Singh Baines
2011-12-19 18:44 ` Mandeep Singh Baines
2011-12-19 18:44 ` Mandeep Singh Baines
[not found] ` <1324320274-18485-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 18:45 ` Frederic Weisbecker
2011-12-20 18:45 ` Frederic Weisbecker
2011-12-20 18:45 ` Frederic Weisbecker
2011-12-20 19:01 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Frederic Weisbecker
2011-12-20 19:01 ` Frederic Weisbecker
[not found] ` <1324407673-18975-1-git-send-email-fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-12-20 19:01 ` [PATCH 2/2] cgroup: Drop task_lock(parent) on cgroup_fork() Frederic Weisbecker
2011-12-20 19:01 ` Frederic Weisbecker
2011-12-20 19:14 ` Tejun Heo [this message]
2011-12-20 19:14 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Tejun Heo
[not found] ` <20111220191443.GE10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 19:27 ` Frederic Weisbecker
2011-12-20 19:27 ` Frederic Weisbecker
2011-12-20 21:29 ` Mandeep Singh Baines
2011-12-20 21:29 ` Mandeep Singh Baines
2011-12-20 21:29 ` Mandeep Singh Baines
2011-12-21 1:53 ` Li Zefan
2011-12-21 1:53 ` Li Zefan
2011-12-20 19:01 ` Frederic Weisbecker
2011-12-19 17:20 ` [PATCH] cgroup: remove redundate get/put of old css_set from migrate Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220191443.GE10752@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.