* Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7
@ 2012-01-01 21:38 Vincent Pelletier
[not found] ` <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Pelletier @ 2012-01-01 21:38 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Ben Skeggs
Hi.
Updating nouveau module to a newer git revision, I noticed I lost hwmon.
I ran a bisect, which identified 63daa9589cb88617d9cc8a0b0282564682a975b7 as
being the first bad commit.
Adding printk traces, I saw that probing i2c bus 3 for sensors always failed
with -EIO (no ack from slave). After reading the code, remembering how i2c
works and reading sample code on wikipedia, I couldn't identify any
algorythmic problem.
So I gave a try at changing delays. I doubled T_RISEFALL and T_HOLD, and the
adt7473 chip could be detected & used again. I haven't tested other
combination, nor tried to link those delays with any datasheet.
My card is a GTX 280.
Regards,
--
Vincent Pelletier
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7 [not found] ` <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2012-01-02 22:40 ` Ben Skeggs 2012-01-03 8:22 ` Vincent Pelletier 2012-01-20 21:32 ` Vincent Pelletier 0 siblings, 2 replies; 4+ messages in thread From: Ben Skeggs @ 2012-01-02 22:40 UTC (permalink / raw) To: Vincent Pelletier; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Sun, 2012-01-01 at 22:38 +0100, Vincent Pelletier wrote: > Hi. Hey, > > Updating nouveau module to a newer git revision, I noticed I lost hwmon. > > I ran a bisect, which identified 63daa9589cb88617d9cc8a0b0282564682a975b7 as > being the first bad commit. > > Adding printk traces, I saw that probing i2c bus 3 for sensors always failed > with -EIO (no ack from slave). After reading the code, remembering how i2c > works and reading sample code on wikipedia, I couldn't identify any > algorythmic problem. > > So I gave a try at changing delays. I doubled T_RISEFALL and T_HOLD, and the > adt7473 chip could be detected & used again. I haven't tested other > combination, nor tried to link those delays with any datasheet. Apologies for the breakage, and thanks for looking into the cause! Could you identify whether both timeouts needed doubling, or just one of them? Thanks, Ben. > > My card is a GTX 280. > > Regards, ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7 2012-01-02 22:40 ` Ben Skeggs @ 2012-01-03 8:22 ` Vincent Pelletier 2012-01-20 21:32 ` Vincent Pelletier 1 sibling, 0 replies; 4+ messages in thread From: Vincent Pelletier @ 2012-01-03 8:22 UTC (permalink / raw) To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Le lundi 02 janvier 2012 23:40:10, Ben Skeggs a écrit : > Could you identify whether both timeouts needed doubling, or just one of > them? Not yet, and it seems there is still a problem: sensors report temperatures of +16k°C from time to time, making psensor go crazy. Maybe it's just the timing being too long now when receiving data... I intend to do more testing this week. Regards, -- Vincent Pelletier _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7 2012-01-02 22:40 ` Ben Skeggs 2012-01-03 8:22 ` Vincent Pelletier @ 2012-01-20 21:32 ` Vincent Pelletier 1 sibling, 0 replies; 4+ messages in thread From: Vincent Pelletier @ 2012-01-20 21:32 UTC (permalink / raw) To: bskeggs-H+wXaHxf7aLQT0dZR+AlfA; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Le lundi 02 janvier 2012 23:40:10, Ben Skeggs a écrit : > Could you identify whether both timeouts needed doubling, or just one of > them? Ahem, it has been a bit more than a week. Oh well. I tried lowering both defines toward their original value, and failed wuite early. Those are the minimums with which I got success: #define T_RISEFALL 4500 #define T_HOLD 9500 Lowering either by 50 makes hwmon disappear. Looks like I got lucky on the first try with my 5k/10k... Sensors still report +16k°C occasionally, so I must be getting something wrong somewhere. If needed, I can try to disassemble my card (I already failed once to remove the cover, but didn't have an actual motivation) and see what my DSO Nano can get - if I can find the trace. -- Vincent Pelletier _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-20 21:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-01 21:38 Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7 Vincent Pelletier
[not found] ` <201201012238.25620.plr.vincent-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-02 22:40 ` Ben Skeggs
2012-01-03 8:22 ` Vincent Pelletier
2012-01-20 21:32 ` Vincent Pelletier
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.