From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name
Date: Thu, 5 Jan 2012 18:27:34 -0800 [thread overview]
Message-ID: <20120106022734.GB6276@google.com> (raw)
In-Reply-To: <4F065B6F.6060506-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Hello,
On Fri, Jan 06, 2012 at 10:24:47AM +0800, Li Zefan wrote:
> There's a corner case where "mount --bind" can't be used:
>
> # mount -t cgroup -o none,name=hier1 xxx /mnt
> # mkdir /mnt/tmp
> # umount /mnt
>
> Since there's a sub-cgroup in it, umount won't destroy the hierarchy,
> but "hide" it, so the name=xxx is necessary to re-mount it.
>
> > Also, what's the use case for
> > mounting the same cgroup directory multiple times? Why is that
> > necessary? Is it useful for some namespace-savvy setup?
>
> I don't have a use case in real life. It was made so at the very
> beginning of cgroup, and we should't break it without strong reasons.
> We can mount other pseudo filesystems like procfs, sysfs and debugfs
> multiple times, right?
Yeah, we shouldn't break it so I applied the patch with a lot of
grumbling. This is something which shouldn't have existed at all. :(
Thanks a lot for the explanation and patience.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name
Date: Thu, 5 Jan 2012 18:27:34 -0800 [thread overview]
Message-ID: <20120106022734.GB6276@google.com> (raw)
In-Reply-To: <4F065B6F.6060506@cn.fujitsu.com>
Hello,
On Fri, Jan 06, 2012 at 10:24:47AM +0800, Li Zefan wrote:
> There's a corner case where "mount --bind" can't be used:
>
> # mount -t cgroup -o none,name=hier1 xxx /mnt
> # mkdir /mnt/tmp
> # umount /mnt
>
> Since there's a sub-cgroup in it, umount won't destroy the hierarchy,
> but "hide" it, so the name=xxx is necessary to re-mount it.
>
> > Also, what's the use case for
> > mounting the same cgroup directory multiple times? Why is that
> > necessary? Is it useful for some namespace-savvy setup?
>
> I don't have a use case in real life. It was made so at the very
> beginning of cgroup, and we should't break it without strong reasons.
> We can mount other pseudo filesystems like procfs, sysfs and debugfs
> multiple times, right?
Yeah, we shouldn't break it so I applied the patch with a lot of
grumbling. This is something which shouldn't have existed at all. :(
Thanks a lot for the explanation and patience.
--
tejun
next prev parent reply other threads:[~2012-01-06 2:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 2:10 [PATCH] cgroup: fix to allow mounting a hierarchy by name Li Zefan
[not found] ` <4EF9291D.7030208-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-27 6:25 ` [PATCH v2] " Li Zefan
2011-12-27 6:25 ` Li Zefan
[not found] ` <4EF964F3.8090705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-05 18:00 ` Tejun Heo
2012-01-05 18:00 ` Tejun Heo
2011-12-27 16:35 ` [PATCH] " Tejun Heo
2011-12-27 16:35 ` Tejun Heo
[not found] ` <20111227163535.GA17712-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-28 6:10 ` Li Zefan
2011-12-28 6:10 ` Li Zefan
[not found] ` <4EFAB2E2.4040008-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-28 6:12 ` Li Zefan
2011-12-28 6:12 ` Li Zefan
2011-12-28 16:36 ` Tejun Heo
2011-12-28 16:36 ` Tejun Heo
[not found] ` <20111228163631.GN17712-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-29 2:50 ` Li Zefan
2011-12-29 2:50 ` Li Zefan
[not found] ` <4EFBD55E.5030106-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-29 16:23 ` Tejun Heo
2011-12-29 16:23 ` Tejun Heo
[not found] ` <20111229162313.GD3516-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-30 5:58 ` Li Zefan
2011-12-30 5:58 ` Li Zefan
[not found] ` <4EFD531C.50300-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-05 2:20 ` Li Zefan
2012-01-05 2:20 ` Li Zefan
2012-01-05 17:45 ` Tejun Heo
2012-01-05 17:45 ` Tejun Heo
[not found] ` <20120105174507.GC18486-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-01-06 2:24 ` Li Zefan
2012-01-06 2:24 ` Li Zefan
[not found] ` <4F065B6F.6060506-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-06 2:27 ` Tejun Heo [this message]
2012-01-06 2:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106022734.GB6276@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.