From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v2] cgroup: fix to allow mounting a hierarchy by name
Date: Tue, 27 Dec 2011 14:25:55 +0800 [thread overview]
Message-ID: <4EF964F3.8090705@cn.fujitsu.com> (raw)
In-Reply-To: <4EF9291D.7030208-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
If we mount a hierarchy with a specified name, the name is unique,
and we can use it to mount the hierarchy without specifying its
set of subsystem names. This feature is documented is
Documentation/cgroups/cgroups.txt section 2.3
Here's an example:
# mount -t cgroup -o cpuset,name=myhier xxx /cgroup1
# mount -t cgroup -o name=myhier xxx /cgroup2
But it was broken by commit 32a8cf235e2f192eb002755076994525cdbaa35a
(cgroup: make the mount options parsing more accurate)
This fixes the regression.
Signed-off-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
v2: fix code comment s/or/and
---
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1042b3c..8e412fd 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1193,10 +1193,10 @@ static int parse_cgroupfs_options(char *data, struct cgroup_sb_opts *opts)
/*
* If the 'all' option was specified select all the subsystems,
- * otherwise 'all, 'none' and a subsystem name options were not
- * specified, let's default to 'all'
+ * otherwise if 'none', 'name=' and a subsystem name options
+ * were not specified, let's default to 'all'
*/
- if (all_ss || (!all_ss && !one_ss && !opts->none)) {
+ if (all_ss || (!one_ss && !opts->none && !opts->name)) {
for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
struct cgroup_subsys *ss = subsys[i];
if (ss == NULL)
--
1.7.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: [PATCH v2] cgroup: fix to allow mounting a hierarchy by name
Date: Tue, 27 Dec 2011 14:25:55 +0800 [thread overview]
Message-ID: <4EF964F3.8090705@cn.fujitsu.com> (raw)
In-Reply-To: <4EF9291D.7030208@cn.fujitsu.com>
If we mount a hierarchy with a specified name, the name is unique,
and we can use it to mount the hierarchy without specifying its
set of subsystem names. This feature is documented is
Documentation/cgroups/cgroups.txt section 2.3
Here's an example:
# mount -t cgroup -o cpuset,name=myhier xxx /cgroup1
# mount -t cgroup -o name=myhier xxx /cgroup2
But it was broken by commit 32a8cf235e2f192eb002755076994525cdbaa35a
(cgroup: make the mount options parsing more accurate)
This fixes the regression.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
v2: fix code comment s/or/and
---
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1042b3c..8e412fd 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1193,10 +1193,10 @@ static int parse_cgroupfs_options(char *data, struct cgroup_sb_opts *opts)
/*
* If the 'all' option was specified select all the subsystems,
- * otherwise 'all, 'none' and a subsystem name options were not
- * specified, let's default to 'all'
+ * otherwise if 'none', 'name=' and a subsystem name options
+ * were not specified, let's default to 'all'
*/
- if (all_ss || (!all_ss && !one_ss && !opts->none)) {
+ if (all_ss || (!one_ss && !opts->none && !opts->name)) {
for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
struct cgroup_subsys *ss = subsys[i];
if (ss == NULL)
--
1.7.3.1
next prev parent reply other threads:[~2011-12-27 6:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 2:10 [PATCH] cgroup: fix to allow mounting a hierarchy by name Li Zefan
[not found] ` <4EF9291D.7030208-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-27 6:25 ` Li Zefan [this message]
2011-12-27 6:25 ` [PATCH v2] " Li Zefan
[not found] ` <4EF964F3.8090705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-05 18:00 ` Tejun Heo
2012-01-05 18:00 ` Tejun Heo
2011-12-27 16:35 ` [PATCH] " Tejun Heo
2011-12-27 16:35 ` Tejun Heo
[not found] ` <20111227163535.GA17712-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-28 6:10 ` Li Zefan
2011-12-28 6:10 ` Li Zefan
[not found] ` <4EFAB2E2.4040008-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-28 6:12 ` Li Zefan
2011-12-28 6:12 ` Li Zefan
2011-12-28 16:36 ` Tejun Heo
2011-12-28 16:36 ` Tejun Heo
[not found] ` <20111228163631.GN17712-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-29 2:50 ` Li Zefan
2011-12-29 2:50 ` Li Zefan
[not found] ` <4EFBD55E.5030106-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-29 16:23 ` Tejun Heo
2011-12-29 16:23 ` Tejun Heo
[not found] ` <20111229162313.GD3516-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-30 5:58 ` Li Zefan
2011-12-30 5:58 ` Li Zefan
[not found] ` <4EFD531C.50300-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-05 2:20 ` Li Zefan
2012-01-05 2:20 ` Li Zefan
2012-01-05 17:45 ` Tejun Heo
2012-01-05 17:45 ` Tejun Heo
[not found] ` <20120105174507.GC18486-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-01-06 2:24 ` Li Zefan
2012-01-06 2:24 ` Li Zefan
[not found] ` <4F065B6F.6060506-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-01-06 2:27 ` Tejun Heo
2012-01-06 2:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF964F3.8090705@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.