From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
Frank Mandarino <fmandarino@endrelia.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver model
Date: Fri, 6 Jan 2012 15:49:27 -0800 [thread overview]
Message-ID: <20120106234923.GI2893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120106234445.GC13857@n2100.arm.linux.org.uk>
On Fri, Jan 06, 2012 at 11:44:45PM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2012 at 03:41:39PM -0800, Mark Brown wrote:
> > This only helps this specific device model bit of things, if anything is
> > still actually holding a reference to the device and tries to use it
> > after we tore away the resource underneath it we'll still explode (never
> > mind the fact that we're backing this stuff up with some global pointers
> > to other devices which may or may not actually be there...).
> Err what? Explain showing the code where you think this is the case
> with the patch I proposed please.
These aren't new problems being introduced, they're preexisting problems
which aren't fixed by this (hence why I say it "only helps with this
specific device model side of things") but can come up in pretty much
the same circumstances.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Greg KH <greg@kroah.com>,
Frank Mandarino <fmandarino@endrelia.com>,
Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver model
Date: Fri, 6 Jan 2012 15:49:27 -0800 [thread overview]
Message-ID: <20120106234923.GI2893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120106234445.GC13857@n2100.arm.linux.org.uk>
On Fri, Jan 06, 2012 at 11:44:45PM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2012 at 03:41:39PM -0800, Mark Brown wrote:
> > This only helps this specific device model bit of things, if anything is
> > still actually holding a reference to the device and tries to use it
> > after we tore away the resource underneath it we'll still explode (never
> > mind the fact that we're backing this stuff up with some global pointers
> > to other devices which may or may not actually be there...).
> Err what? Explain showing the code where you think this is the case
> with the patch I proposed please.
These aren't new problems being introduced, they're preexisting problems
which aren't fixed by this (hence why I say it "only helps with this
specific device model side of things") but can come up in pretty much
the same circumstances.
next prev parent reply other threads:[~2012-01-06 23:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 19:40 Public ridicule due to sound/soc/soc-core.c abuse of the driver model Greg KH
2012-01-06 19:40 ` Greg KH
2012-01-06 20:15 ` Mark Brown
2012-01-06 20:15 ` Mark Brown
2012-01-06 20:50 ` Russell King - ARM Linux
2012-01-06 20:50 ` Russell King - ARM Linux
2012-01-06 21:10 ` Russell King - ARM Linux
2012-01-06 21:10 ` Russell King - ARM Linux
2012-01-06 23:41 ` Mark Brown
2012-01-06 23:41 ` Mark Brown
2012-01-06 23:44 ` Russell King - ARM Linux
2012-01-06 23:44 ` Russell King - ARM Linux
2012-01-06 23:49 ` Mark Brown [this message]
2012-01-06 23:49 ` Mark Brown
2012-01-09 9:51 ` Russell King - ARM Linux
2012-01-09 9:51 ` Russell King - ARM Linux
2012-01-09 19:52 ` Mark Brown
2012-01-09 19:52 ` Mark Brown
2012-01-09 20:11 ` Greg KH
2012-01-09 20:11 ` Greg KH
2012-01-09 20:31 ` Mark Brown
2012-01-09 20:31 ` Mark Brown
2012-01-09 21:37 ` Russell King - ARM Linux
2012-01-09 21:37 ` Russell King - ARM Linux
2012-01-09 22:16 ` Mark Brown
2012-01-09 22:16 ` Mark Brown
2012-01-09 23:02 ` Greg KH
2012-01-06 20:31 ` Mark Brown
2012-01-06 20:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106234923.GI2893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fmandarino@endrelia.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.