From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
Frank Mandarino <fmandarino@endrelia.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver model
Date: Mon, 9 Jan 2012 12:11:10 -0800 [thread overview]
Message-ID: <20120109201110.GA8377@kroah.com> (raw)
In-Reply-To: <20120109195211.GA30766@opensource.wolfsonmicro.com>
On Mon, Jan 09, 2012 at 07:52:13PM +0000, Mark Brown wrote:
> On Mon, Jan 09, 2012 at 09:51:25AM +0000, Russell King - ARM Linux wrote:
>
> > Anything which helps reduce the abuses of the driver model is a plus -
> > it helps remove the possibility of kernel oopses.
>
> Trying to make any sort of modification to code this fragile is risky,
> especially during what's supposed to be a stabalization phase (which is
> what Greg is requesting). It just seems completely irresponsible for
> something that isn't actually a practical problem.
I find it hard to believe that ignoring the driver model is not a
"practical" problem :)
For details as to why this is a problem, please see the kobject.txt
file.
Please fix this up, as you have seen, people end up cutting-and-pasting
bad code.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Frank Mandarino <fmandarino@endrelia.com>,
Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver model
Date: Mon, 9 Jan 2012 12:11:10 -0800 [thread overview]
Message-ID: <20120109201110.GA8377@kroah.com> (raw)
In-Reply-To: <20120109195211.GA30766@opensource.wolfsonmicro.com>
On Mon, Jan 09, 2012 at 07:52:13PM +0000, Mark Brown wrote:
> On Mon, Jan 09, 2012 at 09:51:25AM +0000, Russell King - ARM Linux wrote:
>
> > Anything which helps reduce the abuses of the driver model is a plus -
> > it helps remove the possibility of kernel oopses.
>
> Trying to make any sort of modification to code this fragile is risky,
> especially during what's supposed to be a stabalization phase (which is
> what Greg is requesting). It just seems completely irresponsible for
> something that isn't actually a practical problem.
I find it hard to believe that ignoring the driver model is not a
"practical" problem :)
For details as to why this is a problem, please see the kobject.txt
file.
Please fix this up, as you have seen, people end up cutting-and-pasting
bad code.
greg k-h
next prev parent reply other threads:[~2012-01-09 20:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 19:40 Public ridicule due to sound/soc/soc-core.c abuse of the driver model Greg KH
2012-01-06 19:40 ` Greg KH
2012-01-06 20:15 ` Mark Brown
2012-01-06 20:15 ` Mark Brown
2012-01-06 20:50 ` Russell King - ARM Linux
2012-01-06 20:50 ` Russell King - ARM Linux
2012-01-06 21:10 ` Russell King - ARM Linux
2012-01-06 21:10 ` Russell King - ARM Linux
2012-01-06 23:41 ` Mark Brown
2012-01-06 23:41 ` Mark Brown
2012-01-06 23:44 ` Russell King - ARM Linux
2012-01-06 23:44 ` Russell King - ARM Linux
2012-01-06 23:49 ` Mark Brown
2012-01-06 23:49 ` Mark Brown
2012-01-09 9:51 ` Russell King - ARM Linux
2012-01-09 9:51 ` Russell King - ARM Linux
2012-01-09 19:52 ` Mark Brown
2012-01-09 19:52 ` Mark Brown
2012-01-09 20:11 ` Greg KH [this message]
2012-01-09 20:11 ` Greg KH
2012-01-09 20:31 ` Mark Brown
2012-01-09 20:31 ` Mark Brown
2012-01-09 21:37 ` Russell King - ARM Linux
2012-01-09 21:37 ` Russell King - ARM Linux
2012-01-09 22:16 ` Mark Brown
2012-01-09 22:16 ` Mark Brown
2012-01-09 23:02 ` Greg KH
2012-01-06 20:31 ` Mark Brown
2012-01-06 20:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109201110.GA8377@kroah.com \
--to=greg@kroah.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fmandarino@endrelia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.