All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Zac Storer <zac.3.14159@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
Date: Thu, 12 Jan 2012 10:22:51 +0000	[thread overview]
Message-ID: <20120112102251.GA16184@ericsson.com> (raw)
In-Reply-To: <20120112090149.1acbff01@endymion.delvare>

On Thu, Jan 12, 2012 at 03:01:49AM -0500, Jean Delvare wrote:
> On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> > On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > > Fixed spacing coding style issues.
> > > 
> > > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > > ---
> > >  drivers/hwmon/adm1031.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > > index 0683e6b..694392b 100644
> > > --- a/drivers/hwmon/adm1031.c
> > > +++ b/drivers/hwmon/adm1031.c
> > > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > >  			data->alarm &= 0xc0ff;
> > >  		}
> > >  
> > > -		for (chan=0; chan<(data->chip_type = adm1030 ? 1 : 2); chan++) {
> > > +		for (chan = 0; chan < (data->chip_type = adm1030 ? 1 : 2); chan++) {
> > >  			data->fan_div[chan] > > >  			    adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > >  			data->fan_min[chan] > > 
> > Err, you apparently did not understand my request. Please send _one_
> > patch fixing all the adm1031 coding style issues at once.
> 
> Zac, do you have an updated patch for me?
> 
Just sent you one, with Zac's patches merged into one and (almost) all other checkpatch issues
fixed as well.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Zac Storer <zac.3.14159@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
Date: Thu, 12 Jan 2012 02:22:51 -0800	[thread overview]
Message-ID: <20120112102251.GA16184@ericsson.com> (raw)
In-Reply-To: <20120112090149.1acbff01@endymion.delvare>

On Thu, Jan 12, 2012 at 03:01:49AM -0500, Jean Delvare wrote:
> On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> > On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > > Fixed spacing coding style issues.
> > > 
> > > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > > ---
> > >  drivers/hwmon/adm1031.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > > index 0683e6b..694392b 100644
> > > --- a/drivers/hwmon/adm1031.c
> > > +++ b/drivers/hwmon/adm1031.c
> > > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > >  			data->alarm &= 0xc0ff;
> > >  		}
> > >  
> > > -		for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
> > > +		for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
> > >  			data->fan_div[chan] =
> > >  			    adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > >  			data->fan_min[chan] =
> > 
> > Err, you apparently did not understand my request. Please send _one_
> > patch fixing all the adm1031 coding style issues at once.
> 
> Zac, do you have an updated patch for me?
> 
Just sent you one, with Zac's patches merged into one and (almost) all other checkpatch issues
fixed as well.

Guenter

  reply	other threads:[~2012-01-12 10:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18  8:36 [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding Zac Storer
2011-11-18  8:36 ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Zac Storer
2011-11-18  9:35 ` [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing Jean Delvare
2011-11-18  9:35   ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Jean Delvare
2012-01-12  8:01   ` [lm-sensors] " Jean Delvare
2012-01-12  8:01     ` Jean Delvare
2012-01-12 10:22     ` Guenter Roeck [this message]
2012-01-12 10:22       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120112102251.GA16184@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=zac.3.14159@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.