* [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding
@ 2011-11-18 8:36 ` Zac Storer
0 siblings, 0 replies; 8+ messages in thread
From: Zac Storer @ 2011-11-18 8:36 UTC (permalink / raw)
To: khali; +Cc: lm-sensors, linux-kernel, Zac Storer
Fixed spacing coding style issues.
Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
---
drivers/hwmon/adm1031.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index 0683e6b..694392b 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
data->alarm &= 0xc0ff;
}
- for (chan=0; chan<(data->chip_type = adm1030 ? 1 : 2); chan++) {
+ for (chan = 0; chan < (data->chip_type = adm1030 ? 1 : 2); chan++) {
data->fan_div[chan] adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
data->fan_min[chan] --
1.7.7.3
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
@ 2011-11-18 8:36 ` Zac Storer
0 siblings, 0 replies; 8+ messages in thread
From: Zac Storer @ 2011-11-18 8:36 UTC (permalink / raw)
To: khali; +Cc: lm-sensors, linux-kernel, Zac Storer
Fixed spacing coding style issues.
Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
---
drivers/hwmon/adm1031.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
index 0683e6b..694392b 100644
--- a/drivers/hwmon/adm1031.c
+++ b/drivers/hwmon/adm1031.c
@@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
data->alarm &= 0xc0ff;
}
- for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
+ for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
data->fan_div[chan] =
adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
data->fan_min[chan] =
--
1.7.7.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing
2011-11-18 8:36 ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Zac Storer
@ 2011-11-18 9:35 ` Jean Delvare
-1 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2011-11-18 9:35 UTC (permalink / raw)
To: Zac Storer; +Cc: lm-sensors, linux-kernel
On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> Fixed spacing coding style issues.
>
> Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> ---
> drivers/hwmon/adm1031.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> index 0683e6b..694392b 100644
> --- a/drivers/hwmon/adm1031.c
> +++ b/drivers/hwmon/adm1031.c
> @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> data->alarm &= 0xc0ff;
> }
>
> - for (chan=0; chan<(data->chip_type = adm1030 ? 1 : 2); chan++) {
> + for (chan = 0; chan < (data->chip_type = adm1030 ? 1 : 2); chan++) {
> data->fan_div[chan] > adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> data->fan_min[chan]
Err, you apparently did not understand my request. Please send _one_
patch fixing all the adm1031 coding style issues at once.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
@ 2011-11-18 9:35 ` Jean Delvare
0 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2011-11-18 9:35 UTC (permalink / raw)
To: Zac Storer; +Cc: lm-sensors, linux-kernel
On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> Fixed spacing coding style issues.
>
> Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> ---
> drivers/hwmon/adm1031.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> index 0683e6b..694392b 100644
> --- a/drivers/hwmon/adm1031.c
> +++ b/drivers/hwmon/adm1031.c
> @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> data->alarm &= 0xc0ff;
> }
>
> - for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
> + for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
> data->fan_div[chan] =
> adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> data->fan_min[chan] =
Err, you apparently did not understand my request. Please send _one_
patch fixing all the adm1031 coding style issues at once.
--
Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
2011-11-18 9:35 ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Jean Delvare
@ 2012-01-12 8:01 ` Jean Delvare
-1 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2012-01-12 8:01 UTC (permalink / raw)
To: Zac Storer; +Cc: linux-kernel, lm-sensors
On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > Fixed spacing coding style issues.
> >
> > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > ---
> > drivers/hwmon/adm1031.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > index 0683e6b..694392b 100644
> > --- a/drivers/hwmon/adm1031.c
> > +++ b/drivers/hwmon/adm1031.c
> > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > data->alarm &= 0xc0ff;
> > }
> >
> > - for (chan=0; chan<(data->chip_type = adm1030 ? 1 : 2); chan++) {
> > + for (chan = 0; chan < (data->chip_type = adm1030 ? 1 : 2); chan++) {
> > data->fan_div[chan] > > adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > data->fan_min[chan] >
> Err, you apparently did not understand my request. Please send _one_
> patch fixing all the adm1031 coding style issues at once.
Zac, do you have an updated patch for me?
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
@ 2012-01-12 8:01 ` Jean Delvare
0 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2012-01-12 8:01 UTC (permalink / raw)
To: Zac Storer; +Cc: linux-kernel, lm-sensors
On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > Fixed spacing coding style issues.
> >
> > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > ---
> > drivers/hwmon/adm1031.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > index 0683e6b..694392b 100644
> > --- a/drivers/hwmon/adm1031.c
> > +++ b/drivers/hwmon/adm1031.c
> > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > data->alarm &= 0xc0ff;
> > }
> >
> > - for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
> > + for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
> > data->fan_div[chan] =
> > adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > data->fan_min[chan] =
>
> Err, you apparently did not understand my request. Please send _one_
> patch fixing all the adm1031 coding style issues at once.
Zac, do you have an updated patch for me?
--
Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
2012-01-12 8:01 ` Jean Delvare
@ 2012-01-12 10:22 ` Guenter Roeck
-1 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2012-01-12 10:22 UTC (permalink / raw)
To: Jean Delvare
Cc: Zac Storer, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
On Thu, Jan 12, 2012 at 03:01:49AM -0500, Jean Delvare wrote:
> On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> > On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > > Fixed spacing coding style issues.
> > >
> > > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > > ---
> > > drivers/hwmon/adm1031.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > > index 0683e6b..694392b 100644
> > > --- a/drivers/hwmon/adm1031.c
> > > +++ b/drivers/hwmon/adm1031.c
> > > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > > data->alarm &= 0xc0ff;
> > > }
> > >
> > > - for (chan=0; chan<(data->chip_type = adm1030 ? 1 : 2); chan++) {
> > > + for (chan = 0; chan < (data->chip_type = adm1030 ? 1 : 2); chan++) {
> > > data->fan_div[chan] > > > adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > > data->fan_min[chan] > >
> > Err, you apparently did not understand my request. Please send _one_
> > patch fixing all the adm1031 coding style issues at once.
>
> Zac, do you have an updated patch for me?
>
Just sent you one, with Zac's patches merged into one and (almost) all other checkpatch issues
fixed as well.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues
@ 2012-01-12 10:22 ` Guenter Roeck
0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2012-01-12 10:22 UTC (permalink / raw)
To: Jean Delvare
Cc: Zac Storer, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
On Thu, Jan 12, 2012 at 03:01:49AM -0500, Jean Delvare wrote:
> On Fri, 18 Nov 2011 10:35:01 +0100, Jean Delvare wrote:
> > On Fri, 18 Nov 2011 01:36:53 -0700, Zac Storer wrote:
> > > Fixed spacing coding style issues.
> > >
> > > Signed-off-by: Zac Storer <zac.3.14159@gmail.com>
> > > ---
> > > drivers/hwmon/adm1031.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/adm1031.c b/drivers/hwmon/adm1031.c
> > > index 0683e6b..694392b 100644
> > > --- a/drivers/hwmon/adm1031.c
> > > +++ b/drivers/hwmon/adm1031.c
> > > @@ -1058,7 +1058,7 @@ static struct adm1031_data *adm1031_update_device(struct device *dev)
> > > data->alarm &= 0xc0ff;
> > > }
> > >
> > > - for (chan=0; chan<(data->chip_type == adm1030 ? 1 : 2); chan++) {
> > > + for (chan = 0; chan < (data->chip_type == adm1030 ? 1 : 2); chan++) {
> > > data->fan_div[chan] =
> > > adm1031_read_value(client, ADM1031_REG_FAN_DIV(chan));
> > > data->fan_min[chan] =
> >
> > Err, you apparently did not understand my request. Please send _one_
> > patch fixing all the adm1031 coding style issues at once.
>
> Zac, do you have an updated patch for me?
>
Just sent you one, with Zac's patches merged into one and (almost) all other checkpatch issues
fixed as well.
Guenter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-01-12 10:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 8:36 [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing coding Zac Storer
2011-11-18 8:36 ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Zac Storer
2011-11-18 9:35 ` [lm-sensors] [PATCH] Drivers: hwmon: adm1031: fixed spacing Jean Delvare
2011-11-18 9:35 ` [PATCH] Drivers: hwmon: adm1031: fixed spacing coding style issues Jean Delvare
2012-01-12 8:01 ` [lm-sensors] " Jean Delvare
2012-01-12 8:01 ` Jean Delvare
2012-01-12 10:22 ` Guenter Roeck
2012-01-12 10:22 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.