From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"lrg-l0cyMroinI0@public.gmane.org"
<lrg-l0cyMroinI0@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails.
Date: Wed, 18 Jan 2012 17:56:14 +0000 [thread overview]
Message-ID: <20120118175613.GT8732@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1780DAAE10-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
On Wed, Jan 18, 2012 at 09:54:27AM -0800, Stephen Warren wrote:
> Laxman Dewangan wrote at Wednesday, January 18, 2012 8:17 AM:
> > + .table_len = 73,
> > },
> Forgive me if these comments are bogus since I'm not familiar with
> regulators much, but:
> a) Don't you want to use ARRAY_SIZE() instead of hard-coding table_len's
> value?
> b) Don't you need to set .table to actually point at the table too? If not,
> isn't tps65910_list_voltage() going to dereference a NULL pointer, since
> it will dereference .table if .table_len is set?
It's not actually a table at all any more as the driver calculates the
values, table_len is misnamed and should be renamed as well as set.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>, "lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails.
Date: Wed, 18 Jan 2012 17:56:14 +0000 [thread overview]
Message-ID: <20120118175613.GT8732@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1780DAAE10@HQMAIL01.nvidia.com>
On Wed, Jan 18, 2012 at 09:54:27AM -0800, Stephen Warren wrote:
> Laxman Dewangan wrote at Wednesday, January 18, 2012 8:17 AM:
> > + .table_len = 73,
> > },
> Forgive me if these comments are bogus since I'm not familiar with
> regulators much, but:
> a) Don't you want to use ARRAY_SIZE() instead of hard-coding table_len's
> value?
> b) Don't you need to set .table to actually point at the table too? If not,
> isn't tps65910_list_voltage() going to dereference a NULL pointer, since
> it will dereference .table if .table_len is set?
It's not actually a table at all any more as the driver calculates the
values, table_len is misnamed and should be renamed as well as set.
next prev parent reply other threads:[~2012-01-18 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:17 [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails Laxman Dewangan
2012-01-18 15:17 ` Laxman Dewangan
[not found] ` <1326899836-14470-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-18 17:54 ` Stephen Warren
2012-01-18 17:54 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF1780DAAE10-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-18 17:56 ` Mark Brown [this message]
2012-01-18 17:56 ` Mark Brown
[not found] ` <20120118175613.GT8732-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 3:24 ` Laxman Dewangan
2012-01-19 3:24 ` Laxman Dewangan
[not found] ` <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC1C3-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-19 10:40 ` Mark Brown
2012-01-19 10:40 ` Mark Brown
[not found] ` <20120119104029.GA3178-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 10:55 ` Laxman Dewangan
2012-01-19 10:55 ` Laxman Dewangan
[not found] ` <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC2B6-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-19 11:01 ` Mark Brown
2012-01-19 11:01 ` Mark Brown
[not found] ` <20120119110154.GD3178-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 12:23 ` Laxman Dewangan
2012-01-19 12:23 ` Laxman Dewangan
2012-01-20 12:11 ` Mark Brown
2012-01-20 12:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118175613.GT8732@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.