From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"lrg-l0cyMroinI0@public.gmane.org"
<lrg-l0cyMroinI0@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails.
Date: Thu, 19 Jan 2012 11:01:55 +0000 [thread overview]
Message-ID: <20120119110154.GD3178@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC2B6-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
On Thu, Jan 19, 2012 at 04:25:17PM +0530, Laxman Dewangan wrote:
> On Thursday 19 January 2012 04:10 PM, Mark Brown wrote:
> The table_len is already used in some of entry i.e. for tps65910. I filled
> entry for another device tps65911. So I would like to go for separate patch
> for renaming the variables "table" to "voltage_table" and "table_len" to
> "n_voltages".
> Please let me know your opinion.
That's fine. If in doubt and it doesn't introduce build breakage
splitting up into more patches is rarely a problem.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Stephen Warren <swarren@nvidia.com>, "lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails.
Date: Thu, 19 Jan 2012 11:01:55 +0000 [thread overview]
Message-ID: <20120119110154.GD3178@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC2B6@BGMAIL01.nvidia.com>
On Thu, Jan 19, 2012 at 04:25:17PM +0530, Laxman Dewangan wrote:
> On Thursday 19 January 2012 04:10 PM, Mark Brown wrote:
> The table_len is already used in some of entry i.e. for tps65910. I filled
> entry for another device tps65911. So I would like to go for separate patch
> for renaming the variables "table" to "voltage_table" and "table_len" to
> "n_voltages".
> Please let me know your opinion.
That's fine. If in doubt and it doesn't introduce build breakage
splitting up into more patches is rarely a problem.
next prev parent reply other threads:[~2012-01-19 11:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:17 [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails Laxman Dewangan
2012-01-18 15:17 ` Laxman Dewangan
[not found] ` <1326899836-14470-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-01-18 17:54 ` Stephen Warren
2012-01-18 17:54 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF1780DAAE10-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-18 17:56 ` Mark Brown
2012-01-18 17:56 ` Mark Brown
[not found] ` <20120118175613.GT8732-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 3:24 ` Laxman Dewangan
2012-01-19 3:24 ` Laxman Dewangan
[not found] ` <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC1C3-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-19 10:40 ` Mark Brown
2012-01-19 10:40 ` Mark Brown
[not found] ` <20120119104029.GA3178-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 10:55 ` Laxman Dewangan
2012-01-19 10:55 ` Laxman Dewangan
[not found] ` <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC2B6-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-19 11:01 ` Mark Brown [this message]
2012-01-19 11:01 ` Mark Brown
[not found] ` <20120119110154.GD3178-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-19 12:23 ` Laxman Dewangan
2012-01-19 12:23 ` Laxman Dewangan
2012-01-20 12:11 ` Mark Brown
2012-01-20 12:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119110154.GD3178@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-l0cyMroinI0@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.