From: Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>
To: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Sasha Levin
<levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
hannes <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
mhocko-AlSwsSmVLrQ@public.gmane.org,
bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074!
Date: Thu, 19 Jan 2012 16:49:19 +0000 [thread overview]
Message-ID: <20120119164919.GE3143@suse.de> (raw)
In-Reply-To: <alpine.LSU.2.00.1201182100010.2830-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote:
> >
> > Another question is who pushes pages to LRU before setting pc->mem_cgroup..
> > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware.
>
> I don't think so: Mel agreed that the patch could not go forward as is,
> without an additional pageflag, and asked Andrew to drop it from mmotm
> in mail on 29th December (I didn't notice an mm-commits message to say
> akpm did drop it, and marc is blacked out in protest for today, so I
> cannot check: but certainly akpm left it out of his push to Linus).
>
> Oh, and Mel noticed another bug in it on the 30th, that the PageLRU
> check in the function you quote above is wrong: see PATCH 11/11 thread.
>
Yes, that patch is broken. According to the mm-commits list, it was
"withdrawn" on December 30th. I do not know why it is still in
linux-next but AFAIK, it is not expected to end up in mainline. I do not
have a fixed version of the patch at the moment.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Hugh Dickins <hughd@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Sasha Levin <levinsasha928@gmail.com>,
hannes <hannes@cmpxchg.org>,
mhocko@suse.cz, bsingharora@gmail.com,
Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074!
Date: Thu, 19 Jan 2012 16:49:19 +0000 [thread overview]
Message-ID: <20120119164919.GE3143@suse.de> (raw)
In-Reply-To: <alpine.LSU.2.00.1201182100010.2830@eggly.anvils>
On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote:
> >
> > Another question is who pushes pages to LRU before setting pc->mem_cgroup..
> > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware.
>
> I don't think so: Mel agreed that the patch could not go forward as is,
> without an additional pageflag, and asked Andrew to drop it from mmotm
> in mail on 29th December (I didn't notice an mm-commits message to say
> akpm did drop it, and marc is blacked out in protest for today, so I
> cannot check: but certainly akpm left it out of his push to Linus).
>
> Oh, and Mel noticed another bug in it on the 30th, that the PageLRU
> check in the function you quote above is wrong: see PATCH 11/11 thread.
>
Yes, that patch is broken. According to the mm-commits list, it was
"withdrawn" on December 30th. I do not know why it is still in
linux-next but AFAIK, it is not expected to end up in mainline. I do not
have a fixed version of the patch at the moment.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Hugh Dickins <hughd@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Sasha Levin <levinsasha928@gmail.com>,
hannes <hannes@cmpxchg.org>,
mhocko@suse.cz, bsingharora@gmail.com,
Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [BUG] kernel BUG at mm/memcontrol.c:1074!
Date: Thu, 19 Jan 2012 16:49:19 +0000 [thread overview]
Message-ID: <20120119164919.GE3143@suse.de> (raw)
In-Reply-To: <alpine.LSU.2.00.1201182100010.2830@eggly.anvils>
On Wed, Jan 18, 2012 at 09:16:09PM -0800, Hugh Dickins wrote:
> >
> > Another question is who pushes pages to LRU before setting pc->mem_cgroup..
> > Anyway, I think we need to fix memcg to be LRU_IMMEDIATE aware.
>
> I don't think so: Mel agreed that the patch could not go forward as is,
> without an additional pageflag, and asked Andrew to drop it from mmotm
> in mail on 29th December (I didn't notice an mm-commits message to say
> akpm did drop it, and marc is blacked out in protest for today, so I
> cannot check: but certainly akpm left it out of his push to Linus).
>
> Oh, and Mel noticed another bug in it on the 30th, that the PageLRU
> check in the function you quote above is wrong: see PATCH 11/11 thread.
>
Yes, that patch is broken. According to the mm-commits list, it was
"withdrawn" on December 30th. I do not know why it is still in
linux-next but AFAIK, it is not expected to end up in mainline. I do not
have a fixed version of the patch at the moment.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2012-01-19 16:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 5:10 [BUG] kernel BUG at mm/memcontrol.c:1074! Sasha Levin
2012-01-19 5:10 ` Sasha Levin
2012-01-19 5:10 ` Sasha Levin
2012-01-19 3:23 ` KAMEZAWA Hiroyuki
2012-01-19 3:23 ` KAMEZAWA Hiroyuki
2012-01-19 3:23 ` KAMEZAWA Hiroyuki
2012-01-19 3:41 ` Hugh Dickins
2012-01-19 3:41 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1201181932040.2287-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-19 4:03 ` KAMEZAWA Hiroyuki
2012-01-19 4:03 ` KAMEZAWA Hiroyuki
2012-01-19 4:03 ` KAMEZAWA Hiroyuki
2012-01-19 5:16 ` Hugh Dickins
2012-01-19 5:16 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1201182100010.2830-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-19 5:29 ` KAMEZAWA Hiroyuki
2012-01-19 5:29 ` KAMEZAWA Hiroyuki
2012-01-19 5:29 ` KAMEZAWA Hiroyuki
[not found] ` <20120119142934.40f22386.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-01-19 6:59 ` KAMEZAWA Hiroyuki
2012-01-19 6:59 ` KAMEZAWA Hiroyuki
2012-01-19 6:59 ` KAMEZAWA Hiroyuki
2012-01-19 15:05 ` Sasha Levin
2012-01-19 15:05 ` Sasha Levin
2012-01-19 15:05 ` Sasha Levin
2012-01-19 16:49 ` Mel Gorman [this message]
2012-01-19 16:49 ` Mel Gorman
2012-01-19 16:49 ` Mel Gorman
2012-01-19 5:52 ` KAMEZAWA Hiroyuki
2012-01-19 5:52 ` KAMEZAWA Hiroyuki
2012-01-19 5:52 ` KAMEZAWA Hiroyuki
[not found] ` <20120119145250.acf3ccc8.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-01-19 6:44 ` KAMEZAWA Hiroyuki
2012-01-19 6:44 ` KAMEZAWA Hiroyuki
2012-01-19 6:44 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119164919.GE3143@suse.de \
--to=mgorman-l3a5bk7wagm@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=levinsasha928-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.