From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Manfred Spraul <manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org>,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Ying Han <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock()
Date: Thu, 19 Jan 2012 12:53:55 -0800 [thread overview]
Message-ID: <20120119205355.GJ5198@google.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1201191250210.29542-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote:
> Remove lock and unlock around css_get_next()'s call to idr_get_next().
> memcg iterators (only users of css_get_next) already did rcu_read_lock(),
> and its comment demands that; but add a WARN_ON_ONCE to make sure of it.
>
> Signed-off-by: Hugh Dickins <hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Acked-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
All three look good to me,
Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Manfred Spraul <manfred@colorfullife.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ying Han <yinghan@google.com>, Greg Thelen <gthelen@google.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock()
Date: Thu, 19 Jan 2012 12:53:55 -0800 [thread overview]
Message-ID: <20120119205355.GJ5198@google.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1201191250210.29542@eggly.anvils>
On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote:
> Remove lock and unlock around css_get_next()'s call to idr_get_next().
> memcg iterators (only users of css_get_next) already did rcu_read_lock(),
> and its comment demands that; but add a WARN_ON_ONCE to make sure of it.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
All three look good to me,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Hugh Dickins <hughd@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Manfred Spraul <manfred@colorfullife.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ying Han <yinghan@google.com>, Greg Thelen <gthelen@google.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock()
Date: Thu, 19 Jan 2012 12:53:55 -0800 [thread overview]
Message-ID: <20120119205355.GJ5198@google.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1201191250210.29542@eggly.anvils>
On Thu, Jan 19, 2012 at 12:51:47PM -0800, Hugh Dickins wrote:
> Remove lock and unlock around css_get_next()'s call to idr_get_next().
> memcg iterators (only users of css_get_next) already did rcu_read_lock(),
> and its comment demands that; but add a WARN_ON_ONCE to make sure of it.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
All three look good to me,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2012-01-19 20:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 6:05 [PATCH] memcg: restore ss->id_lock to spinlock, using RCU for next Hugh Dickins
2012-01-19 6:05 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1201182155480.7862-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-19 6:58 ` KAMEZAWA Hiroyuki
2012-01-19 6:58 ` KAMEZAWA Hiroyuki
2012-01-19 6:58 ` KAMEZAWA Hiroyuki
2012-01-19 7:33 ` Eric Dumazet
2012-01-19 7:33 ` Eric Dumazet
2012-01-19 7:33 ` Eric Dumazet
2012-01-19 12:28 ` Tejun Heo
2012-01-19 12:28 ` Tejun Heo
2012-01-19 12:28 ` Tejun Heo
2012-01-19 13:30 ` Eric Dumazet
2012-01-19 13:30 ` Eric Dumazet
2012-01-19 13:30 ` Eric Dumazet
2012-01-19 20:46 ` Hugh Dickins
2012-01-19 20:46 ` Hugh Dickins
2012-01-19 20:48 ` [PATCH 1/3] idr: make idr_get_next() good for rcu_read_lock() Hugh Dickins
2012-01-19 20:48 ` Hugh Dickins
2012-01-20 23:48 ` Andrew Morton
2012-01-20 23:48 ` Andrew Morton
2012-01-21 3:45 ` Hugh Dickins
2012-01-21 3:45 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1201201922110.1396-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-21 20:43 ` Randy Dunlap
2012-01-21 20:43 ` Randy Dunlap
2012-01-21 20:43 ` Randy Dunlap
[not found] ` <alpine.LSU.2.00.1201191235330.29542-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-19 20:50 ` [PATCH 2/3] cgroup: revert ss_id_lock to spinlock Hugh Dickins
2012-01-19 20:50 ` Hugh Dickins
2012-01-19 20:50 ` Hugh Dickins
2012-01-19 20:51 ` [PATCH 3/3] memcg: let css_get_next() rely upon rcu_read_lock() Hugh Dickins
2012-01-19 20:51 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1201191250210.29542-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2012-01-19 20:53 ` Tejun Heo [this message]
2012-01-19 20:53 ` Tejun Heo
2012-01-19 20:53 ` Tejun Heo
2012-01-19 7:31 ` [PATCH] memcg: restore ss->id_lock to spinlock, using RCU for next Li Zefan
2012-01-19 7:31 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119205355.GJ5198@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org \
--cc=yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.