* [PATCH 1/1] drm/i915: print out which pixel format we do not support
@ 2012-01-17 17:11 Eugeni Dodonov
2012-01-17 17:23 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Eugeni Dodonov @ 2012-01-17 17:11 UTC (permalink / raw)
To: intel-gfx; +Cc: Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel
format is not supported while leaving the details to the telepatic powers.
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ebe71ed..5d47d0d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,
case DRM_FORMAT_VYUY:
break;
default:
- DRM_ERROR("unsupported pixel format\n");
+ DRM_ERROR("unsupported pixel format %u\n",
+ mode_cmd->pixel_format);
return -EINVAL;
}
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drm/i915: print out which pixel format we do not support
2012-01-17 17:11 [PATCH 1/1] drm/i915: print out which pixel format we do not support Eugeni Dodonov
@ 2012-01-17 17:23 ` Daniel Vetter
2012-01-17 17:25 ` Eugeni Dodonov
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2012-01-17 17:23 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: intel-gfx
On Tue, Jan 17, 2012 at 03:11:11PM -0200, Eugeni Dodonov wrote:
> Otherwise, we are left with pretty bogus message saying that the pixel
> format is not supported while leaving the details to the telepatic powers.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ebe71ed..5d47d0d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,
> case DRM_FORMAT_VYUY:
> break;
> default:
> - DRM_ERROR("unsupported pixel format\n");
> + DRM_ERROR("unsupported pixel format %u\n",
> + mode_cmd->pixel_format);
While we're bashing Jesse, this looks like a user-triggerable error. Can
we have a DRM_DEBUG_KMS instead?
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/1] drm/i915: print out which pixel format we do not support
2012-01-17 17:23 ` Daniel Vetter
@ 2012-01-17 17:25 ` Eugeni Dodonov
2012-01-21 16:17 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Eugeni Dodonov @ 2012-01-17 17:25 UTC (permalink / raw)
To: intel-gfx; +Cc: Eugeni Dodonov
Otherwise, we are left with pretty bogus message saying that the pixel
format is not supported while leaving the details to the telepatic powers.
v2: use DRM_DEBUG_KMS instead of DRM_ERROR
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index ebe71ed..56b7f6f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7880,7 +7880,8 @@ int intel_framebuffer_init(struct drm_device *dev,
case DRM_FORMAT_VYUY:
break;
default:
- DRM_ERROR("unsupported pixel format\n");
+ DRM_DEBUG_KMS("unsupported pixel format %u\n",
+ mode_cmd->pixel_format);
return -EINVAL;
}
--
1.7.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] drm/i915: print out which pixel format we do not support
2012-01-17 17:25 ` Eugeni Dodonov
@ 2012-01-21 16:17 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2012-01-21 16:17 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: intel-gfx
On Tue, Jan 17, 2012 at 03:25:45PM -0200, Eugeni Dodonov wrote:
> Otherwise, we are left with pretty bogus message saying that the pixel
> format is not supported while leaving the details to the telepatic powers.
>
> v2: use DRM_DEBUG_KMS instead of DRM_ERROR
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-21 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 17:11 [PATCH 1/1] drm/i915: print out which pixel format we do not support Eugeni Dodonov
2012-01-17 17:23 ` Daniel Vetter
2012-01-17 17:25 ` Eugeni Dodonov
2012-01-21 16:17 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.