* [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
@ 2012-01-21 3:24 Kashyap Gada
2012-01-23 17:22 ` Dima Zavin
0 siblings, 1 reply; 6+ messages in thread
From: Kashyap Gada @ 2012-01-21 3:24 UTC (permalink / raw)
To: gregkh; +Cc: rebecca, rschultz, jgennis, dima, devel, linux-kernel,
Kashyap Gada
diff --git a/drivers/staging/android/pmem.c b/drivers/staging/android/pmem.c
index 65ba61a..c589c0c 100644
--- a/drivers/staging/android/pmem.c
+++ b/drivers/staging/android/pmem.c
@@ -831,7 +831,7 @@ static int pmem_connect(unsigned long connect, struct file *file)
src_file = fget_light(connect, &put_needed);
DLOG("connect %p to %p\n", file, src_file);
if (!src_file) {
- printk("pmem: src file not found!\n");
+ printk(KERN_ERR "pmem: src file not found!\n");
ret = -EINVAL;
goto err_no_file;
}
@@ -934,7 +934,7 @@ int pmem_remap(struct pmem_region *region, struct file *file,
if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
!PMEM_IS_PAGE_ALIGNED(region->len))) {
#if PMEM_DEBUG
- printk("pmem: request for unaligned pmem suballocation "
+ printk(KERN_DEBUG "pmem: request for unaligned pmem suballocation "
"%lx %lx\n", region->offset, region->len);
#endif
return -EINVAL;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
2012-01-21 3:24 [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c Kashyap Gada
@ 2012-01-23 17:22 ` Dima Zavin
2012-01-23 17:31 ` Greg KH
2012-01-26 12:09 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Dima Zavin @ 2012-01-23 17:22 UTC (permalink / raw)
To: Kashyap Gada; +Cc: gregkh, rebecca, rschultz, jgennis, devel, linux-kernel
We really should just get rid of pmem.c altogether. We will remove it
from our android common tree too. We don't actually use it anymore in
any of our products. There are some legacy users of it, like Qualcomm,
but I'm sure they have a bunch of patches on top of it and thus are
maintaining it separately anyway.
--Dima
On Fri, Jan 20, 2012 at 7:24 PM, Kashyap Gada <gada.kashyap@gmail.com> wrote:
> diff --git a/drivers/staging/android/pmem.c b/drivers/staging/android/pmem.c
> index 65ba61a..c589c0c 100644
> --- a/drivers/staging/android/pmem.c
> +++ b/drivers/staging/android/pmem.c
> @@ -831,7 +831,7 @@ static int pmem_connect(unsigned long connect, struct file *file)
> src_file = fget_light(connect, &put_needed);
> DLOG("connect %p to %p\n", file, src_file);
> if (!src_file) {
> - printk("pmem: src file not found!\n");
> + printk(KERN_ERR "pmem: src file not found!\n");
> ret = -EINVAL;
> goto err_no_file;
> }
> @@ -934,7 +934,7 @@ int pmem_remap(struct pmem_region *region, struct file *file,
> if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
> !PMEM_IS_PAGE_ALIGNED(region->len))) {
> #if PMEM_DEBUG
> - printk("pmem: request for unaligned pmem suballocation "
> + printk(KERN_DEBUG "pmem: request for unaligned pmem suballocation "
> "%lx %lx\n", region->offset, region->len);
> #endif
> return -EINVAL;
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
2012-01-23 17:22 ` Dima Zavin
@ 2012-01-23 17:31 ` Greg KH
2012-01-27 17:51 ` Shuah Khan
2012-01-26 12:09 ` Alan Cox
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-01-23 17:31 UTC (permalink / raw)
To: Dima Zavin; +Cc: Kashyap Gada, rebecca, rschultz, jgennis, devel, linux-kernel
On Mon, Jan 23, 2012 at 09:22:27AM -0800, Dima Zavin wrote:
> We really should just get rid of pmem.c altogether. We will remove it
> from our android common tree too. We don't actually use it anymore in
> any of our products. There are some legacy users of it, like Qualcomm,
> but I'm sure they have a bunch of patches on top of it and thus are
> maintaining it separately anyway.
Ok, I'll be glad to drop it if you all don't use it anymore and it's not
needed. That makes life a lot easier for me :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
2012-01-23 17:31 ` Greg KH
@ 2012-01-27 17:51 ` Shuah Khan
2012-01-27 18:00 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2012-01-27 17:51 UTC (permalink / raw)
To: Greg KH
Cc: Dima Zavin, Kashyap Gada, rebecca, rschultz, jgennis, devel,
linux-kernel
On Mon, 2012-01-23 at 09:31 -0800, Greg KH wrote:
> On Mon, Jan 23, 2012 at 09:22:27AM -0800, Dima Zavin wrote:
> > We really should just get rid of pmem.c altogether. We will remove it
> > from our android common tree too. We don't actually use it anymore in
> > any of our products. There are some legacy users of it, like Qualcomm,
> > but I'm sure they have a bunch of patches on top of it and thus are
> > maintaining it separately anyway.
>
> Ok, I'll be glad to drop it if you all don't use it anymore and it's not
> needed. That makes life a lot easier for me :)
>
> thanks,
>
> greg k-h
Done. I sent a patch to remove pmem driver yesterday.
https://lkml.org/lkml/2012/1/26/368
Thanks,
-- Shuah
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
2012-01-27 17:51 ` Shuah Khan
@ 2012-01-27 18:00 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2012-01-27 18:00 UTC (permalink / raw)
To: Shuah Khan
Cc: Dima Zavin, Kashyap Gada, rebecca, rschultz, jgennis, devel,
linux-kernel
On Fri, Jan 27, 2012 at 10:51:33AM -0700, Shuah Khan wrote:
> On Mon, 2012-01-23 at 09:31 -0800, Greg KH wrote:
> > On Mon, Jan 23, 2012 at 09:22:27AM -0800, Dima Zavin wrote:
> > > We really should just get rid of pmem.c altogether. We will remove it
> > > from our android common tree too. We don't actually use it anymore in
> > > any of our products. There are some legacy users of it, like Qualcomm,
> > > but I'm sure they have a bunch of patches on top of it and thus are
> > > maintaining it separately anyway.
> >
> > Ok, I'll be glad to drop it if you all don't use it anymore and it's not
> > needed. That makes life a lot easier for me :)
> >
> > thanks,
> >
> > greg k-h
>
> Done. I sent a patch to remove pmem driver yesterday.
>
> https://lkml.org/lkml/2012/1/26/368
And yet you failed to cc: me so that I can accept it :(
Please, the scripts/get_maintainer.pl tool is there for you to use, not
just admire from afar...
I'll go dig it out of lkml and queue it up,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c
2012-01-23 17:22 ` Dima Zavin
2012-01-23 17:31 ` Greg KH
@ 2012-01-26 12:09 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Alan Cox @ 2012-01-26 12:09 UTC (permalink / raw)
To: Dima Zavin
Cc: Kashyap Gada, gregkh, rebecca, rschultz, jgennis, devel,
linux-kernel
On Mon, 23 Jan 2012 09:22:27 -0800
Dima Zavin <dima@android.com> wrote:
> We really should just get rid of pmem.c altogether. We will remove it
> from our android common tree too. We don't actually use it anymore in
> any of our products. There are some legacy users of it, like Qualcomm,
> but I'm sure they have a bunch of patches on top of it and thus are
> maintaining it separately anyway.
Probably wise if nobody ever fixed the security holes in it.
Alan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-27 18:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-21 3:24 [PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c Kashyap Gada
2012-01-23 17:22 ` Dima Zavin
2012-01-23 17:31 ` Greg KH
2012-01-27 17:51 ` Shuah Khan
2012-01-27 18:00 ` Greg KH
2012-01-26 12:09 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.