From: mel@csn.ul.ie (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/15] mm: compaction: introduce isolate_freepages_range()
Date: Mon, 30 Jan 2012 11:55:48 +0000 [thread overview]
Message-ID: <20120130115548.GH25268@csn.ul.ie> (raw)
In-Reply-To: <20120130114820.GG25268@csn.ul.ie>
On Mon, Jan 30, 2012 at 11:48:20AM +0000, Mel Gorman wrote:
> > + if (!zone)
> > + zone = page_zone(pfn_to_page(pfn));
> > + else if (zone != page_zone(pfn_to_page(pfn)))
> > + break;
> > +
>
> So what you are checking for here is if you straddle zones.
> You could just initialise zone outside of the for loop. You can
> then check outside the loop if end_pfn is in a different zone to
> start_pfn. If it is, either adjust end_pfn accordingly or bail the
> entire operation avoiding the need for release_freepages() later. This
> will be a little cheaper.
>
Whoops, silly me! You are watching for overlapping zones which can
happen in some rare configurations and for that checking page_zone()
like this is necessary. You can still initialise zone outside the loop
but the page_zone() check is still necessary.
My bad.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH 04/15] mm: compaction: introduce isolate_freepages_range()
Date: Mon, 30 Jan 2012 11:55:48 +0000 [thread overview]
Message-ID: <20120130115548.GH25268@csn.ul.ie> (raw)
In-Reply-To: <20120130114820.GG25268@csn.ul.ie>
On Mon, Jan 30, 2012 at 11:48:20AM +0000, Mel Gorman wrote:
> > + if (!zone)
> > + zone = page_zone(pfn_to_page(pfn));
> > + else if (zone != page_zone(pfn_to_page(pfn)))
> > + break;
> > +
>
> So what you are checking for here is if you straddle zones.
> You could just initialise zone outside of the for loop. You can
> then check outside the loop if end_pfn is in a different zone to
> start_pfn. If it is, either adjust end_pfn accordingly or bail the
> entire operation avoiding the need for release_freepages() later. This
> will be a little cheaper.
>
Whoops, silly me! You are watching for overlapping zones which can
happen in some rare configurations and for that checking page_zone()
like this is necessary. You can still initialise zone outside the loop
but the page_zone() check is still necessary.
My bad.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH 04/15] mm: compaction: introduce isolate_freepages_range()
Date: Mon, 30 Jan 2012 11:55:48 +0000 [thread overview]
Message-ID: <20120130115548.GH25268@csn.ul.ie> (raw)
In-Reply-To: <20120130114820.GG25268@csn.ul.ie>
On Mon, Jan 30, 2012 at 11:48:20AM +0000, Mel Gorman wrote:
> > + if (!zone)
> > + zone = page_zone(pfn_to_page(pfn));
> > + else if (zone != page_zone(pfn_to_page(pfn)))
> > + break;
> > +
>
> So what you are checking for here is if you straddle zones.
> You could just initialise zone outside of the for loop. You can
> then check outside the loop if end_pfn is in a different zone to
> start_pfn. If it is, either adjust end_pfn accordingly or bail the
> entire operation avoiding the need for release_freepages() later. This
> will be a little cheaper.
>
Whoops, silly me! You are watching for overlapping zones which can
happen in some rare configurations and for that checking page_zone()
like this is necessary. You can still initialise zone outside the loop
but the page_zone() check is still necessary.
My bad.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-30 11:55 UTC|newest]
Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 9:00 [PATCHv19 00/15] Contiguous Memory Allocator Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 01/15] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 10:59 ` Mel Gorman
2012-01-30 10:59 ` Mel Gorman
2012-01-30 10:59 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 02/15] mm: page_alloc: update migrate type of pages on pcp when isolating Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:15 ` Mel Gorman
2012-01-30 11:15 ` Mel Gorman
2012-01-30 11:15 ` Mel Gorman
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 16:14 ` Mel Gorman
2012-01-30 16:14 ` Mel Gorman
2012-01-30 16:14 ` Mel Gorman
2012-01-31 16:23 ` Marek Szyprowski
2012-01-31 16:23 ` Marek Szyprowski
2012-01-31 16:23 ` Marek Szyprowski
2012-02-02 12:47 ` Mel Gorman
2012-02-02 12:47 ` Mel Gorman
2012-02-02 12:47 ` Mel Gorman
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 11:27 ` Mel Gorman
2012-02-03 11:27 ` Mel Gorman
2012-02-03 11:27 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:24 ` Mel Gorman
2012-01-30 11:24 ` Mel Gorman
2012-01-30 11:24 ` Mel Gorman
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 04/15] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:55 ` Mel Gorman [this message]
2012-01-30 11:55 ` Mel Gorman
2012-01-30 11:55 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 05/15] mm: compaction: export some of the functions Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:57 ` Mel Gorman
2012-01-30 11:57 ` Mel Gorman
2012-01-30 11:57 ` Mel Gorman
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-26 9:00 ` [PATCH 06/15] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:11 ` Mel Gorman
2012-01-30 12:11 ` Mel Gorman
2012-01-30 12:11 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 07/15] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:12 ` Mel Gorman
2012-01-30 12:12 ` Mel Gorman
2012-01-30 12:12 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:35 ` Mel Gorman
2012-01-30 12:35 ` Mel Gorman
2012-01-30 12:35 ` Mel Gorman
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 14:52 ` Mel Gorman
2012-01-30 14:52 ` Mel Gorman
2012-01-30 14:52 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 09/15] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 10/15] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:42 ` Mel Gorman
2012-01-30 12:42 ` Mel Gorman
2012-01-30 12:42 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 11/15] mm: trigger page reclaim in alloc_contig_range() to stabilize watermarks Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 13:05 ` Mel Gorman
2012-01-30 13:05 ` Mel Gorman
2012-01-30 13:05 ` Mel Gorman
2012-01-31 17:15 ` Marek Szyprowski
2012-01-31 17:15 ` Marek Szyprowski
2012-01-31 17:15 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 12/15] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-27 9:44 ` [Linaro-mm-sig] " Ohad Ben-Cohen
2012-01-27 9:44 ` Ohad Ben-Cohen
2012-01-27 9:44 ` Ohad Ben-Cohen
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 15:17 ` Marek Szyprowski
2012-01-27 15:17 ` Marek Szyprowski
2012-01-27 15:17 ` Marek Szyprowski
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-26 9:00 ` [PATCH 13/15] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 14/15] ARM: " Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 15/15] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 15:31 ` [PATCHv19 00/15] Contiguous Memory Allocator Arnd Bergmann
2012-01-26 15:31 ` Arnd Bergmann
2012-01-26 15:31 ` Arnd Bergmann
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:48 ` Marek Szyprowski
2012-01-26 15:48 ` Marek Szyprowski
2012-01-26 15:48 ` Marek Szyprowski
2012-01-28 0:26 ` Andrew Morton
2012-01-28 0:26 ` Andrew Morton
2012-01-28 0:26 ` Andrew Morton
2012-01-29 18:09 ` Rob Clark
2012-01-29 18:09 ` Rob Clark
2012-01-29 18:09 ` Rob Clark
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:51 ` Arnd Bergmann
2012-01-29 20:51 ` Arnd Bergmann
2012-01-29 20:51 ` Arnd Bergmann
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-31 17:17 ` Benjamin Gaignard
2012-02-01 8:47 ` Marek Szyprowski
2012-02-01 8:47 ` Marek Szyprowski
2012-02-01 8:47 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
-- strict thread matches above, loose matches on Subject: below --
2012-02-03 12:18 [PATCHv20 " Marek Szyprowski
2012-02-03 12:18 ` [PATCH 04/15] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-03 12:18 ` Marek Szyprowski
2012-02-03 12:18 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130115548.GH25268@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.