From: mel@csn.ul.ie (Mel Gorman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv19 00/15] Contiguous Memory Allocator
Date: Mon, 30 Jan 2012 13:25:12 +0000 [thread overview]
Message-ID: <20120130132512.GO25268@csn.ul.ie> (raw)
In-Reply-To: <20120127162624.40cba14e.akpm@linux-foundation.org>
On Fri, Jan 27, 2012 at 04:26:24PM -0800, Andrew Morton wrote:
> On Thu, 26 Jan 2012 15:31:40 +0000
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Thursday 26 January 2012, Marek Szyprowski wrote:
> > > Welcome everyone!
> > >
> > > Yes, that's true. This is yet another release of the Contiguous Memory
> > > Allocator patches. This version mainly includes code cleanups requested
> > > by Mel Gorman and a few minor bug fixes.
> >
> > Hi Marek,
> >
> > Thanks for keeping up this work! I really hope it works out for the
> > next merge window.
>
> Someone please tell me when it's time to start paying attention
> again ;)
>
> These patches don't seem to have as many acked-bys and reviewed-bys as
> I'd expect.
I reviewed the core MM changes and I've acked most of them so the
next release should have a few acks where you expect them. I did not
add a reviewed-by because I did not build and test the thing.
For me, Patch 2 is the only one that must be fixed prior to merging
as it can interfere with pages on a remote per-cpu list which is
dangerous. I know your suggestion will be to delete the per-cpu lists
and be done with it but I am a bit away from doing that just yet.
Patch 8 could do with a bit more care too but it is not a
potential hand grenade like patch 2 and could be fixed as part of
a follow-up. Even if you don't see an ack from me there, it should not
be treated as a show stopper.
I highlighted some issues on how CMA interacts with reclaim but I
think this is a problem specific to CMA and should not prevent it being
merged. I just wanted to be sure that the CMA people were aware of the
potential issues so they will recognise the class of bug if it occurs.
> Given the scope and duration of this, it would be useful
> to gather these up. But please ensure they are real ones - people
> sometimes like to ack things without showing much sign of having
> actually read them.
>
FWIW, the acks I put on the core MM changes are real acks :)
> The patches do seem to have been going round in ever-decreasing circles
> lately and I think we have decided to merge them (yes?) so we may as well
> get on and do that and sort out remaining issues in-tree.
>
I'm a lot happier with the core MM patches than I was when I reviewed
this first around last September or October.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCHv19 00/15] Contiguous Memory Allocator
Date: Mon, 30 Jan 2012 13:25:12 +0000 [thread overview]
Message-ID: <20120130132512.GO25268@csn.ul.ie> (raw)
In-Reply-To: <20120127162624.40cba14e.akpm@linux-foundation.org>
On Fri, Jan 27, 2012 at 04:26:24PM -0800, Andrew Morton wrote:
> On Thu, 26 Jan 2012 15:31:40 +0000
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Thursday 26 January 2012, Marek Szyprowski wrote:
> > > Welcome everyone!
> > >
> > > Yes, that's true. This is yet another release of the Contiguous Memory
> > > Allocator patches. This version mainly includes code cleanups requested
> > > by Mel Gorman and a few minor bug fixes.
> >
> > Hi Marek,
> >
> > Thanks for keeping up this work! I really hope it works out for the
> > next merge window.
>
> Someone please tell me when it's time to start paying attention
> again ;)
>
> These patches don't seem to have as many acked-bys and reviewed-bys as
> I'd expect.
I reviewed the core MM changes and I've acked most of them so the
next release should have a few acks where you expect them. I did not
add a reviewed-by because I did not build and test the thing.
For me, Patch 2 is the only one that must be fixed prior to merging
as it can interfere with pages on a remote per-cpu list which is
dangerous. I know your suggestion will be to delete the per-cpu lists
and be done with it but I am a bit away from doing that just yet.
Patch 8 could do with a bit more care too but it is not a
potential hand grenade like patch 2 and could be fixed as part of
a follow-up. Even if you don't see an ack from me there, it should not
be treated as a show stopper.
I highlighted some issues on how CMA interacts with reclaim but I
think this is a problem specific to CMA and should not prevent it being
merged. I just wanted to be sure that the CMA people were aware of the
potential issues so they will recognise the class of bug if it occurs.
> Given the scope and duration of this, it would be useful
> to gather these up. But please ensure they are real ones - people
> sometimes like to ack things without showing much sign of having
> actually read them.
>
FWIW, the acks I put on the core MM changes are real acks :)
> The patches do seem to have been going round in ever-decreasing circles
> lately and I think we have decided to merge them (yes?) so we may as well
> get on and do that and sort out remaining issues in-tree.
>
I'm a lot happier with the core MM patches than I was when I reviewed
this first around last September or October.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daniel Walker <dwalker@codeaurora.org>,
Jesse Barker <jesse.barker@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
Shariq Hasnain <shariq.hasnain@linaro.org>,
Chunsang Jeong <chunsang.jeong@linaro.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [PATCHv19 00/15] Contiguous Memory Allocator
Date: Mon, 30 Jan 2012 13:25:12 +0000 [thread overview]
Message-ID: <20120130132512.GO25268@csn.ul.ie> (raw)
In-Reply-To: <20120127162624.40cba14e.akpm@linux-foundation.org>
On Fri, Jan 27, 2012 at 04:26:24PM -0800, Andrew Morton wrote:
> On Thu, 26 Jan 2012 15:31:40 +0000
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > On Thursday 26 January 2012, Marek Szyprowski wrote:
> > > Welcome everyone!
> > >
> > > Yes, that's true. This is yet another release of the Contiguous Memory
> > > Allocator patches. This version mainly includes code cleanups requested
> > > by Mel Gorman and a few minor bug fixes.
> >
> > Hi Marek,
> >
> > Thanks for keeping up this work! I really hope it works out for the
> > next merge window.
>
> Someone please tell me when it's time to start paying attention
> again ;)
>
> These patches don't seem to have as many acked-bys and reviewed-bys as
> I'd expect.
I reviewed the core MM changes and I've acked most of them so the
next release should have a few acks where you expect them. I did not
add a reviewed-by because I did not build and test the thing.
For me, Patch 2 is the only one that must be fixed prior to merging
as it can interfere with pages on a remote per-cpu list which is
dangerous. I know your suggestion will be to delete the per-cpu lists
and be done with it but I am a bit away from doing that just yet.
Patch 8 could do with a bit more care too but it is not a
potential hand grenade like patch 2 and could be fixed as part of
a follow-up. Even if you don't see an ack from me there, it should not
be treated as a show stopper.
I highlighted some issues on how CMA interacts with reclaim but I
think this is a problem specific to CMA and should not prevent it being
merged. I just wanted to be sure that the CMA people were aware of the
potential issues so they will recognise the class of bug if it occurs.
> Given the scope and duration of this, it would be useful
> to gather these up. But please ensure they are real ones - people
> sometimes like to ack things without showing much sign of having
> actually read them.
>
FWIW, the acks I put on the core MM changes are real acks :)
> The patches do seem to have been going round in ever-decreasing circles
> lately and I think we have decided to merge them (yes?) so we may as well
> get on and do that and sort out remaining issues in-tree.
>
I'm a lot happier with the core MM patches than I was when I reviewed
this first around last September or October.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-30 13:25 UTC|newest]
Thread overview: 184+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 9:00 [PATCHv19 00/15] Contiguous Memory Allocator Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 01/15] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 10:59 ` Mel Gorman
2012-01-30 10:59 ` Mel Gorman
2012-01-30 10:59 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 02/15] mm: page_alloc: update migrate type of pages on pcp when isolating Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:15 ` Mel Gorman
2012-01-30 11:15 ` Mel Gorman
2012-01-30 11:15 ` Mel Gorman
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 15:41 ` Michal Nazarewicz
2012-01-30 16:14 ` Mel Gorman
2012-01-30 16:14 ` Mel Gorman
2012-01-30 16:14 ` Mel Gorman
2012-01-31 16:23 ` Marek Szyprowski
2012-01-31 16:23 ` Marek Szyprowski
2012-01-31 16:23 ` Marek Szyprowski
2012-02-02 12:47 ` Mel Gorman
2012-02-02 12:47 ` Mel Gorman
2012-02-02 12:47 ` Mel Gorman
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-02 19:53 ` Michal Nazarewicz
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 9:31 ` Marek Szyprowski
2012-02-03 11:27 ` Mel Gorman
2012-02-03 11:27 ` Mel Gorman
2012-02-03 11:27 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:24 ` Mel Gorman
2012-01-30 11:24 ` Mel Gorman
2012-01-30 11:24 ` Mel Gorman
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 12:42 ` Michal Nazarewicz
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 04/15] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:48 ` Mel Gorman
2012-01-30 11:55 ` Mel Gorman
2012-01-30 11:55 ` Mel Gorman
2012-01-30 11:55 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 05/15] mm: compaction: export some of the functions Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 11:57 ` Mel Gorman
2012-01-30 11:57 ` Mel Gorman
2012-01-30 11:57 ` Mel Gorman
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-30 12:33 ` Michal Nazarewicz
2012-01-26 9:00 ` [PATCH 06/15] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:11 ` Mel Gorman
2012-01-30 12:11 ` Mel Gorman
2012-01-30 12:11 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 07/15] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:12 ` Mel Gorman
2012-01-30 12:12 ` Mel Gorman
2012-01-30 12:12 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:35 ` Mel Gorman
2012-01-30 12:35 ` Mel Gorman
2012-01-30 12:35 ` Mel Gorman
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 13:06 ` Michal Nazarewicz
2012-01-30 14:52 ` Mel Gorman
2012-01-30 14:52 ` Mel Gorman
2012-01-30 14:52 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 09/15] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 10/15] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 12:42 ` Mel Gorman
2012-01-30 12:42 ` Mel Gorman
2012-01-30 12:42 ` Mel Gorman
2012-01-26 9:00 ` [PATCH 11/15] mm: trigger page reclaim in alloc_contig_range() to stabilize watermarks Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-30 13:05 ` Mel Gorman
2012-01-30 13:05 ` Mel Gorman
2012-01-30 13:05 ` Mel Gorman
2012-01-31 17:15 ` Marek Szyprowski
2012-01-31 17:15 ` Marek Szyprowski
2012-01-31 17:15 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 12/15] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-27 9:44 ` [Linaro-mm-sig] " Ohad Ben-Cohen
2012-01-27 9:44 ` Ohad Ben-Cohen
2012-01-27 9:44 ` Ohad Ben-Cohen
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 10:53 ` Marek Szyprowski
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:27 ` Clark, Rob
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:51 ` Marek Szyprowski
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 14:59 ` Ohad Ben-Cohen
2012-01-27 15:17 ` Marek Szyprowski
2012-01-27 15:17 ` Marek Szyprowski
2012-01-27 15:17 ` Marek Szyprowski
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-28 18:57 ` Ohad Ben-Cohen
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 7:43 ` Marek Szyprowski
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-30 9:16 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-27 14:56 ` Ohad Ben-Cohen
2012-01-26 9:00 ` [PATCH 13/15] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 14/15] ARM: " Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` [PATCH 15/15] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 9:00 ` Marek Szyprowski
2012-01-26 15:31 ` [PATCHv19 00/15] Contiguous Memory Allocator Arnd Bergmann
2012-01-26 15:31 ` Arnd Bergmann
2012-01-26 15:31 ` Arnd Bergmann
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:38 ` Michal Nazarewicz
2012-01-26 15:48 ` Marek Szyprowski
2012-01-26 15:48 ` Marek Szyprowski
2012-01-26 15:48 ` Marek Szyprowski
2012-01-28 0:26 ` Andrew Morton
2012-01-28 0:26 ` Andrew Morton
2012-01-28 0:26 ` Andrew Morton
2012-01-29 18:09 ` Rob Clark
2012-01-29 18:09 ` Rob Clark
2012-01-29 18:09 ` Rob Clark
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:32 ` Anca Emanuel
2012-01-29 20:51 ` Arnd Bergmann
2012-01-29 20:51 ` Arnd Bergmann
2012-01-29 20:51 ` Arnd Bergmann
2012-01-30 13:25 ` Mel Gorman [this message]
2012-01-30 13:25 ` Mel Gorman
2012-01-30 13:25 ` Mel Gorman
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-30 15:43 ` Michal Nazarewicz
2012-01-31 17:17 ` Benjamin Gaignard
2012-02-01 8:47 ` Marek Szyprowski
2012-02-01 8:47 ` Marek Szyprowski
2012-02-01 8:47 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
2012-02-10 18:10 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130132512.GO25268@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.