From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
container cgroup <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks
Date: Thu, 2 Feb 2012 09:26:11 -0800 [thread overview]
Message-ID: <20120202172611.GF19837@google.com> (raw)
In-Reply-To: <4F278078.5030703@cn.fujitsu.com>
On Tue, Jan 31, 2012 at 01:47:36PM +0800, Li Zefan wrote:
> The argument is not used at all, and it's not necessary, because
> a specific callback handler of course knows which subsys it
> belongs to.
>
> Now only ->pupulate() takes this argument, because the handlers of
> this callback always call cgroup_add_file()/cgroup_add_files().
>
> So we reduce a few lines of code, though the shrinking of object size
> is minimal.
>
> 16 files changed, 113 insertions(+), 162 deletions(-)
>
> text data bss dec hex filename
> 5486240 656987 7039960 13183187 c928d3 vmlinux.o.orig
> 5486170 656987 7039960 13183117 c9288d vmlinux.o
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Nice cleanup, applied to cgroup/for-3.4. Thank you!
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
container cgroup <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] cgroup: remove cgroup_subsys argument from callbacks
Date: Thu, 2 Feb 2012 09:26:11 -0800 [thread overview]
Message-ID: <20120202172611.GF19837@google.com> (raw)
In-Reply-To: <4F278078.5030703@cn.fujitsu.com>
On Tue, Jan 31, 2012 at 01:47:36PM +0800, Li Zefan wrote:
> The argument is not used at all, and it's not necessary, because
> a specific callback handler of course knows which subsys it
> belongs to.
>
> Now only ->pupulate() takes this argument, because the handlers of
> this callback always call cgroup_add_file()/cgroup_add_files().
>
> So we reduce a few lines of code, though the shrinking of object size
> is minimal.
>
> 16 files changed, 113 insertions(+), 162 deletions(-)
>
> text data bss dec hex filename
> 5486240 656987 7039960 13183187 c928d3 vmlinux.o.orig
> 5486170 656987 7039960 13183117 c9288d vmlinux.o
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Nice cleanup, applied to cgroup/for-3.4. Thank you!
--
tejun
next prev parent reply other threads:[~2012-02-02 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 5:47 [PATCH] cgroup: remove cgroup_subsys argument from callbacks Li Zefan
2012-01-31 5:47 ` Li Zefan
[not found] ` <4F278078.5030703-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-02-02 17:26 ` Tejun Heo
2012-02-02 17:26 ` Tejun Heo [this message]
2012-02-02 17:26 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-01-31 5:47 Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202172611.GF19837@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.