From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>, Dmitry Torokhov <dtor@mail.ru>,
linux-kernel@vger.kernel.org,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies
Date: Tue, 7 Feb 2012 13:16:57 +0000 [thread overview]
Message-ID: <20120207131657.GL3332@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328619678-26080-8-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]
On Tue, Feb 07, 2012 at 03:01:18PM +0200, Peter Ujfalusi wrote:
> twl6040 has three power supply source:
> VBAT needs to be connected to VBAT, VIO, and V2V1.
> Add regulator support for the VIO, V2V1 supplies.
> Initially handle the two supply together with bulk commands.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + twl6040->supplies = devm_kzalloc(&client->dev,
> + sizeof(struct regulator_bulk_data) *
> + TWL6040_NUM_SUPPLIES, GFP_KERNEL);
> + if (!twl6040->supplies) {
> + ret = -ENOMEM;
> + goto err;
> + }
> +
though I'd be inclined to just embed this structure into the twl6040
struct directly, you're always going to need to allocate it and it saves
a tiny bit of error handling and whatnot.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies
Date: Tue, 7 Feb 2012 13:16:57 +0000 [thread overview]
Message-ID: <20120207131657.GL3332@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328619678-26080-8-git-send-email-peter.ujfalusi@ti.com>
On Tue, Feb 07, 2012 at 03:01:18PM +0200, Peter Ujfalusi wrote:
> twl6040 has three power supply source:
> VBAT needs to be connected to VBAT, VIO, and V2V1.
> Add regulator support for the VIO, V2V1 supplies.
> Initially handle the two supply together with bulk commands.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + twl6040->supplies = devm_kzalloc(&client->dev,
> + sizeof(struct regulator_bulk_data) *
> + TWL6040_NUM_SUPPLIES, GFP_KERNEL);
> + if (!twl6040->supplies) {
> + ret = -ENOMEM;
> + goto err;
> + }
> +
though I'd be inclined to just embed this structure into the twl6040
struct directly, you're always going to need to allocate it and it saves
a tiny bit of error handling and whatnot.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120207/1e62da28/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Liam Girdwood <lrg@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
Misael Lopez Cruz <misael.lopez@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies
Date: Tue, 7 Feb 2012 13:16:57 +0000 [thread overview]
Message-ID: <20120207131657.GL3332@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328619678-26080-8-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On Tue, Feb 07, 2012 at 03:01:18PM +0200, Peter Ujfalusi wrote:
> twl6040 has three power supply source:
> VBAT needs to be connected to VBAT, VIO, and V2V1.
> Add regulator support for the VIO, V2V1 supplies.
> Initially handle the two supply together with bulk commands.
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> + twl6040->supplies = devm_kzalloc(&client->dev,
> + sizeof(struct regulator_bulk_data) *
> + TWL6040_NUM_SUPPLIES, GFP_KERNEL);
> + if (!twl6040->supplies) {
> + ret = -ENOMEM;
> + goto err;
> + }
> +
though I'd be inclined to just embed this structure into the twl6040
struct directly, you're always going to need to allocate it and it saves
a tiny bit of error handling and whatnot.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-07 13:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 13:01 [PATCH v2 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 1/7] MFD: twl-core: Detach twl6040 from the pmic mfd driver Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:29 ` Mark Brown
2012-02-07 13:29 ` Mark Brown
2012-02-07 13:29 ` Mark Brown
2012-02-07 13:39 ` Peter Ujfalusi
2012-02-07 13:39 ` Peter Ujfalusi
2012-02-07 13:43 ` Mark Brown
2012-02-07 13:43 ` Mark Brown
2012-02-07 13:43 ` Mark Brown
2012-02-07 13:52 ` Peter Ujfalusi
2012-02-07 13:52 ` Peter Ujfalusi
2012-02-07 13:52 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 3/7] ASoC: twl6040: Remove dependency on twl4030 from Kconfig Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:37 ` Mark Brown
2012-02-07 13:37 ` Mark Brown
2012-02-07 13:01 ` [PATCH v2 4/7] OMAP: 4430sdp: Correct fixed regulator device ID Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 5/7] OMAP: sdp4430: Add fixed regulator for twl6040 needs Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 6/7] OMAP: omap4panda: " Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:16 ` Mark Brown [this message]
2012-02-07 13:16 ` Mark Brown
2012-02-07 13:16 ` Mark Brown
2012-02-07 13:30 ` Peter Ujfalusi
2012-02-07 13:30 ` Peter Ujfalusi
2012-02-20 19:55 ` Samuel Ortiz
2012-02-20 19:55 ` Samuel Ortiz
2012-02-09 7:47 ` [PATCH v2 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-09 7:47 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207131657.GL3332@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dtor@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.