All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Tony Lindgren <tony@atomide.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Liam Girdwood <lrg@ti.com>, Dmitry Torokhov <dtor@mail.ru>,
	Misael Lopez Cruz <misael.lopez@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core
Date: Tue, 07 Feb 2012 15:39:24 +0200	[thread overview]
Message-ID: <4F31298C.5090008@ti.com> (raw)
In-Reply-To: <20120207132925.GN3332@opensource.wolfsonmicro.com>

On 02/07/2012 03:29 PM, Mark Brown wrote:
> and it looks like you'll save a bunch more code if you're able to
> convert over to using a regmap cache.  Note that as a first pass you
> just need to define which registers are volatile and enable a cache type
> - if defaults are omitted then the values will be read back from the
> device to start off with.

There's one thing which I need to sort out before I enable the regmap
cache for the twl6040 MFD (and remove all other caching of vibra
controls in the MFD, and from the ASoC codec driver):
In the codec driver I have one 'shadow' register which does not exist on
the HW. I'm going to need to have access to that shadow register's bits
in the future transparently.
I was wondering if we could add support to regmap for such SW only
registers. This would only make sens if the cache is enabled. We could
have a callback let's say shadow_reg() in remap_config struct. If it is
a shadow reg we never reach out for the HW and operate only on the cache.
Is this something we can add to regmap?

-- 
Péter

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core
Date: Tue, 07 Feb 2012 15:39:24 +0200	[thread overview]
Message-ID: <4F31298C.5090008@ti.com> (raw)
In-Reply-To: <20120207132925.GN3332@opensource.wolfsonmicro.com>

On 02/07/2012 03:29 PM, Mark Brown wrote:
> and it looks like you'll save a bunch more code if you're able to
> convert over to using a regmap cache.  Note that as a first pass you
> just need to define which registers are volatile and enable a cache type
> - if defaults are omitted then the values will be read back from the
> device to start off with.

There's one thing which I need to sort out before I enable the regmap
cache for the twl6040 MFD (and remove all other caching of vibra
controls in the MFD, and from the ASoC codec driver):
In the codec driver I have one 'shadow' register which does not exist on
the HW. I'm going to need to have access to that shadow register's bits
in the future transparently.
I was wondering if we could add support to regmap for such SW only
registers. This would only make sens if the cache is enabled. We could
have a callback let's say shadow_reg() in remap_config struct. If it is
a shadow reg we never reach out for the HW and operate only on the cache.
Is this something we can add to regmap?

-- 
P?ter

  reply	other threads:[~2012-02-07 13:39 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 13:01 [PATCH v2 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-07 13:01 ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 1/7] MFD: twl-core: Detach twl6040 from the pmic mfd driver Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:29   ` Mark Brown
2012-02-07 13:29     ` Mark Brown
2012-02-07 13:29     ` Mark Brown
2012-02-07 13:39     ` Peter Ujfalusi [this message]
2012-02-07 13:39       ` Peter Ujfalusi
2012-02-07 13:43       ` Mark Brown
2012-02-07 13:43         ` Mark Brown
2012-02-07 13:43         ` Mark Brown
2012-02-07 13:52         ` Peter Ujfalusi
2012-02-07 13:52           ` Peter Ujfalusi
2012-02-07 13:52           ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 3/7] ASoC: twl6040: Remove dependency on twl4030 from Kconfig Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:37   ` Mark Brown
2012-02-07 13:37     ` Mark Brown
2012-02-07 13:01 ` [PATCH v2 4/7] OMAP: 4430sdp: Correct fixed regulator device ID Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 5/7] OMAP: sdp4430: Add fixed regulator for twl6040 needs Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 6/7] OMAP: omap4panda: " Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:01 ` [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies Peter Ujfalusi
2012-02-07 13:01   ` Peter Ujfalusi
2012-02-07 13:16   ` Mark Brown
2012-02-07 13:16     ` Mark Brown
2012-02-07 13:16     ` Mark Brown
2012-02-07 13:30     ` Peter Ujfalusi
2012-02-07 13:30       ` Peter Ujfalusi
2012-02-20 19:55   ` Samuel Ortiz
2012-02-20 19:55     ` Samuel Ortiz
2012-02-09  7:47 ` [PATCH v2 0/7] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-09  7:47   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F31298C.5090008@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dtor@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.