Re: [PATCH 2/3] USB: SET SEL request definition

Re: [PATCH 2/3] USB: SET SEL request definition

[Anton Tikhomirov]

Hi,

Greg KH wrote:
> On Mon, Feb 06, 2012 at 05:12:33PM +0900, Anton Tikhomirov wrote:
> > Cc: Kukjin Kim <kgene.kim <at> samsung.com>
> > Cc: Greg Kroah-Hartman <gregkh <at> suse.de>
> > Cc: Felipe Balbi <balbi <at> ti.com>
> 
> What is that mess?  It belongs, with real email addresses, below your
> signed-off-by line, if at all.
> 
> > Adds SET SEL standard request definition as defined by ch9
> > of the USB3.0 specification.
> >
> > Signed-off-by: Anton Tikhomirov <av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  include/linux/usb/ch9.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
> > index 61b2905..76ff771 100644
> > --- a/include/linux/usb/ch9.h
> > +++ b/include/linux/usb/ch9.h
> > @@ -88,6 +88,7 @@
> >  #define USB_REQ_GET_INTERFACE		0x0A
> >  #define USB_REQ_SET_INTERFACE		0x0B
> >  #define USB_REQ_SYNCH_FRAME		0x0C
> > +#define USB_REQ_SET_SEL			0x30
> >
> >  #define USB_REQ_SET_ENCRYPTION		0x0D	/* Wireless USB */
> >  #define USB_REQ_GET_ENCRYPTION		0x0E
> 
> Why did you insert this out of order?
> 
> greg "please note my email address change as well" k-h

'Set SEL' is a standard device request according to USB3.0 spec. Wireless USB requests are not mentioned
in USB3.0 spec (and moreover are not in ch9 of it). So I put the definition to an appropriate group in my opinion.
If you insist I will move the definition below Wireless USB group with a space between.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] USB: SET SEL request definition

['Greg Kroah-Hartman']

On Tue, Feb 07, 2012 at 03:50:42PM +0900, Anton Tikhomirov wrote:
> Hi,
> 
> Greg KH wrote:
> > On Mon, Feb 06, 2012 at 05:12:33PM +0900, Anton Tikhomirov wrote:
> > > Cc: Kukjin Kim <kgene.kim <at> samsung.com>
> > > Cc: Greg Kroah-Hartman <gregkh <at> suse.de>
> > > Cc: Felipe Balbi <balbi <at> ti.com>
> > 
> > What is that mess?  It belongs, with real email addresses, below your
> > signed-off-by line, if at all.
> > 
> > > Adds SET SEL standard request definition as defined by ch9
> > > of the USB3.0 specification.
> > >
> > > Signed-off-by: Anton Tikhomirov <av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > > ---
> > >  include/linux/usb/ch9.h |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
> > > index 61b2905..76ff771 100644
> > > --- a/include/linux/usb/ch9.h
> > > +++ b/include/linux/usb/ch9.h
> > > @@ -88,6 +88,7 @@
> > >  #define USB_REQ_GET_INTERFACE		0x0A
> > >  #define USB_REQ_SET_INTERFACE		0x0B
> > >  #define USB_REQ_SYNCH_FRAME		0x0C
> > > +#define USB_REQ_SET_SEL			0x30
> > >
> > >  #define USB_REQ_SET_ENCRYPTION		0x0D	/* Wireless USB */
> > >  #define USB_REQ_GET_ENCRYPTION		0x0E
> > 
> > Why did you insert this out of order?
> > 
> > greg "please note my email address change as well" k-h
> 
> 'Set SEL' is a standard device request according to USB3.0 spec.
> Wireless USB requests are not mentioned in USB3.0 spec (and moreover
> are not in ch9 of it).

Their requests are part of the wireless USB spec, a different document.

> So I put the definition to an appropriate group in my opinion.  If you
> insist I will move the definition below Wireless USB group with a
> space between.

Putting them in order would make more sense, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] USB: SET SEL request definition

[Anton Tikhomirov]

Cc: Kukjin Kim <kgene.kim <at> samsung.com>
Cc: Greg Kroah-Hartman <gregkh <at> suse.de>
Cc: Felipe Balbi <balbi <at> ti.com>

Adds SET SEL standard request definition as defined by ch9
of the USB3.0 specification.

Signed-off-by: Anton Tikhomirov <av.tikhomirov@samsung.com>
---
 include/linux/usb/ch9.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
index 61b2905..76ff771 100644
--- a/include/linux/usb/ch9.h
+++ b/include/linux/usb/ch9.h
@@ -88,6 +88,7 @@
 #define USB_REQ_GET_INTERFACE		0x0A
 #define USB_REQ_SET_INTERFACE		0x0B
 #define USB_REQ_SYNCH_FRAME		0x0C
+#define USB_REQ_SET_SEL			0x30
 
 #define USB_REQ_SET_ENCRYPTION		0x0D	/* Wireless USB */
 #define USB_REQ_GET_ENCRYPTION		0x0E
-- 
1.7.1

Re: [PATCH 2/3] USB: SET SEL request definition

[Greg KH]

On Mon, Feb 06, 2012 at 05:12:33PM +0900, Anton Tikhomirov wrote:
> Cc: Kukjin Kim <kgene.kim <at> samsung.com>
> Cc: Greg Kroah-Hartman <gregkh <at> suse.de>
> Cc: Felipe Balbi <balbi <at> ti.com>

What is that mess?  It belongs, with real email addresses, below your
signed-off-by line, if at all.

> Adds SET SEL standard request definition as defined by ch9
> of the USB3.0 specification.
> 
> Signed-off-by: Anton Tikhomirov <av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  include/linux/usb/ch9.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h
> index 61b2905..76ff771 100644
> --- a/include/linux/usb/ch9.h
> +++ b/include/linux/usb/ch9.h
> @@ -88,6 +88,7 @@
>  #define USB_REQ_GET_INTERFACE		0x0A
>  #define USB_REQ_SET_INTERFACE		0x0B
>  #define USB_REQ_SYNCH_FRAME		0x0C
> +#define USB_REQ_SET_SEL			0x30
>  
>  #define USB_REQ_SET_ENCRYPTION		0x0D	/* Wireless USB */
>  #define USB_REQ_GET_ENCRYPTION		0x0E

Why did you insert this out of order?

greg "please note my email address change as well" k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html