From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org,
Isaku Yamahata <yamahata@valinux.co.jp>,
Kevin O'Connor <kevin@koconnor.net>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH RFC] seabios: add OSHP method stub
Date: Tue, 14 Feb 2012 15:37:28 +0200 [thread overview]
Message-ID: <20120214133727.GA23647@redhat.com> (raw)
In-Reply-To: <201202141249.09301.paul@codesourcery.com>
On Tue, Feb 14, 2012 at 12:49:08PM +0000, Paul Brook wrote:
> > > In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking
> > > for an additional Ack.
> >
> > No problem, I'll get an Ack :)
> > Meanwhile - here's a summary, as far as I understand it.
> >
> > Originally PCI SIG only defined the electrical
> > and mechanical requirements from hotplug, no standard
> > software interface. So it needed ACPI to drive device-specific registers
> > to actually do hotplug.
> > At some point PCISIG defined standard interfaces
> > for PCI hotplug. There are two of them: standard
> > hot plug controller (SHPC) for PCI and PCIE hotplug
> > for Express.
> >
> > Now an OS can have a standard driver and use it
> > to activate hotplug functionality. This is OS hotplug (OSHP).
>
> So presumably this will work on targets that don't have ACPI?
> Assuming a competent guest OS of course. Have you tested this?
>
> Paul
This being the qemu side of things? I run Linux
and verified that it calls OSHP and afterwards,
runs the native driver and handles hotplug/unplug
without invoking ACPI at all.
It seems that at least the SHPC driver in linux
doesn't work if you don't have an acpi table
with the OSHP method - not many people run with acpi=off
nowdays, so it's probably just a bug.
I'll check how hard it is to fix this.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org,
Isaku Yamahata <yamahata@valinux.co.jp>,
Kevin O'Connor <kevin@koconnor.net>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub
Date: Tue, 14 Feb 2012 15:37:28 +0200 [thread overview]
Message-ID: <20120214133727.GA23647@redhat.com> (raw)
In-Reply-To: <201202141249.09301.paul@codesourcery.com>
On Tue, Feb 14, 2012 at 12:49:08PM +0000, Paul Brook wrote:
> > > In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking
> > > for an additional Ack.
> >
> > No problem, I'll get an Ack :)
> > Meanwhile - here's a summary, as far as I understand it.
> >
> > Originally PCI SIG only defined the electrical
> > and mechanical requirements from hotplug, no standard
> > software interface. So it needed ACPI to drive device-specific registers
> > to actually do hotplug.
> > At some point PCISIG defined standard interfaces
> > for PCI hotplug. There are two of them: standard
> > hot plug controller (SHPC) for PCI and PCIE hotplug
> > for Express.
> >
> > Now an OS can have a standard driver and use it
> > to activate hotplug functionality. This is OS hotplug (OSHP).
>
> So presumably this will work on targets that don't have ACPI?
> Assuming a competent guest OS of course. Have you tested this?
>
> Paul
This being the qemu side of things? I run Linux
and verified that it calls OSHP and afterwards,
runs the native driver and handles hotplug/unplug
without invoking ACPI at all.
It seems that at least the SHPC driver in linux
doesn't work if you don't have an acpi table
with the OSHP method - not many people run with acpi=off
nowdays, so it's probably just a bug.
I'll check how hard it is to fix this.
--
MST
next prev parent reply other threads:[~2012-02-14 13:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 9:15 [PATCHv2-RFC 0/2] RFC: standard pci bridge device Michael S. Tsirkin
2012-02-13 9:15 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 9:15 ` [PATCHv2-RFC 1/2] shpc: standard hot plug controller Michael S. Tsirkin
2012-02-13 9:15 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 10:03 ` Isaku Yamahata
2012-02-13 10:03 ` [Qemu-devel] " Isaku Yamahata
2012-02-13 11:49 ` Michael S. Tsirkin
2012-02-13 11:49 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 14:30 ` Isaku Yamahata
2012-02-13 14:30 ` [Qemu-devel] " Isaku Yamahata
2012-02-13 14:49 ` Michael S. Tsirkin
2012-02-13 14:49 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-17 13:20 ` Gerd Hoffmann
2012-02-17 13:20 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:16 ` [PATCHv2-RFC 2/2] pci: add standard bridge device Michael S. Tsirkin
2012-02-13 9:16 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-17 13:25 ` Gerd Hoffmann
2012-02-17 13:25 ` [Qemu-devel] " Gerd Hoffmann
2012-02-19 14:57 ` Michael S. Tsirkin
2012-02-19 14:57 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-19 23:44 ` Michael S. Tsirkin
2012-02-19 23:44 ` Michael S. Tsirkin
2012-02-17 13:33 ` Gerd Hoffmann
2012-02-17 13:33 ` [Qemu-devel] " Gerd Hoffmann
2012-02-20 22:40 ` Michael S. Tsirkin
2012-02-20 22:40 ` Michael S. Tsirkin
2012-02-21 8:02 ` Gerd Hoffmann
2012-02-21 8:02 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:33 ` [PATCH RFC] seabios: add OSHP method stub Michael S. Tsirkin
2012-02-13 9:33 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 0:34 ` Kevin O'Connor
2012-02-14 0:34 ` [Qemu-devel] " Kevin O'Connor
2012-02-14 0:43 ` Michael S. Tsirkin
2012-02-14 0:43 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 0:48 ` Kevin O'Connor
2012-02-14 0:48 ` [Qemu-devel] " Kevin O'Connor
2012-02-14 1:09 ` Michael S. Tsirkin
2012-02-14 1:09 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 12:49 ` Paul Brook
2012-02-14 12:49 ` [Qemu-devel] " Paul Brook
2012-02-14 13:37 ` Michael S. Tsirkin [this message]
2012-02-14 13:37 ` Michael S. Tsirkin
2012-02-14 13:47 ` Paul Brook
2012-02-14 13:47 ` Paul Brook
2012-02-14 14:11 ` Michael S. Tsirkin
2012-02-14 14:11 ` Michael S. Tsirkin
2012-02-29 11:25 ` [SeaBIOS] " Gerd Hoffmann
2012-02-29 11:25 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:38 ` [PATCHv2-RFC 0/2] RFC: standard pci bridge device Wen Congyang
2012-02-13 9:38 ` [Qemu-devel] " Wen Congyang
2012-02-13 9:56 ` Michael S. Tsirkin
2012-02-13 9:56 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214133727.GA23647@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.