From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Isaku Yamahata <yamahata@valinux.co.jp>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCHv2-RFC 2/2] pci: add standard bridge device
Date: Fri, 17 Feb 2012 14:25:56 +0100 [thread overview]
Message-ID: <4F3E5564.7040406@redhat.com> (raw)
In-Reply-To: <f9b630bb6c67f0facf29e42277ad7d991e660b3c.1329124507.git.mst@redhat.com>
Hi,
> + /* If we don't specify the name, the bus will be addressed as <id>.0, where
> + * id is the parent id. But it seems more natural to address the bus using
> + * the parent device name. */
> + if (dev->qdev.id && *dev->qdev.id) {
> + br->bus_name = dev->qdev.id;
> + }
That makes the bridge behave different than everybody else.
Not a good idea IMHO.
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Isaku Yamahata <yamahata@valinux.co.jp>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device
Date: Fri, 17 Feb 2012 14:25:56 +0100 [thread overview]
Message-ID: <4F3E5564.7040406@redhat.com> (raw)
In-Reply-To: <f9b630bb6c67f0facf29e42277ad7d991e660b3c.1329124507.git.mst@redhat.com>
Hi,
> + /* If we don't specify the name, the bus will be addressed as <id>.0, where
> + * id is the parent id. But it seems more natural to address the bus using
> + * the parent device name. */
> + if (dev->qdev.id && *dev->qdev.id) {
> + br->bus_name = dev->qdev.id;
> + }
That makes the bridge behave different than everybody else.
Not a good idea IMHO.
cheers,
Gerd
next prev parent reply other threads:[~2012-02-17 13:25 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 9:15 [PATCHv2-RFC 0/2] RFC: standard pci bridge device Michael S. Tsirkin
2012-02-13 9:15 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 9:15 ` [PATCHv2-RFC 1/2] shpc: standard hot plug controller Michael S. Tsirkin
2012-02-13 9:15 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 10:03 ` Isaku Yamahata
2012-02-13 10:03 ` [Qemu-devel] " Isaku Yamahata
2012-02-13 11:49 ` Michael S. Tsirkin
2012-02-13 11:49 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-13 14:30 ` Isaku Yamahata
2012-02-13 14:30 ` [Qemu-devel] " Isaku Yamahata
2012-02-13 14:49 ` Michael S. Tsirkin
2012-02-13 14:49 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-17 13:20 ` Gerd Hoffmann
2012-02-17 13:20 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:16 ` [PATCHv2-RFC 2/2] pci: add standard bridge device Michael S. Tsirkin
2012-02-13 9:16 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-17 13:25 ` Gerd Hoffmann [this message]
2012-02-17 13:25 ` Gerd Hoffmann
2012-02-19 14:57 ` Michael S. Tsirkin
2012-02-19 14:57 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-19 23:44 ` Michael S. Tsirkin
2012-02-19 23:44 ` Michael S. Tsirkin
2012-02-17 13:33 ` Gerd Hoffmann
2012-02-17 13:33 ` [Qemu-devel] " Gerd Hoffmann
2012-02-20 22:40 ` Michael S. Tsirkin
2012-02-20 22:40 ` Michael S. Tsirkin
2012-02-21 8:02 ` Gerd Hoffmann
2012-02-21 8:02 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:33 ` [PATCH RFC] seabios: add OSHP method stub Michael S. Tsirkin
2012-02-13 9:33 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 0:34 ` Kevin O'Connor
2012-02-14 0:34 ` [Qemu-devel] " Kevin O'Connor
2012-02-14 0:43 ` Michael S. Tsirkin
2012-02-14 0:43 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 0:48 ` Kevin O'Connor
2012-02-14 0:48 ` [Qemu-devel] " Kevin O'Connor
2012-02-14 1:09 ` Michael S. Tsirkin
2012-02-14 1:09 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 12:49 ` Paul Brook
2012-02-14 12:49 ` [Qemu-devel] " Paul Brook
2012-02-14 13:37 ` Michael S. Tsirkin
2012-02-14 13:37 ` [Qemu-devel] " Michael S. Tsirkin
2012-02-14 13:47 ` Paul Brook
2012-02-14 13:47 ` Paul Brook
2012-02-14 14:11 ` Michael S. Tsirkin
2012-02-14 14:11 ` Michael S. Tsirkin
2012-02-29 11:25 ` [SeaBIOS] " Gerd Hoffmann
2012-02-29 11:25 ` [Qemu-devel] " Gerd Hoffmann
2012-02-13 9:38 ` [PATCHv2-RFC 0/2] RFC: standard pci bridge device Wen Congyang
2012-02-13 9:38 ` [Qemu-devel] " Wen Congyang
2012-02-13 9:56 ` Michael S. Tsirkin
2012-02-13 9:56 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E5564.7040406@redhat.com \
--to=kraxel@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.