From: Gustavo Padovan <padovan@profusion.mobi>
To: Joe Perches <joe@perches.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Thu, 16 Feb 2012 16:05:07 -0200 [thread overview]
Message-ID: <20120216180507.GA5280@joana> (raw)
In-Reply-To: <1329410631.10890.3.camel@joe2Laptop>
Hi Joe,
* Joe Perches <joe@perches.com> [2012-02-16 08:43:51 -0800]:
> On Mon, 2012-02-13 at 18:02 -0800, Joe Perches wrote:
> > On Mon, 2012-02-13 at 19:56 -0200, Gustavo Padovan wrote:
> > > it is not really a good idea to change BT_INFO to
> > > bt_info and BT_ERR to bt_err. I understand that capital letters are not the
> > > standard here but such a change is painful for all Bluetooth developers and I
> > > don't wanna give more trouble to them.
> []
> > Standardization of use and style is a good thing.
> > What kind of trouble is a case conversion?
> > Out of tree modules?
>
> I'm truly curious as to why you think a
> case conversion is painful and trouble.
Such a change will require rebase from all our developers and we already have
enough issues to solve, I don't wanna add one more here. Change what BT_*
stands for is ok, but there is no need to change the macros names.
Gustavo
next prev parent reply other threads:[~2012-02-16 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 3:15 [PATCH 0/2] bluetooth: logging cleanups and trivial object shrinking Joe Perches
2012-02-13 3:15 ` [PATCH 1/2] bluetooth: Use more current logging styles Joe Perches
2012-02-13 6:35 ` Marcel Holtmann
2012-02-13 6:46 ` Joe Perches
2012-02-13 7:21 ` Marcel Holtmann
2012-02-13 7:28 ` Joe Perches
2012-02-13 7:28 ` Joe Perches
2012-02-13 7:30 ` Marcel Holtmann
2012-02-13 7:30 ` Marcel Holtmann
2012-02-13 8:24 ` Joe Perches
2012-02-13 8:24 ` Joe Perches
2012-02-13 21:56 ` Gustavo Padovan
2012-02-13 21:56 ` Gustavo Padovan
2012-02-14 2:02 ` Joe Perches
2012-02-16 16:43 ` Joe Perches
2012-02-16 18:05 ` Gustavo Padovan [this message]
2012-02-16 21:33 ` David Miller
2012-02-17 8:58 ` Marcel Holtmann
2012-02-13 3:15 ` [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-13 6:37 ` Marcel Holtmann
2012-02-13 6:51 ` Joe Perches
2012-02-13 7:19 ` Marcel Holtmann
2012-02-13 7:24 ` Joe Perches
2012-02-13 7:24 ` Joe Perches
2012-02-13 9:21 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216180507.GA5280@joana \
--to=padovan@profusion.mobi \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.