From: Joe Perches <joe@perches.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Sun, 12 Feb 2012 23:28:00 -0800 [thread overview]
Message-ID: <1329118080.31068.4.camel@joe2Laptop> (raw)
In-Reply-To: <1329117706.28848.55.camel@aeonflux>
On Mon, 2012-02-13 at 08:21 +0100, Marcel Holtmann wrote:
> > There shouldn't be a newline at all with the
> > actual functions bt_err or bt_info except
> > at the uses.
> then you might wanna read your patch again ;)
Yup, there's no newline with bt_info
and there shouldn't be one with bt_err
either. There is though. Oh well.
Easy to fix at your end if you like.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: "Gustavo F. Padovan"
<padovan-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Sun, 12 Feb 2012 23:28:00 -0800 [thread overview]
Message-ID: <1329118080.31068.4.camel@joe2Laptop> (raw)
In-Reply-To: <1329117706.28848.55.camel@aeonflux>
On Mon, 2012-02-13 at 08:21 +0100, Marcel Holtmann wrote:
> > There shouldn't be a newline at all with the
> > actual functions bt_err or bt_info except
> > at the uses.
> then you might wanna read your patch again ;)
Yup, there's no newline with bt_info
and there shouldn't be one with bt_err
either. There is though. Oh well.
Easy to fix at your end if you like.
next prev parent reply other threads:[~2012-02-13 7:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 3:15 [PATCH 0/2] bluetooth: logging cleanups and trivial object shrinking Joe Perches
2012-02-13 3:15 ` [PATCH 1/2] bluetooth: Use more current logging styles Joe Perches
2012-02-13 6:35 ` Marcel Holtmann
2012-02-13 6:46 ` Joe Perches
2012-02-13 7:21 ` Marcel Holtmann
2012-02-13 7:28 ` Joe Perches [this message]
2012-02-13 7:28 ` Joe Perches
2012-02-13 7:30 ` Marcel Holtmann
2012-02-13 7:30 ` Marcel Holtmann
2012-02-13 8:24 ` Joe Perches
2012-02-13 8:24 ` Joe Perches
2012-02-13 21:56 ` Gustavo Padovan
2012-02-13 21:56 ` Gustavo Padovan
2012-02-14 2:02 ` Joe Perches
2012-02-16 16:43 ` Joe Perches
2012-02-16 18:05 ` Gustavo Padovan
2012-02-16 21:33 ` David Miller
2012-02-17 8:58 ` Marcel Holtmann
2012-02-13 3:15 ` [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-13 6:37 ` Marcel Holtmann
2012-02-13 6:51 ` Joe Perches
2012-02-13 7:19 ` Marcel Holtmann
2012-02-13 7:24 ` Joe Perches
2012-02-13 7:24 ` Joe Perches
2012-02-13 9:21 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329118080.31068.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.