All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <padovan@profusion.mobi>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Joe Perches <joe@perches.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Mon, 13 Feb 2012 19:56:03 -0200	[thread overview]
Message-ID: <20120213215603.GA27753@joana> (raw)
In-Reply-To: <1329114913.28848.50.camel@aeonflux>

Hi Joe,

* Marcel Holtmann <marcel@holtmann.org> [2012-02-13 07:35:13 +0100]:

> Hi Joe,
> 
> > Make functions for bt_info and bt_err.
> > Remove now unused function bt_printk.
> > Convert uses of BT_INFO and BT_ERR to bt_info and bt_err.
> 
> That is all fine, but why not just change BT_INFO to point to bt_info
> and BT_ERR to bt_err first instead of having this huge patch mixed in
> with the changes. The size measurement should be no different.

I'm with Marcel here, it is not really a good idea to change BT_INFO to
bt_info and BT_ERR to bt_err. I understand that capital letters are not the
standard here but such a change is painful for all Bluetooth developers and I
don't wanna give more trouble to them. I'm ok if we only change bluetooth.h
here.

	Gustavo

WARNING: multiple messages have this Message-ID (diff)
From: Gustavo Padovan <padovan-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>
To: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
Cc: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Mon, 13 Feb 2012 19:56:03 -0200	[thread overview]
Message-ID: <20120213215603.GA27753@joana> (raw)
In-Reply-To: <1329114913.28848.50.camel@aeonflux>

Hi Joe,

* Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org> [2012-02-13 07:35:13 +0100]:

> Hi Joe,
> 
> > Make functions for bt_info and bt_err.
> > Remove now unused function bt_printk.
> > Convert uses of BT_INFO and BT_ERR to bt_info and bt_err.
> 
> That is all fine, but why not just change BT_INFO to point to bt_info
> and BT_ERR to bt_err first instead of having this huge patch mixed in
> with the changes. The size measurement should be no different.

I'm with Marcel here, it is not really a good idea to change BT_INFO to
bt_info and BT_ERR to bt_err. I understand that capital letters are not the
standard here but such a change is painful for all Bluetooth developers and I
don't wanna give more trouble to them. I'm ok if we only change bluetooth.h
here.

	Gustavo

  parent reply	other threads:[~2012-02-13 21:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13  3:15 [PATCH 0/2] bluetooth: logging cleanups and trivial object shrinking Joe Perches
2012-02-13  3:15 ` [PATCH 1/2] bluetooth: Use more current logging styles Joe Perches
2012-02-13  6:35   ` Marcel Holtmann
2012-02-13  6:46     ` Joe Perches
2012-02-13  7:21       ` Marcel Holtmann
2012-02-13  7:28         ` Joe Perches
2012-02-13  7:28           ` Joe Perches
2012-02-13  7:30           ` Marcel Holtmann
2012-02-13  7:30             ` Marcel Holtmann
2012-02-13  8:24             ` Joe Perches
2012-02-13  8:24               ` Joe Perches
2012-02-13 21:56     ` Gustavo Padovan [this message]
2012-02-13 21:56       ` Gustavo Padovan
2012-02-14  2:02       ` Joe Perches
2012-02-16 16:43         ` Joe Perches
2012-02-16 18:05           ` Gustavo Padovan
2012-02-16 21:33             ` David Miller
2012-02-17  8:58               ` Marcel Holtmann
2012-02-13  3:15 ` [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-13  6:37   ` Marcel Holtmann
2012-02-13  6:51     ` Joe Perches
2012-02-13  7:19       ` Marcel Holtmann
2012-02-13  7:24         ` Joe Perches
2012-02-13  7:24           ` Joe Perches
2012-02-13  9:21       ` Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120213215603.GA27753@joana \
    --to=padovan@profusion.mobi \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.