From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels
Date: Mon, 20 Feb 2012 17:39:57 +0000 [thread overview]
Message-ID: <20120220173957.GA10776@ericsson.com> (raw)
In-Reply-To: <CAO7tRnjoSKUKoL4445e+Gud7Dhe=K9K1MYnGNCYcBs-d4X2O6A@mail.gmail.com>
On Thu, Feb 16, 2012 at 04:29:22PM -0500, Jean Delvare wrote:
> On Mon, 13 Feb 2012 00:56:00 -0500, Chris wrote:
> > Removed initialization to leave bios or hardware defaults alone.
>
> Err, this is going too far. The original author of the code obviously
> needed the driver to initialize the chip, otherwise he wouldn't have
> defined a platform data for this purpose. Killing the initialization
> function altogether makes no sense. All I said was that it seemed
> curious to do it all _by default_.
>
> Anyway, this is really a secondary issue at this point. The main
> problems is the two functional bugs we spotted in the driver. We should
> fix them first, and then we can discuss the rest if there is an
> interest. I'm not using this driver and I don't know who is in
> practice, so I don't care that much.
>
> Please resubmit a (-p1) patch fixing the issue your originally spotted
> instead.
>
We really need input from Roland on the initialization problem.
Might make sense to kwwp him copied on this exchange.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-02-20 17:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 3:00 [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels Chris
2012-02-12 9:30 ` Jean Delvare
2012-02-13 5:53 ` Chris
2012-02-13 5:56 ` Chris
2012-02-16 21:18 ` Jean Delvare
2012-02-16 21:29 ` Jean Delvare
2012-02-20 17:39 ` Guenter Roeck [this message]
2012-02-20 18:58 ` Roland Stigge
2012-02-20 21:58 ` Chris
2012-02-20 21:59 ` Chris
2012-02-20 22:14 ` Chris
2012-02-20 22:28 ` Guenter Roeck
2012-02-20 22:31 ` Guenter Roeck
2012-02-20 22:44 ` Chris
2012-02-20 22:53 ` Roland Stigge
2012-02-20 22:56 ` Roland Stigge
2012-02-20 23:06 ` Roland Stigge
2012-02-20 23:53 ` Guenter Roeck
2012-02-20 23:57 ` Guenter Roeck
2012-02-20 23:58 ` Guenter Roeck
2012-02-21 8:40 ` Roland Stigge
2012-02-21 8:41 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220173957.GA10776@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.