From: Roland Stigge <stigge@antcom.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels
Date: Mon, 20 Feb 2012 18:58:31 +0000 [thread overview]
Message-ID: <4F4297D7.4010100@antcom.de> (raw)
In-Reply-To: <CAO7tRnjoSKUKoL4445e+Gud7Dhe=K9K1MYnGNCYcBs-d4X2O6A@mail.gmail.com>
Hi!
On 02/20/2012 06:39 PM, Guenter Roeck wrote:
>> Please resubmit a (-p1) patch fixing the issue your originally spotted
>> instead.
>>
> We really need input from Roland on the initialization problem.
> Might make sense to kwwp him copied on this exchange.
Thanks for your notification and sorry for the delay!
Unfortunately, when I ported the driver from the other original author,
I kept the initialization procedure which is obviously wrong, doing
initialization only for one channel. (I adjusted the driver locally
platform-dependent, so didn't find a chance for mainline integration and
this way, the obvious problems in the mainline driver slipped.)
Therefore, a fix for doing this for both channels, possibly in a loop,
would be good, IMO.
Jean's note about the broken variable initialization is correct. Should
have done this differently.
The other note about initialization only with platform_data is also a
good idea.
I'm using the chip on a custom ARM board without BIOS initialization,
but providing platform_data in this case should be the correct way, anyway.
So Chris, if you are already at it, do it this way. Otherwise please
notify me and I can prepare patches.
Thanks for your work!
Roland
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-02-20 18:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 3:00 [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels Chris
2012-02-12 9:30 ` Jean Delvare
2012-02-13 5:53 ` Chris
2012-02-13 5:56 ` Chris
2012-02-16 21:18 ` Jean Delvare
2012-02-16 21:29 ` Jean Delvare
2012-02-20 17:39 ` Guenter Roeck
2012-02-20 18:58 ` Roland Stigge [this message]
2012-02-20 21:58 ` Chris
2012-02-20 21:59 ` Chris
2012-02-20 22:14 ` Chris
2012-02-20 22:28 ` Guenter Roeck
2012-02-20 22:31 ` Guenter Roeck
2012-02-20 22:44 ` Chris
2012-02-20 22:53 ` Roland Stigge
2012-02-20 22:56 ` Roland Stigge
2012-02-20 23:06 ` Roland Stigge
2012-02-20 23:53 ` Guenter Roeck
2012-02-20 23:57 ` Guenter Roeck
2012-02-20 23:58 ` Guenter Roeck
2012-02-21 8:40 ` Roland Stigge
2012-02-21 8:41 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4297D7.4010100@antcom.de \
--to=stigge@antcom.de \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.