From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels
Date: Mon, 20 Feb 2012 23:58:23 +0000 [thread overview]
Message-ID: <20120220235823.GC24915@ericsson.com> (raw)
In-Reply-To: <CAO7tRnjoSKUKoL4445e+Gud7Dhe=K9K1MYnGNCYcBs-d4X2O6A@mail.gmail.com>
On Mon, Feb 20, 2012 at 05:53:16PM -0500, Roland Stigge wrote:
> On 20/02/12 22:58, Chris wrote:
> > Patch to fix PPR register initialization to set both channels
> > Signed-off-by: Chris D Schimp <silverchris <at> gmail.com>
>
> Looks good.
>
> Acked-by: Roland Stigge <stigge@antcom.de>
>
So << 6 instead of << 5 is ok ?
Thanks,
Guenter
> > ---
> > diff -uprN -X a/Documentation/dontdiff a/drivers/hwmon/max6639.c
> > b/drivers/hwmon/max6639.c
> > --- a/drivers/hwmon/max6639.c 2012-02-06 12:47:00.000000000 -0500
> > +++ b/drivers/hwmon/max6639.c 2012-02-20 16:36:02.553668023 -0500
> > @@ -438,7 +438,6 @@ static int max6639_init_client(struct i2
> > MAX6639_GCONFIG_POR);
> > if (err)
> > goto exit;
> > -
> > /* Fans pulse per revolution is 2 by default */
> > if (max6639_info && max6639_info->ppr > 0 &&
> > max6639_info->ppr < 5)
> > @@ -446,11 +445,6 @@ static int max6639_init_client(struct i2
> > else
> > data->ppr = 2;
> > data->ppr -= 1;
> > - err = i2c_smbus_write_byte_data(client,
> > - MAX6639_REG_FAN_PPR(i),
> > - data->ppr << 5);
> > - if (err)
> > - goto exit;
> >
> > if (max6639_info)
> > rpm_range = rpm_range_to_reg(max6639_info->rpm_range);
> > @@ -458,6 +452,13 @@ static int max6639_init_client(struct i2
> >
> > for (i = 0; i < 2; i++) {
> >
> > + /* Set Fan pulse per revolution */
> > + err = i2c_smbus_write_byte_data(client,
> > + MAX6639_REG_FAN_PPR(i),
> > + data->ppr << 6);
> > + if (err)
> > + goto exit;
> > +
> > /* Fans config PWM, RPM */
> > err = i2c_smbus_write_byte_data(client,
> > MAX6639_REG_FAN_CONFIG1(i),
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-02-20 23:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-12 3:00 [lm-sensors] [Patch] hwmon: (max6639) Set Pulse per revolution loop for both channels Chris
2012-02-12 9:30 ` Jean Delvare
2012-02-13 5:53 ` Chris
2012-02-13 5:56 ` Chris
2012-02-16 21:18 ` Jean Delvare
2012-02-16 21:29 ` Jean Delvare
2012-02-20 17:39 ` Guenter Roeck
2012-02-20 18:58 ` Roland Stigge
2012-02-20 21:58 ` Chris
2012-02-20 21:59 ` Chris
2012-02-20 22:14 ` Chris
2012-02-20 22:28 ` Guenter Roeck
2012-02-20 22:31 ` Guenter Roeck
2012-02-20 22:44 ` Chris
2012-02-20 22:53 ` Roland Stigge
2012-02-20 22:56 ` Roland Stigge
2012-02-20 23:06 ` Roland Stigge
2012-02-20 23:53 ` Guenter Roeck
2012-02-20 23:57 ` Guenter Roeck
2012-02-20 23:58 ` Guenter Roeck [this message]
2012-02-21 8:40 ` Roland Stigge
2012-02-21 8:41 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220235823.GC24915@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.