All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/vgem: getparam ioctl
Date: Mon, 20 Feb 2012 18:12:38 +0100	[thread overview]
Message-ID: <20120220181238.2d09a76e@bwidawsk.net> (raw)
In-Reply-To: <CAPM=9tyrCFHYhn-+wHAWJMKoMD8yqN3mHiQ-eBjmfpV_Nd4T1A@mail.gmail.com>

On Thu, 16 Feb 2012 07:23:52 +0000
Dave Airlie <airlied@gmail.com> wrote:

> On Wed, Feb 15, 2012 at 9:22 PM, Adam Jackson <ajax@redhat.com> wrote:
> > On 2/8/12 6:19 PM, Ben Widawsky wrote:
> >>
> >> Similar to i915, it's nice to be able to query this device uniquely and
> >> get some info
> >>
> >> Signed-off-by: Ben Widawsky<ben@bwidawsk.net>
> >
> >
> > So, this is actually not especially useful as written.  You'd like to be
> > able to use this to find the vgem device node, but since it's a
> > device-specific ioctl it collides with whatever happens to be
> > device-specific ioctl number 2 on whatever device you've opened.  On i915,
> > that's I915_FLIP, and you promptly oops the machine.
> >

Hmm... it doesn't oops my machine.

> 
> We have DRM level caps that we could use for that if necessary.
> 
> I'm not sure we need a getparam for vgem if the only thing it reports
> is VGEM status.

The plan I had for it was to report whether or not prime support exists. But
I'll just call the prime ioctls and see if they fail instead.

> 
> Though yeah what ajax said looking in /sys is the discovery path of choice.

I've done this now, it turned out quite nicely.

> 
> Dave.

Thanks.
~Ben
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-02-20 17:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 23:19 [RFCv2 PATCH 0/5] virtual GEM provider Ben Widawsky
2012-02-08 23:19 ` [PATCH 1/5] drm/vgem: " Ben Widawsky
2012-02-08 23:28   ` Chris Wilson
2012-02-16 13:52   ` Jakob Bornecrantz
2012-02-20 17:10     ` Ben Widawsky
2012-02-21 15:03       ` Adam Jackson
2012-02-21 15:34         ` Dave Airlie
2012-02-21 16:08           ` Adam Jackson
2012-02-21 17:41             ` Ben Widawsky
2012-02-08 23:19 ` [PATCH 2/5] drm/vgem: fops should be separate and constified Ben Widawsky
2012-02-08 23:19 ` [PATCH 3/5] drm/vgem: Add a drm_vgem_gem_object Ben Widawsky
2012-02-08 23:19 ` [PATCH 4/5] drm/vgem: getparam ioctl Ben Widawsky
2012-02-15 21:22   ` Adam Jackson
2012-02-16  7:23     ` Dave Airlie
2012-02-20 17:12       ` Ben Widawsky [this message]
2012-02-08 23:19 ` [PATCH 5/5] drm/vgem: properly implement mmap Ben Widawsky
2012-02-08 23:36   ` Chris Wilson
2012-02-09  9:18     ` Ben Widawsky
2012-02-09 10:20     ` Daniel Vetter
2012-02-14  2:18   ` Eric Anholt
2012-02-14  7:49     ` Dave Airlie
2012-02-14  0:14 ` [RFCv2 PATCH 0/5] virtual GEM provider Adam Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120220181238.2d09a76e@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.