From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/vgem: virtual GEM provider
Date: Wed, 08 Feb 2012 23:28:42 +0000 [thread overview]
Message-ID: <aefc95$34igt1@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1328743171-13750-2-git-send-email-ben@bwidawsk.net>
On Thu, 9 Feb 2012 00:19:27 +0100, Ben Widawsky <ben@bwidawsk.net> wrote:
> From: Adam Jackson <ajax@redhat.com>
> +static void vgem_gem_free_object(struct drm_gem_object *obj)
> +{
> + if (obj->map_list.map)
> + drm_gem_free_mmap_offset(obj);
> +
> + drm_gem_object_release(obj);
> +}
drm_gem_free_mmap_offset() should be pushed down into
drm_gem_object_release(). Out of the 6 distinct users of
drm_gem_object_release(), 3 call drm_gem_free_mmap_offset() just prior
and gma500 forgets to.
I do accept that it is a separate patch though ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-08 23:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 23:19 [RFCv2 PATCH 0/5] virtual GEM provider Ben Widawsky
2012-02-08 23:19 ` [PATCH 1/5] drm/vgem: " Ben Widawsky
2012-02-08 23:28 ` Chris Wilson [this message]
2012-02-16 13:52 ` Jakob Bornecrantz
2012-02-20 17:10 ` Ben Widawsky
2012-02-21 15:03 ` Adam Jackson
2012-02-21 15:34 ` Dave Airlie
2012-02-21 16:08 ` Adam Jackson
2012-02-21 17:41 ` Ben Widawsky
2012-02-08 23:19 ` [PATCH 2/5] drm/vgem: fops should be separate and constified Ben Widawsky
2012-02-08 23:19 ` [PATCH 3/5] drm/vgem: Add a drm_vgem_gem_object Ben Widawsky
2012-02-08 23:19 ` [PATCH 4/5] drm/vgem: getparam ioctl Ben Widawsky
2012-02-15 21:22 ` Adam Jackson
2012-02-16 7:23 ` Dave Airlie
2012-02-20 17:12 ` Ben Widawsky
2012-02-08 23:19 ` [PATCH 5/5] drm/vgem: properly implement mmap Ben Widawsky
2012-02-08 23:36 ` Chris Wilson
2012-02-09 9:18 ` Ben Widawsky
2012-02-09 10:20 ` Daniel Vetter
2012-02-14 2:18 ` Eric Anholt
2012-02-14 7:49 ` Dave Airlie
2012-02-14 0:14 ` [RFCv2 PATCH 0/5] virtual GEM provider Adam Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$34igt1@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.