From: Adam Jackson <ajax@redhat.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFCv2 PATCH 0/5] virtual GEM provider
Date: Mon, 13 Feb 2012 19:14:58 -0500 [thread overview]
Message-ID: <4F39A782.9040205@redhat.com> (raw)
In-Reply-To: <1328743171-13750-1-git-send-email-ben@bwidawsk.net>
On 2/8/12 6:19 PM, Ben Widawsky wrote:
> Incorporated some of the feedback given to Adam's original patch.
>
> My intention is to use this to do some dmabuf work/testing with i915
> since it seemed too difficult to get some of Dave Airlie's stuff
> working, and I really don't feel like learning anything about nouveau if
> I can avoid it. (though I plan to do that later as well).
>
> I think what's missing is a shrinker, left in size for mmap (didn't see
> anyone respond to Daniel Vetter's comment), munmap/remap probably won't
> work, do quite a bit more testing; that's all I can think of at the
> moment.
munmap appears to work. However if you do it after the close() you
segfault at at exit. That's probably suboptimal.
From an API perspective this is certainly enough for llvmpipe, and I
can work around munmap being quirky for now.
Reviewed-by: Adam Jackson <ajax@redhat.com>
- ajax
prev parent reply other threads:[~2012-02-14 0:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 23:19 [RFCv2 PATCH 0/5] virtual GEM provider Ben Widawsky
2012-02-08 23:19 ` [PATCH 1/5] drm/vgem: " Ben Widawsky
2012-02-08 23:28 ` Chris Wilson
2012-02-16 13:52 ` Jakob Bornecrantz
2012-02-20 17:10 ` Ben Widawsky
2012-02-21 15:03 ` Adam Jackson
2012-02-21 15:34 ` Dave Airlie
2012-02-21 16:08 ` Adam Jackson
2012-02-21 17:41 ` Ben Widawsky
2012-02-08 23:19 ` [PATCH 2/5] drm/vgem: fops should be separate and constified Ben Widawsky
2012-02-08 23:19 ` [PATCH 3/5] drm/vgem: Add a drm_vgem_gem_object Ben Widawsky
2012-02-08 23:19 ` [PATCH 4/5] drm/vgem: getparam ioctl Ben Widawsky
2012-02-15 21:22 ` Adam Jackson
2012-02-16 7:23 ` Dave Airlie
2012-02-20 17:12 ` Ben Widawsky
2012-02-08 23:19 ` [PATCH 5/5] drm/vgem: properly implement mmap Ben Widawsky
2012-02-08 23:36 ` Chris Wilson
2012-02-09 9:18 ` Ben Widawsky
2012-02-09 10:20 ` Daniel Vetter
2012-02-14 2:18 ` Eric Anholt
2012-02-14 7:49 ` Dave Airlie
2012-02-14 0:14 ` Adam Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F39A782.9040205@redhat.com \
--to=ajax@redhat.com \
--cc=ben@bwidawsk.net \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.