From: Jason Baron <jbaron@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, davem@davemloft.net,
ddaney.cavm@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs
Date: Tue, 21 Feb 2012 15:20:19 -0500 [thread overview]
Message-ID: <20120221202019.GB2381@redhat.com> (raw)
In-Reply-To: <4F43F9F0.4000605@zytor.com>
On Tue, Feb 21, 2012 at 12:09:20PM -0800, H. Peter Anvin wrote:
> On 02/21/2012 12:02 PM, Jason Baron wrote:
> > Hi,
> >
> > Renames 'static_branch()' -> very_unlikely(), hopefully, to be more intuitive
> > as to what jump labels is about. I'm also introducing 'very_likely()', as
> > the analogue to very_unlikely(). Patch is against the -tip perf branch.
> >
>
> Erk... I'm not happy about this. very_unlikely() makes it sound like it
> operates like unlikely(), which really is not the case. There is a huge
> difference in mechanism here as well as usage.
>
> -hpa
>
The naming discussion really stems from the addition of a default true
branch.
Originally we had 'static_branch()'. Then, in the first RFC introducing
the default true branch, I proposed: 'static_branch_def_false', and
'static_branch_def_true'. Did you like those better?
I'm not really too hung up on the naming, but I did think that
very_[un]likely were an interesting possibility.
Thanks,
-Jason
next prev parent reply other threads:[~2012-02-21 20:20 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 20:02 [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs Jason Baron
2012-02-21 20:02 ` [PATCH 01/10] jump label: Add a WARN() if jump label key count goes negative Jason Baron
2012-02-29 10:13 ` [tip:perf/core] " tip-bot for Jason Baron
2012-02-21 20:02 ` [PATCH 02/10] jump label: fix compiler warning Jason Baron
2012-02-29 10:14 ` [tip:perf/core] jump label: Fix " tip-bot for Jason Baron
2012-02-21 20:03 ` [PATCH 03/10] jump label: introduce very_unlikely() Jason Baron
2012-02-21 20:03 ` [PATCH 04/10] jump label: introduce very_likely() Jason Baron
2012-02-21 20:03 ` [PATCH 05/10] perf: update to use 'very_unlikely()' Jason Baron
2012-02-21 20:03 ` [PATCH 06/10] tracepoints: update to use very_unlikely() Jason Baron
2012-02-21 20:03 ` [PATCH 07/10] sched: update to use very_[un]likely() Jason Baron
2012-02-21 20:03 ` [PATCH 08/10] kvm: update to use very_unlikely() Jason Baron
2012-02-21 20:03 ` [PATCH 09/10] net: " Jason Baron
2012-02-21 20:03 ` [PATCH 10/10] jump label: Add docs better explaining the whole jump label mechanism Jason Baron
2012-02-29 10:15 ` [tip:perf/core] static keys: Add docs better explaining the whole 'struct static_key' mechanism tip-bot for Jason Baron
2012-02-21 20:09 ` [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs H. Peter Anvin
2012-02-21 20:20 ` Jason Baron [this message]
2012-02-21 20:39 ` Steven Rostedt
2012-02-21 21:10 ` H. Peter Anvin
2012-02-21 21:16 ` Mathieu Desnoyers
2012-02-21 21:11 ` Mathieu Desnoyers
2012-02-22 7:32 ` Ingo Molnar
2012-02-22 7:53 ` Ingo Molnar
2012-02-22 8:01 ` H. Peter Anvin
2012-02-22 8:18 ` Ingo Molnar
2012-02-22 8:58 ` [PATCH] static keys: Introduce 'struct static_key', very_[un]likely(), static_key_slow_[inc|dec]() Ingo Molnar
2012-02-29 10:16 ` [tip:perf/core] static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]() tip-bot for Ingo Molnar
2012-02-22 9:03 ` [PATCH] jump labels: Explain the .config option better Ingo Molnar
2012-02-22 15:08 ` [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs H. Peter Anvin
2012-02-22 15:51 ` Ingo Molnar
2012-02-22 21:33 ` Paul Mackerras
2012-02-23 10:02 ` Ingo Molnar
2012-02-23 16:21 ` Jason Baron
2012-02-23 17:10 ` H. Peter Anvin
2012-02-24 9:11 ` Ingo Molnar
2012-02-23 17:18 ` Linus Torvalds
2012-02-23 22:33 ` Ingo Molnar
2012-02-23 22:39 ` Ingo Molnar
2012-02-23 22:44 ` Steven Rostedt
2012-02-23 23:18 ` Mathieu Desnoyers
2012-02-24 2:25 ` Jason Baron
2012-02-24 9:08 ` Ingo Molnar
2012-02-24 15:35 ` Jason Baron
2012-02-27 7:40 ` Ingo Molnar
2012-02-24 15:51 ` Mathieu Desnoyers
2012-02-24 16:06 ` Steven Rostedt
2012-02-24 7:52 ` static keys: Introduce 'struct static_key', static_key_true()/false() and static_key_slow_[inc|dec]() Ingo Molnar
2012-02-24 7:59 ` [PATCH] " Ingo Molnar
2012-02-24 7:54 ` [PATCH] static keys: Add docs better explaining the whole 'struct static_key' mechanism Ingo Molnar
2012-02-23 22:45 ` [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs Linus Torvalds
2012-02-24 8:04 ` Ingo Molnar
2012-02-24 2:42 ` Jason Baron
2012-02-21 20:21 ` Steven Rostedt
2012-02-21 21:11 ` H. Peter Anvin
2012-02-22 6:50 ` Ingo Molnar
2012-02-22 7:03 ` H. Peter Anvin
2012-02-22 7:25 ` Ingo Molnar
2012-02-22 7:35 ` H. Peter Anvin
2012-02-22 7:48 ` Ingo Molnar
2012-02-22 7:55 ` H. Peter Anvin
2012-02-22 8:06 ` Ingo Molnar
2012-02-22 13:22 ` Steven Rostedt
2012-02-22 13:34 ` Ingo Molnar
2012-02-22 13:54 ` Steven Rostedt
2012-02-22 14:20 ` Mathieu Desnoyers
2012-02-22 14:36 ` Steven Rostedt
2012-02-22 14:56 ` Ingo Molnar
2012-02-22 15:11 ` H. Peter Anvin
2012-02-22 15:11 ` Peter Zijlstra
2012-02-22 15:47 ` Ingo Molnar
2012-02-22 15:12 ` Steven Rostedt
2012-02-22 15:15 ` H. Peter Anvin
2012-02-22 15:19 ` H. Peter Anvin
2012-02-22 15:42 ` Jason Baron
2012-02-22 15:54 ` Steven Rostedt
2012-02-22 15:56 ` Jason Baron
2012-02-22 16:08 ` Steven Rostedt
2012-02-22 15:19 ` Jason Baron
2012-02-22 15:40 ` H. Peter Anvin
2012-02-22 15:13 ` Peter Zijlstra
2012-02-22 15:32 ` Peter Zijlstra
2012-02-22 17:14 ` Richard Henderson
2012-02-22 18:28 ` H. Peter Anvin
2012-02-22 18:58 ` Jason Baron
2012-02-22 19:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221202019.GB2381@redhat.com \
--to=jbaron@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ddaney.cavm@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.