Re: [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()

[Tony Lindgren <tony@atomide.com>]

* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120223 00:09]:
> 2012/2/23 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > Hello,
> >
> > On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
> >> WARNING: vmlinux.o(.text+0x226d0):
> >> Section mismatch in reference from the function
> >> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
> >> The function platform_cpu_die() references
> >> the function __cpuinit omap4_hotplug_cpu().
> >> This is often because platform_cpu_die lacks a __cpuinit
> >> annotation or the annotation of omap4_hotplug_cpu is wrong.
> >>
> >> Thanks to Russell King for suggesting __ref annotation trick
> >> just like it's parent function for this warning becasue __cupinit
> > s/it's/its/; s/becasue/because/; s/cup/cpu/
> >
> > Having said that I think the grammar is broken, too. Maybe:
> >
> >        Thanks to Russell King for suggesting to use __ref instead of
> >        the initial (and wrong) approach to use __cpuinit.
> >
> > (But note I'm not a native speaker, too)
> >
> Thanks for fixing the grammar. :)
> Updated patch below with comments corrected as per
> your suggestion.

Thanks applying both into fixes-non-critical.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html