From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Lucas De Marchi
<lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 11:36:43 -0800 [thread overview]
Message-ID: <20120301193643.GA607@kroah.com> (raw)
In-Reply-To: <1330630010-11241-9-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
On Thu, Mar 01, 2012 at 02:26:50PM -0500, Alan Ott wrote:
> From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
>
> The driver should not call set_irq_flags itself, and
> cannot do this from a loadable module.
>
> Remove the call for now, which might break the driver
> but at least lets the kernel link again.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Um, I think you should test this out before submitting it anywhere :)
As it is, I can't accept it.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 11:36:43 -0800 [thread overview]
Message-ID: <20120301193643.GA607@kroah.com> (raw)
In-Reply-To: <1330630010-11241-9-git-send-email-alan@signal11.us>
On Thu, Mar 01, 2012 at 02:26:50PM -0500, Alan Ott wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver should not call set_irq_flags itself, and
> cannot do this from a loadable module.
>
> Remove the call for now, which might break the driver
> but at least lets the kernel link again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Um, I think you should test this out before submitting it anywhere :)
As it is, I can't accept it.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Ott <alan@signal11.us>
Cc: Russell King <linux@arm.linux.org.uk>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@nvidia.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
Alan Stern <stern@rowland.harvard.edu>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 11:36:43 -0800 [thread overview]
Message-ID: <20120301193643.GA607@kroah.com> (raw)
In-Reply-To: <1330630010-11241-9-git-send-email-alan@signal11.us>
On Thu, Mar 01, 2012 at 02:26:50PM -0500, Alan Ott wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver should not call set_irq_flags itself, and
> cannot do this from a loadable module.
>
> Remove the call for now, which might break the driver
> but at least lets the kernel link again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Um, I think you should test this out before submitting it anywhere :)
As it is, I can't accept it.
greg k-h
next prev parent reply other threads:[~2012-03-01 19:36 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 19:26 [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` [PATCH 1/8] ARM: tegra: export tegra_gpio_{en,dis}able Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-2-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:59 ` Olof Johansson
2012-03-01 19:59 ` Olof Johansson
2012-03-01 19:59 ` Olof Johansson
2012-03-02 7:24 ` Grant Likely
2012-03-02 7:24 ` Grant Likely
2012-03-02 7:24 ` Grant Likely
2012-03-02 22:32 ` [PATCH v2] " Alan Ott
2012-03-09 17:00 ` Alan Ott
[not found] ` <4F5A3726.8030505-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-09 17:09 ` Stephen Warren
2012-03-09 17:09 ` Stephen Warren
2012-03-12 17:43 ` Grant Likely
2012-03-01 19:26 ` [PATCH 2/8] ARM: tegra: do not hide dma declarations Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` [PATCH 3/8] ARM: tegra: select CPU_FREQ_TABLE Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-4-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:05 ` Olof Johansson
2012-03-01 20:05 ` Olof Johansson
2012-03-01 20:05 ` Olof Johansson
2012-03-01 19:26 ` [PATCH 4/8] ARM: tegra: build localtimer support only when needed Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-5-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-02 11:40 ` Sergei Shtylyov
[not found] ` <1330630010-11241-1-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:26 ` [PATCH 5/8] ARM: tegra: work around tegra THUMB2_KERNEL bug Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 20:02 ` Stephen Warren
2012-03-01 20:02 ` Stephen Warren
2012-03-01 20:02 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17BE861726-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:46 ` Arnd Bergmann
2012-03-01 20:46 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-9-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:36 ` Greg Kroah-Hartman [this message]
2012-03-01 19:36 ` Greg Kroah-Hartman
2012-03-01 19:36 ` Greg Kroah-Hartman
[not found] ` <20120301193643.GA607-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:38 ` Arnd Bergmann
2012-03-01 20:38 ` Arnd Bergmann
2012-03-01 21:00 ` Russell King - ARM Linux
2012-03-01 21:00 ` Russell King - ARM Linux
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:40 ` Arnd Bergmann
2012-03-01 20:40 ` Arnd Bergmann
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 19:26 ` [PATCH 6/8] ARM: tegra: USB_ULPI needs USB Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-7-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:25 ` Arnd Bergmann
2012-03-01 20:25 ` Arnd Bergmann
[not found] ` <201203012025.53560.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-01 20:36 ` Stephen Warren
2012-03-01 20:36 ` Stephen Warren
2012-03-01 20:36 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17BE861741-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 7/8] ARM: tegra: export usb phy symbols Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-8-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:14 ` Stephen Warren
2012-03-01 20:14 ` Stephen Warren
2012-03-01 20:14 ` Stephen Warren
2012-03-01 20:19 ` [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Arnd Bergmann
2012-03-01 20:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301193643.GA607@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.