From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alan Ott <alan@signal11.us>,
Russell King <linux@arm.linux.org.uk>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@nvidia.com>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 20:40:17 +0000 [thread overview]
Message-ID: <201203012040.18158.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdZK+9gF7N2akyWw=tvcBS2X2FmSd2-SiNKiuRgUCYXx7w@mail.gmail.com>
On Thursday 01 March 2012, Linus Walleij wrote:
> The kernel is full of this kind of stuff (drivers/mfd/twl4030-irq.c):
>
> #ifdef CONFIG_ARM
> /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> */
> set_irq_flags(irq, IRQF_VALID);
> #else
> /* same effect on other architectures */
> irq_set_noprobe(irq);
> #endif
That is the implementation of an irq_chip, not a random device driver.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 20:40:17 +0000 [thread overview]
Message-ID: <201203012040.18158.arnd@arndb.de> (raw)
In-Reply-To: <CACRpkdZK+9gF7N2akyWw=tvcBS2X2FmSd2-SiNKiuRgUCYXx7w@mail.gmail.com>
On Thursday 01 March 2012, Linus Walleij wrote:
> The kernel is full of this kind of stuff (drivers/mfd/twl4030-irq.c):
>
> #ifdef CONFIG_ARM
> /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> */
> set_irq_flags(irq, IRQF_VALID);
> #else
> /* same effect on other architectures */
> irq_set_noprobe(irq);
> #endif
That is the implementation of an irq_chip, not a random device driver.
Arnd
next prev parent reply other threads:[~2012-03-01 20:40 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 19:26 [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` [PATCH 1/8] ARM: tegra: export tegra_gpio_{en,dis}able Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-2-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:59 ` Olof Johansson
2012-03-01 19:59 ` Olof Johansson
2012-03-01 19:59 ` Olof Johansson
2012-03-02 7:24 ` Grant Likely
2012-03-02 7:24 ` Grant Likely
2012-03-02 7:24 ` Grant Likely
2012-03-02 22:32 ` [PATCH v2] " Alan Ott
2012-03-09 17:00 ` Alan Ott
[not found] ` <4F5A3726.8030505-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-09 17:09 ` Stephen Warren
2012-03-09 17:09 ` Stephen Warren
2012-03-12 17:43 ` Grant Likely
2012-03-01 19:26 ` [PATCH 2/8] ARM: tegra: do not hide dma declarations Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` [PATCH 3/8] ARM: tegra: select CPU_FREQ_TABLE Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-4-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:05 ` Olof Johansson
2012-03-01 20:05 ` Olof Johansson
2012-03-01 20:05 ` Olof Johansson
2012-03-01 19:26 ` [PATCH 4/8] ARM: tegra: build localtimer support only when needed Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-5-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-01 19:26 ` [PATCH 6/8] ARM: tegra: USB_ULPI needs USB Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-7-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:25 ` Arnd Bergmann
2012-03-01 20:25 ` Arnd Bergmann
[not found] ` <201203012025.53560.arnd-r2nGTMty4D4@public.gmane.org>
2012-03-01 20:36 ` Stephen Warren
2012-03-01 20:36 ` Stephen Warren
2012-03-01 20:36 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17BE861741-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 7/8] ARM: tegra: export usb phy symbols Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-8-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 20:14 ` Stephen Warren
2012-03-01 20:14 ` Stephen Warren
2012-03-01 20:14 ` Stephen Warren
[not found] ` <1330630010-11241-1-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:26 ` [PATCH 5/8] ARM: tegra: work around tegra THUMB2_KERNEL bug Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 20:02 ` Stephen Warren
2012-03-01 20:02 ` Stephen Warren
2012-03-01 20:02 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF17BE861726-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:46 ` Arnd Bergmann
2012-03-01 20:46 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver Alan Ott
2012-03-01 19:26 ` Alan Ott
2012-03-01 19:26 ` Alan Ott
[not found] ` <1330630010-11241-9-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2012-03-01 19:36 ` Greg Kroah-Hartman
2012-03-01 19:36 ` Greg Kroah-Hartman
2012-03-01 19:36 ` Greg Kroah-Hartman
[not found] ` <20120301193643.GA607-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:38 ` Arnd Bergmann
2012-03-01 20:38 ` Arnd Bergmann
2012-03-01 21:00 ` Russell King - ARM Linux
2012-03-01 21:00 ` Russell King - ARM Linux
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:40 ` Arnd Bergmann [this message]
2012-03-01 20:40 ` Arnd Bergmann
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 20:54 ` Russell King - ARM Linux
2012-03-01 20:19 ` [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Arnd Bergmann
2012-03-01 20:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203012040.18158.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@signal11.us \
--cc=ccross@android.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lucas.demarchi@profusion.mobi \
--cc=olof@lixom.net \
--cc=stern@rowland.harvard.edu \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.