All of lore.kernel.org
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c DT support
Date: Fri, 9 Mar 2012 10:55:46 +0100	[thread overview]
Message-ID: <20120309095546.GL27213@game.jcrosoft.org> (raw)
In-Reply-To: <20120309052600.B13BA3E0649@localhost>

On 22:26 Thu 08 Mar     , Grant Likely wrote:
> On Thu,  8 Mar 2012 09:50:32 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > For now on use i2c-gpio driver on the same pin as the hardware IP.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: devicetree-discuss at lists.ozlabs.org
> > ---
> > v3:
> > 
> > 	update i2c binding (Rob comments)
> > 
> > Best Regards,
> > J.
> >  arch/arm/boot/dts/at91sam9g20.dtsi |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> > index 4b0dc99..072b2da 100644
> > --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> > @@ -189,4 +189,17 @@
> >  			status = "disabled";
> >  		};
> >  	};
> > +
> > +	i2c-gpio at 0 {
> 
> i2c at 0
> 
> > +		compatible = "i2c-gpio";
> > +		gpios = <&pioA 23 0 /* sda */
> > +			 &pioA 24 0 /* scl */
> > +			>;
> > +		i2c-gpio,sda-open-drain;
> > +		i2c-gpio,scl-open-drain;
> > +		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> 
> gpio-driven i2c busses are inherently board-specific.  Why is this
> in the SoC include file?
because they use the hw pin and all board will use the same as on some soc
(old) we can not use the hw IP
> 
> Otherwise I think this patch series looks okay.

Best Regards,
J.

WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c DT support
Date: Fri, 9 Mar 2012 10:55:46 +0100	[thread overview]
Message-ID: <20120309095546.GL27213@game.jcrosoft.org> (raw)
In-Reply-To: <20120309052600.B13BA3E0649@localhost>

On 22:26 Thu 08 Mar     , Grant Likely wrote:
> On Thu,  8 Mar 2012 09:50:32 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
> > For now on use i2c-gpio driver on the same pin as the hardware IP.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
> > Cc: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > ---
> > v3:
> > 
> > 	update i2c binding (Rob comments)
> > 
> > Best Regards,
> > J.
> >  arch/arm/boot/dts/at91sam9g20.dtsi |   13 +++++++++++++
> >  1 files changed, 13 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> > index 4b0dc99..072b2da 100644
> > --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> > @@ -189,4 +189,17 @@
> >  			status = "disabled";
> >  		};
> >  	};
> > +
> > +	i2c-gpio@0 {
> 
> i2c@0
> 
> > +		compatible = "i2c-gpio";
> > +		gpios = <&pioA 23 0 /* sda */
> > +			 &pioA 24 0 /* scl */
> > +			>;
> > +		i2c-gpio,sda-open-drain;
> > +		i2c-gpio,scl-open-drain;
> > +		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		status = "disabled";
> > +	};
> 
> gpio-driven i2c busses are inherently board-specific.  Why is this
> in the SoC include file?
because they use the hw pin and all board will use the same as on some soc
(old) we can not use the hw IP
> 
> Otherwise I think this patch series looks okay.

Best Regards,
J.

  reply	other threads:[~2012-03-09  9:55 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08  8:50 [PATCH 1/5 v3] i2c/gpio: add DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50 ` [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c " Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:08   ` Rob Herring
2012-03-08 17:08     ` Rob Herring
2012-03-09  9:53     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09  9:53       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 13:59       ` Rob Herring
2012-03-09 13:59         ` Rob Herring
2012-03-13  7:08         ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13  7:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09  5:26   ` Grant Likely
2012-03-09  5:26     ` Grant Likely
2012-03-09  9:55     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-03-09  9:55       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50 ` [PATCH 3/5 v3] ARM: at91: usb_a9g20 add DT i2c support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50 ` [PATCH 4/5 v3] ARM: at91: sam9g45 add i2c DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50 ` [PATCH 5/5 v3] ARM: at91: sam9x5 " Jean-Christophe PLAGNIOL-VILLARD
2012-03-08  8:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:12   ` Rob Herring
2012-03-08 17:12     ` Rob Herring
2012-03-08 17:52     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:52       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 20:36       ` Rob Herring
2012-03-08 20:36         ` Rob Herring
     [not found] ` <1331196635-27203-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-03-08 10:52   ` [PATCH 1/5 v3] i2c/gpio: add " Karol Lewandowski
2012-03-08 10:52     ` Karol Lewandowski
     [not found]     ` <4F588F50.7060906-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-08 16:53       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 16:53         ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:16   ` Rob Herring
2012-03-08 17:16     ` Rob Herring
2012-03-13  7:07   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13  7:07     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13  7:37   ` Wolfram Sang
2012-03-13  7:37     ` Wolfram Sang
     [not found]     ` <20120313073748.GA7746-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-13  9:11       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13  9:11         ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]         ` <20120313091104.GE18320-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-03-13 10:22           ` Wolfram Sang
2012-03-13 10:22             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120309095546.GL27213@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.