From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c DT support
Date: Tue, 13 Mar 2012 08:08:13 +0100 [thread overview]
Message-ID: <20120313070813.GD18320@game.jcrosoft.org> (raw)
In-Reply-To: <4F5A0CB5.2020203@gmail.com>
On 07:59 Fri 09 Mar , Rob Herring wrote:
> On 03/09/2012 03:53 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 11:08 Thu 08 Mar , Rob Herring wrote:
> >> On 03/08/2012 02:50 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>> For now on use i2c-gpio driver on the same pin as the hardware IP.
> >>>
> >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >>> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> >>> Cc: devicetree-discuss at lists.ozlabs.org
> >>> ---
> >>> v3:
> >>>
> >>> update i2c binding (Rob comments)
> >>>
> >>> Best Regards,
> >>> J.
> >>> arch/arm/boot/dts/at91sam9g20.dtsi | 13 +++++++++++++
> >>> 1 files changed, 13 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> index 4b0dc99..072b2da 100644
> >>> --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> @@ -189,4 +189,17 @@
> >>> status = "disabled";
> >>> };
> >>> };
> >>> +> > + i2c-gpio at 0 {
> >>
> >> You updated the example, but not all the actual uses to i2c at 0.
> > on purpose as on some soc we will have HW and soft binding
> >
> > on the board you put the alias
> >
>
> I'm not sure I follow.
>
> If you use the h/w block, then you would have i2c@<addr> while for gpio
> it's basically an index.
>
> Also, I don't think you need an alias for i2c. You should not care about
> bus numbering as devices should be sub nodes.
forget about it tired when I reply
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Rob Herring <robherring2@gmail.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c DT support
Date: Tue, 13 Mar 2012 08:08:13 +0100 [thread overview]
Message-ID: <20120313070813.GD18320@game.jcrosoft.org> (raw)
In-Reply-To: <4F5A0CB5.2020203@gmail.com>
On 07:59 Fri 09 Mar , Rob Herring wrote:
> On 03/09/2012 03:53 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 11:08 Thu 08 Mar , Rob Herring wrote:
> >> On 03/08/2012 02:50 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>> For now on use i2c-gpio driver on the same pin as the hardware IP.
> >>>
> >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> >>> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> >>> Cc: devicetree-discuss@lists.ozlabs.org
> >>> ---
> >>> v3:
> >>>
> >>> update i2c binding (Rob comments)
> >>>
> >>> Best Regards,
> >>> J.
> >>> arch/arm/boot/dts/at91sam9g20.dtsi | 13 +++++++++++++
> >>> 1 files changed, 13 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi b/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> index 4b0dc99..072b2da 100644
> >>> --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> >>> @@ -189,4 +189,17 @@
> >>> status = "disabled";
> >>> };
> >>> };
> >>> +> > + i2c-gpio@0 {
> >>
> >> You updated the example, but not all the actual uses to i2c@0.
> > on purpose as on some soc we will have HW and soft binding
> >
> > on the board you put the alias
> >
>
> I'm not sure I follow.
>
> If you use the h/w block, then you would have i2c@<addr> while for gpio
> it's basically an index.
>
> Also, I don't think you need an alias for i2c. You should not care about
> bus numbering as devices should be sub nodes.
forget about it tired when I reply
Best Regards,
J.
next prev parent reply other threads:[~2012-03-13 7:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 8:50 [PATCH 1/5 v3] i2c/gpio: add DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` [PATCH 2/5 v3] ARM: at91: sam9g20 add i2c " Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:08 ` Rob Herring
2012-03-08 17:08 ` Rob Herring
2012-03-09 9:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 9:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 13:59 ` Rob Herring
2012-03-09 13:59 ` Rob Herring
2012-03-13 7:08 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-03-13 7:08 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 5:26 ` Grant Likely
2012-03-09 5:26 ` Grant Likely
2012-03-09 9:55 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-09 9:55 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` [PATCH 3/5 v3] ARM: at91: usb_a9g20 add DT i2c support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` [PATCH 4/5 v3] ARM: at91: sam9g45 add i2c DT support Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` [PATCH 5/5 v3] ARM: at91: sam9x5 " Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 8:50 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:12 ` Rob Herring
2012-03-08 17:12 ` Rob Herring
2012-03-08 17:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:52 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 20:36 ` Rob Herring
2012-03-08 20:36 ` Rob Herring
[not found] ` <1331196635-27203-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-03-08 10:52 ` [PATCH 1/5 v3] i2c/gpio: add " Karol Lewandowski
2012-03-08 10:52 ` Karol Lewandowski
[not found] ` <4F588F50.7060906-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-03-08 16:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 16:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-08 17:16 ` Rob Herring
2012-03-08 17:16 ` Rob Herring
2012-03-13 7:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 7:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 7:37 ` Wolfram Sang
2012-03-13 7:37 ` Wolfram Sang
[not found] ` <20120313073748.GA7746-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-03-13 9:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-13 9:11 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20120313091104.GE18320-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-03-13 10:22 ` Wolfram Sang
2012-03-13 10:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313070813.GD18320@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.