All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Rajendra Nayak <rnayak@ti.com>,
	"T Krishnamoorthy, Balaji" <balajitk@ti.com>
Cc: cjb@laptop.org, linaro-dev@lists.linaro.org,
	devicetree-discuss@lists.ozlabs.org, linux-mmc@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data
Date: Fri, 09 Mar 2012 08:49:11 -0700	[thread overview]
Message-ID: <20120309154911.8C23C3E08E2@localhost> (raw)
In-Reply-To: <4F4765EC.1000102@ti.com>

On Fri, 24 Feb 2012 15:56:52 +0530, Rajendra Nayak <rnayak@ti.com> wrote:
> On Friday 24 February 2012 03:46 PM, T Krishnamoorthy, Balaji wrote:
> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> >> index 29f4589..9204f60 100644
> >> --- a/arch/arm/boot/dts/omap4.dtsi
> >> +++ b/arch/arm/boot/dts/omap4.dtsi
> >> @@ -25,6 +25,11 @@
> >>                 serial1 =&uart2;
> >>                 serial2 =&uart3;
> >>                 serial3 =&uart4;
> >> +               mmc1 =&mmc1;
> >> +               mmc2 =&mmc2;
> >> +               mmc3 =&mmc3;
> >> +               mmc4 =&mmc4;
> >> +               mmc5 =&mmc5;
> >>         };
> >>
> >>         cpus {
> >> @@ -155,5 +160,31 @@
> >>                         #size-cells =<0>;
> >>                         ti,hwmods = "i2c4";
> >>                 };
> >> +
> >> +               mmc1: mmc@1 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc1";
> >> +                       ti,dual-volt;
> >> +               };
> >> +
> >> +               mmc2: mmc@2 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc2";
> >> +               };
> >
> > Hi Rajendra,
> > Is there a way to control the device registration order,
> > eMMC connected to mmc2 needs to be registered as /dev/mmcblk0p ...
> > irrespective of whether SD card is mount or not on mmc1 card slot.
> > So that bootargs would not have to be modified when filesystem is on eMMC.
> 
> I don't know if we can, but even if we could, we take care of the same
> bootargs working on two boards (say sdp and panda) *if* on sdp I have my
> filesystem on eMMC and on panda I have it on external card.
> What happens if I want to use my filesystem on both boards on external
> card?

of_alias_get_id() may be able to help you here.  It will extract the id
numbering from the /aliases node.  That is the safe way to do global
enumeration of devices in the device tree (instead of 'cell-index' which
is strongly discouraged)

g.

> 
> >
> >> +
> >> +               mmc3: mmc@3 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc3";
> >> +               };
> >> +
> >> +               mmc4: mmc@4 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc4";
> >> +               };
> >> +
> >> +               mmc5: mmc@5 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc5";
> >> +               };
> >>         };
> >>   };
> >> --
> >> 1.7.1
> >>
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data
Date: Fri, 09 Mar 2012 08:49:11 -0700	[thread overview]
Message-ID: <20120309154911.8C23C3E08E2@localhost> (raw)
In-Reply-To: <4F4765EC.1000102@ti.com>

On Fri, 24 Feb 2012 15:56:52 +0530, Rajendra Nayak <rnayak@ti.com> wrote:
> On Friday 24 February 2012 03:46 PM, T Krishnamoorthy, Balaji wrote:
> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> >> index 29f4589..9204f60 100644
> >> --- a/arch/arm/boot/dts/omap4.dtsi
> >> +++ b/arch/arm/boot/dts/omap4.dtsi
> >> @@ -25,6 +25,11 @@
> >>                 serial1 =&uart2;
> >>                 serial2 =&uart3;
> >>                 serial3 =&uart4;
> >> +               mmc1 =&mmc1;
> >> +               mmc2 =&mmc2;
> >> +               mmc3 =&mmc3;
> >> +               mmc4 =&mmc4;
> >> +               mmc5 =&mmc5;
> >>         };
> >>
> >>         cpus {
> >> @@ -155,5 +160,31 @@
> >>                         #size-cells =<0>;
> >>                         ti,hwmods = "i2c4";
> >>                 };
> >> +
> >> +               mmc1: mmc at 1 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc1";
> >> +                       ti,dual-volt;
> >> +               };
> >> +
> >> +               mmc2: mmc at 2 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc2";
> >> +               };
> >
> > Hi Rajendra,
> > Is there a way to control the device registration order,
> > eMMC connected to mmc2 needs to be registered as /dev/mmcblk0p ...
> > irrespective of whether SD card is mount or not on mmc1 card slot.
> > So that bootargs would not have to be modified when filesystem is on eMMC.
> 
> I don't know if we can, but even if we could, we take care of the same
> bootargs working on two boards (say sdp and panda) *if* on sdp I have my
> filesystem on eMMC and on panda I have it on external card.
> What happens if I want to use my filesystem on both boards on external
> card?

of_alias_get_id() may be able to help you here.  It will extract the id
numbering from the /aliases node.  That is the safe way to do global
enumeration of devices in the device tree (instead of 'cell-index' which
is strongly discouraged)

g.

> 
> >
> >> +
> >> +               mmc3: mmc at 3 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc3";
> >> +               };
> >> +
> >> +               mmc4: mmc at 4 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc4";
> >> +               };
> >> +
> >> +               mmc5: mmc at 5 {
> >> +                       compatible = "ti,omap4-hsmmc";
> >> +                       ti,hwmods = "mmc5";
> >> +               };
> >>         };
> >>   };
> >> --
> >> 1.7.1
> >>
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

  parent reply	other threads:[~2012-03-09 15:49 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23 12:01 [PATCH v2 0/4] omap hsmmc device tree support Rajendra Nayak
2012-02-23 12:01 ` Rajendra Nayak
     [not found] ` <1329998490-27555-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2012-02-23 12:01   ` [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree Rajendra Nayak
2012-02-23 12:01     ` Rajendra Nayak
     [not found]     ` <1329998490-27555-2-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2012-02-24 11:32       ` T Krishnamoorthy, Balaji
2012-02-24 11:32         ` T Krishnamoorthy, Balaji
2012-02-24 11:35         ` Rajendra Nayak
2012-02-24 11:35           ` Rajendra Nayak
     [not found]           ` <4F4775FF.2090500-l0cyMroinI0@public.gmane.org>
2012-02-24 12:51             ` Cousson, Benoit
2012-02-24 12:51               ` Cousson, Benoit
2012-02-24 12:58               ` Rajendra Nayak
2012-02-24 12:58                 ` Rajendra Nayak
     [not found]                 ` <4F478963.20009-l0cyMroinI0@public.gmane.org>
2012-02-24 13:02                   ` Cousson, Benoit
2012-02-24 13:02                     ` Cousson, Benoit
2012-02-24 13:04                     ` Rajendra Nayak
2012-02-24 13:04                       ` Rajendra Nayak
2012-03-08  3:46     ` Rajendra Nayak
2012-03-08  3:46       ` Rajendra Nayak
2012-03-08 15:58       ` Rob Herring
2012-03-08 15:58         ` Rob Herring
2012-03-09  5:42     ` Grant Likely
2012-03-09  5:42       ` Grant Likely
2012-03-09  9:21       ` Rajendra Nayak
2012-03-09  9:21         ` Rajendra Nayak
2012-02-23 12:01   ` [PATCH v2 2/4] mmc: omap_hsmmc: Avoid a regulator voltage change with dt Rajendra Nayak
2012-02-23 12:01     ` Rajendra Nayak
2012-02-23 12:01   ` [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data Rajendra Nayak
2012-02-23 12:01     ` Rajendra Nayak
2012-02-24 10:16     ` T Krishnamoorthy, Balaji
2012-02-24 10:16       ` T Krishnamoorthy, Balaji
2012-02-24 10:26       ` Rajendra Nayak
2012-02-24 10:26         ` Rajendra Nayak
     [not found]         ` <4F4765EC.1000102-l0cyMroinI0@public.gmane.org>
2012-02-24 10:37           ` Russell King - ARM Linux
2012-02-24 10:37             ` Russell King - ARM Linux
2012-02-24 10:59         ` T Krishnamoorthy, Balaji
2012-02-24 10:59           ` T Krishnamoorthy, Balaji
2012-03-09 15:49         ` Grant Likely [this message]
2012-03-09 15:49           ` Grant Likely
2012-02-23 12:01   ` [PATCH v2 4/4] arm/dts: OMAP3: " Rajendra Nayak
2012-02-23 12:01     ` Rajendra Nayak
2012-02-23 18:57     ` Tony Lindgren
2012-02-23 18:57       ` Tony Lindgren
2012-02-24  4:00       ` Rajendra Nayak
2012-02-24  4:00         ` Rajendra Nayak
     [not found]         ` <4F470B71.1020308-l0cyMroinI0@public.gmane.org>
2012-02-24 11:23           ` Cousson, Benoit
2012-02-24 11:23             ` Cousson, Benoit
2012-02-24 18:49         ` Tony Lindgren
2012-02-24 18:49           ` Tony Lindgren
2012-03-09  5:46           ` Grant Likely
2012-03-09  5:46             ` Grant Likely
2012-03-09  6:51             ` Paul Walmsley
2012-03-09  6:51               ` Paul Walmsley
2012-03-09  9:36               ` Rajendra Nayak
2012-03-09  9:36                 ` Rajendra Nayak
2012-03-09  9:26             ` Rajendra Nayak
2012-03-09  9:26               ` Rajendra Nayak
2012-02-23 12:13 ` [PATCH v2 0/4] omap hsmmc device tree support Rajendra Nayak
2012-02-23 12:13   ` Rajendra Nayak
  -- strict thread matches above, loose matches on Subject: below --
2012-03-12 15:02 Rajendra Nayak
2012-03-12 15:02 ` [PATCH v2 3/4] arm/dts: OMAP4: Add mmc controller nodes and board data Rajendra Nayak
2012-03-12 15:02   ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120309154911.8C23C3E08E2@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=balajitk@ti.com \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.