From: Fengguang Wu <fengguang.wu@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: David Rientjes <rientjes@google.com>,
Borislav Petkov <bp@amd64.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name
Date: Thu, 29 Mar 2012 22:05:25 +0800 [thread overview]
Message-ID: <20120329140525.GA10452@localhost> (raw)
In-Reply-To: <20120328090909.GX22197@one.firstfloor.org>
On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote:
> > I agree with your change, but I'm not sure these should be pr_info() to
> > start with, these seem more like debugging messages? I can't see how
> > they'd be useful in standard operation so could we just convert them to be
> > debug instead?
>
> Well it tells why the page recovery didn't work.
>
> Memory recovery is a somewhat obscure path, so it's better to have
> full information.
Nod, and it won't disturb the users unless something really bad happens.
I'm fine with the patch, too.
Thanks,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: David Rientjes <rientjes@google.com>,
Borislav Petkov <bp@amd64.org>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name
Date: Thu, 29 Mar 2012 22:05:25 +0800 [thread overview]
Message-ID: <20120329140525.GA10452@localhost> (raw)
In-Reply-To: <20120328090909.GX22197@one.firstfloor.org>
On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote:
> > I agree with your change, but I'm not sure these should be pr_info() to
> > start with, these seem more like debugging messages? I can't see how
> > they'd be useful in standard operation so could we just convert them to be
> > debug instead?
>
> Well it tells why the page recovery didn't work.
>
> Memory recovery is a somewhat obscure path, so it's better to have
> full information.
Nod, and it won't disturb the users unless something really bad happens.
I'm fine with the patch, too.
Thanks,
Fengguang
next prev parent reply other threads:[~2012-03-29 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 10:17 [PATCH] mm/memory_failure: Let the compiler add the function name Borislav Petkov
2012-03-27 10:17 ` Borislav Petkov
2012-03-28 0:49 ` Andi Kleen
2012-03-28 0:49 ` Andi Kleen
2012-03-28 7:19 ` David Rientjes
2012-03-28 7:19 ` David Rientjes
2012-03-28 9:09 ` Andi Kleen
2012-03-28 9:09 ` Andi Kleen
2012-03-29 14:05 ` Fengguang Wu [this message]
2012-03-29 14:05 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329140525.GA10452@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.