From: Chris Mason <chris.mason@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Btrfs fixes and features
Date: Fri, 30 Mar 2012 16:04:47 -0400 [thread overview]
Message-ID: <20120330200447.GL755@shiny> (raw)
In-Reply-To: <CA+55aFyn0TL6vJZrGVQkgAscT33nf9_7rH-DRVJbcG3K7d7QKA@mail.gmail.com>
On Fri, Mar 30, 2012 at 12:54:03PM -0700, Linus Torvalds wrote:
> On Fri, Mar 30, 2012 at 12:50 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > This causes a new warning for me:
> >
> > =C2=A0fs/btrfs/extent_io.c: In function =E2=80=98repair_eb_io_failu=
re=E2=80=99:
> > =C2=A0fs/btrfs/extent_io.c:1940:6: warning: =E2=80=98ret=E2=80=99 m=
ay be used
> > uninitialized in this function
> >
> > Hmm?
>=20
> Ok, so presumably num_pages (which is "num_extent_pages(eb->start,
> eb->len)") cannot be zero, so I guess the code is ok. But gcc can't
> know that, and it's an annoying warning.
Whoops, my reply was too slow, sorry. If you're curious my gcc that
doesn't warn in 4.6.3.
>=20
> So please fix, but it's not urgent. In the meantime I've pulled and p=
ushed out.
Ok, I'll send just the incremental in a later pull.
-chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Btrfs fixes and features
Date: Fri, 30 Mar 2012 16:04:47 -0400 [thread overview]
Message-ID: <20120330200447.GL755@shiny> (raw)
In-Reply-To: <CA+55aFyn0TL6vJZrGVQkgAscT33nf9_7rH-DRVJbcG3K7d7QKA@mail.gmail.com>
On Fri, Mar 30, 2012 at 12:54:03PM -0700, Linus Torvalds wrote:
> On Fri, Mar 30, 2012 at 12:50 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > This causes a new warning for me:
> >
> > fs/btrfs/extent_io.c: In function ‘repair_eb_io_failure’:
> > fs/btrfs/extent_io.c:1940:6: warning: ‘ret’ may be used
> > uninitialized in this function
> >
> > Hmm?
>
> Ok, so presumably num_pages (which is "num_extent_pages(eb->start,
> eb->len)") cannot be zero, so I guess the code is ok. But gcc can't
> know that, and it's an annoying warning.
Whoops, my reply was too slow, sorry. If you're curious my gcc that
doesn't warn in 4.6.3.
>
> So please fix, but it's not urgent. In the meantime I've pulled and pushed out.
Ok, I'll send just the incremental in a later pull.
-chris
next prev parent reply other threads:[~2012-03-30 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 17:51 [GIT PULL] Btrfs fixes and features Chris Mason
2012-03-30 19:50 ` Linus Torvalds
2012-03-30 19:50 ` Linus Torvalds
2012-03-30 19:54 ` Linus Torvalds
2012-03-30 19:54 ` Linus Torvalds
2012-03-30 20:04 ` Chris Mason [this message]
2012-03-30 20:04 ` Chris Mason
2012-03-30 20:01 ` Chris Mason
2012-03-30 20:01 ` Chris Mason
2012-03-30 20:27 ` Alex
2012-04-02 11:45 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330200447.GL755@shiny \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.