From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: versatile: fix build failure in pci.c
Date: Tue, 3 Apr 2012 08:19:48 +0000 [thread overview]
Message-ID: <201204030819.48798.arnd@arndb.de> (raw)
In-Reply-To: <CAOMZO5A-+tcz6ewTykXL33opRVP9U4o7Ltdkbr7LLqWMBQczSQ@mail.gmail.com>
On Tuesday 03 April 2012, Fabio Estevam wrote:
> On Mon, Apr 2, 2012 at 10:01 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>
> > I see. Well, there weren't any follow ups to it but I would say that
> > passing both sys->resources and sys both side-by-side at the same
> > time doesn't really make sense. I think just passing in sys by itself
> > as I did is a cleaner way to go, wouldn't you agree?
>
> Yes, I agree.
But that doesn't work: struct pci_sys_data is ARM specific, while
pci_add_resource_offset is common code.
I think it would be much more sensible here to just use pci_add_resource(),
which is the same as the offsets are all zero for versatile.
Arnd
next prev parent reply other threads:[~2012-04-03 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 23:48 [PATCH] ARM: versatile: fix build failure in pci.c Paul Gortmaker
2012-04-03 0:03 ` Fabio Estevam
2012-04-03 1:01 ` Paul Gortmaker
2012-04-03 1:57 ` Fabio Estevam
2012-04-03 8:19 ` Arnd Bergmann [this message]
2012-04-03 13:47 ` Paul Gortmaker
2012-04-03 14:26 ` Arnd Bergmann
2012-04-03 16:44 ` Bjorn Helgaas
2012-04-03 19:09 ` Paul Gortmaker
2012-04-03 19:40 ` Arnd Bergmann
2012-04-04 9:08 ` Russell King - ARM Linux
2012-04-04 9:07 ` Russell King - ARM Linux
2012-04-04 13:53 ` Paul Gortmaker
2012-04-04 14:26 ` Russell King - ARM Linux
2012-04-03 4:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204030819.48798.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.