From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: versatile: fix build failure in pci.c
Date: Tue, 3 Apr 2012 14:26:22 +0000 [thread overview]
Message-ID: <201204031426.22652.arnd@arndb.de> (raw)
In-Reply-To: <4F7AFF61.3070803@windriver.com>
On Tuesday 03 April 2012, Paul Gortmaker wrote:
> I'm not sure I'm following you here. I'm not feeding the
> struct pci_sys_data to pci_add_resource_offset. Instead it
> is getting subfields of it, consistent with the rest of the
> original commit from Bjorn.
Sorry, my fault, I thought the suggestion was to pass sys into
pci_add_resource_offset.
However, I would still prefer just reverting the versatile
part of Bjorn's patch because versatile uses a zero offset.
I think we should only pass the offset in cases where it's
actually required because there are multiple buses or they
have interesting mappings to the physical address space.
Those seem to be the minority on ARM anyway.
Arnd
next prev parent reply other threads:[~2012-04-03 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 23:48 [PATCH] ARM: versatile: fix build failure in pci.c Paul Gortmaker
2012-04-03 0:03 ` Fabio Estevam
2012-04-03 1:01 ` Paul Gortmaker
2012-04-03 1:57 ` Fabio Estevam
2012-04-03 8:19 ` Arnd Bergmann
2012-04-03 13:47 ` Paul Gortmaker
2012-04-03 14:26 ` Arnd Bergmann [this message]
2012-04-03 16:44 ` Bjorn Helgaas
2012-04-03 19:09 ` Paul Gortmaker
2012-04-03 19:40 ` Arnd Bergmann
2012-04-04 9:08 ` Russell King - ARM Linux
2012-04-04 9:07 ` Russell King - ARM Linux
2012-04-04 13:53 ` Paul Gortmaker
2012-04-04 14:26 ` Russell King - ARM Linux
2012-04-03 4:58 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204031426.22652.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.